All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Robin Holt <holt@sgi.com>, Cliff Wickman <cpw@sgi.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
	wli@holomorphy.com
Subject: Re: [PATCH] mm, x86: Do not zero hugetlbfs pages at boot. -v2
Date: Wed, 3 Apr 2013 12:00:12 -0500	[thread overview]
Message-ID: <20130403170012.GY29151@sgi.com> (raw)
In-Reply-To: <20130403140247.GJ16471@dhcp22.suse.cz>

On Wed, Apr 03, 2013 at 04:02:47PM +0200, Michal Hocko wrote:
> On Tue 02-04-13 21:43:44, Robin Holt wrote:
> [...]
> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > index ca9a7c6..7683f6a 100644
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -1185,7 +1185,7 @@ int __weak alloc_bootmem_huge_page(struct hstate *h)
> >  	while (nr_nodes) {
> >  		void *addr;
> >  
> > -		addr = __alloc_bootmem_node_nopanic(
> > +		addr = __alloc_bootmem_node_nopanic_notzeroed(
> >  				NODE_DATA(hstate_next_node_to_alloc(h,
> >  						&node_states[N_MEMORY])),
> >  				huge_page_size(h), huge_page_size(h), 0);
> 
> Ohh, and powerpc seems to have its own opinion how to allocate huge
> pages. See arch/powerpc/mm/hugetlbpage.c

Do I need to address their allocations?  Can I leave that part of the
changes as something powerpc can address if they are affected by this?

Robin

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Robin Holt <holt@sgi.com>, Cliff Wickman <cpw@sgi.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
	wli@holomorphy.com
Subject: Re: [PATCH] mm, x86: Do not zero hugetlbfs pages at boot. -v2
Date: Wed, 3 Apr 2013 12:00:12 -0500	[thread overview]
Message-ID: <20130403170012.GY29151@sgi.com> (raw)
In-Reply-To: <20130403140247.GJ16471@dhcp22.suse.cz>

On Wed, Apr 03, 2013 at 04:02:47PM +0200, Michal Hocko wrote:
> On Tue 02-04-13 21:43:44, Robin Holt wrote:
> [...]
> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > index ca9a7c6..7683f6a 100644
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -1185,7 +1185,7 @@ int __weak alloc_bootmem_huge_page(struct hstate *h)
> >  	while (nr_nodes) {
> >  		void *addr;
> >  
> > -		addr = __alloc_bootmem_node_nopanic(
> > +		addr = __alloc_bootmem_node_nopanic_notzeroed(
> >  				NODE_DATA(hstate_next_node_to_alloc(h,
> >  						&node_states[N_MEMORY])),
> >  				huge_page_size(h), huge_page_size(h), 0);
> 
> Ohh, and powerpc seems to have its own opinion how to allocate huge
> pages. See arch/powerpc/mm/hugetlbpage.c

Do I need to address their allocations?  Can I leave that part of the
changes as something powerpc can address if they are affected by this?

Robin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-04-03 17:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 21:50 [PATCH] mm, x86: no zeroing of hugetlbfs pages at boot Cliff Wickman
2013-03-06 21:50 ` Cliff Wickman
2013-03-10  5:55 ` Hillf Danton
2013-03-10  5:55   ` Hillf Danton
2013-03-11 12:32   ` Cliff Wickman
2013-03-11 12:32     ` Cliff Wickman
2013-03-14  8:51 ` Michal Hocko
2013-03-14  8:51   ` Michal Hocko
2013-04-03  2:43   ` [PATCH] mm, x86: Do not zero hugetlbfs pages at boot. -v2 Robin Holt
2013-04-03  2:43     ` Robin Holt
2013-04-03 14:00     ` Michal Hocko
2013-04-03 14:00       ` Michal Hocko
2013-04-03 17:21       ` Robin Holt
2013-04-03 17:21         ` Robin Holt
2013-04-04  8:17         ` Michal Hocko
2013-04-04  8:17           ` Michal Hocko
2013-04-03 14:02     ` Michal Hocko
2013-04-03 14:02       ` Michal Hocko
2013-04-03 17:00       ` Robin Holt [this message]
2013-04-03 17:00         ` Robin Holt
2013-04-04  8:08         ` Michal Hocko
2013-04-04  8:08           ` Michal Hocko
2013-04-04  0:17 ` [PATCH] mm, x86: no zeroing of hugetlbfs pages at boot Simon Jeons
2013-04-04  0:17   ` Simon Jeons
2013-04-04 12:16   ` Cliff Wickman
2013-04-04 12:16     ` Cliff Wickman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130403170012.GY29151@sgi.com \
    --to=holt@sgi.com \
    --cc=cpw@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=wli@holomorphy.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.