All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: shmobile: kzm9g-reference: add CPUFreq support
Date: Fri, 05 Apr 2013 00:40:20 +0000	[thread overview]
Message-ID: <20130405004020.GM29203@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1304042352180.21548@axis700.grange>

On Thu, Apr 04, 2013 at 11:54:20PM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> Thanks for the review
> 
> On Thu, 4 Apr 2013, Simon Horman wrote:
> 
> > On Sun, Mar 24, 2013 at 08:27:35PM +0100, Guennadi Liakhovetski wrote:
> > > This patch enables the use of the generic cpufreq-cpu0 driver on kzm9g.
> > > Providing a regulator, a list of OPPs in DT, combined with a virtual
> > > cpufreq-cpu0 platform device and a clock, attached to it is everything,
> > > the cpufreq-cpu0 driver needs.
> > 
> > I wonder if it would be possible to re-arange this patch a little.
> > 
> > 1) vdd_dvfs is added in this patch but it appears to be used in the
> >    previous patch in the series. I wonder if this can be resolved
> >    by re-ordering the patches.
> 
> Right, I'll change that.
> 
> > 2) It includes both kzm9g board and sh73a0 SoC changes.
> >    I would prefer if the sh73a0 SoC portion (setup-sh73a0.c)
> >    was moved into a separate patch. The arm-soc people
> >    like to have separate board and SoC branches.
> 
> Yes, I'll probably just merge the sh73a0-kzm9g-reference.dts hunk into the 
> previous patch.

Thanks, I think that approach should work well.

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] ARM: shmobile: kzm9g-reference: add CPUFreq support
Date: Fri, 5 Apr 2013 09:40:20 +0900	[thread overview]
Message-ID: <20130405004020.GM29203@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1304042352180.21548@axis700.grange>

On Thu, Apr 04, 2013 at 11:54:20PM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> Thanks for the review
> 
> On Thu, 4 Apr 2013, Simon Horman wrote:
> 
> > On Sun, Mar 24, 2013 at 08:27:35PM +0100, Guennadi Liakhovetski wrote:
> > > This patch enables the use of the generic cpufreq-cpu0 driver on kzm9g.
> > > Providing a regulator, a list of OPPs in DT, combined with a virtual
> > > cpufreq-cpu0 platform device and a clock, attached to it is everything,
> > > the cpufreq-cpu0 driver needs.
> > 
> > I wonder if it would be possible to re-arange this patch a little.
> > 
> > 1) vdd_dvfs is added in this patch but it appears to be used in the
> >    previous patch in the series. I wonder if this can be resolved
> >    by re-ordering the patches.
> 
> Right, I'll change that.
> 
> > 2) It includes both kzm9g board and sh73a0 SoC changes.
> >    I would prefer if the sh73a0 SoC portion (setup-sh73a0.c)
> >    was moved into a separate patch. The arm-soc people
> >    like to have separate board and SoC branches.
> 
> Yes, I'll probably just merge the sh73a0-kzm9g-reference.dts hunk into the 
> previous patch.

Thanks, I think that approach should work well.

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	cpufreq@vger.kernel.org
Subject: Re: [PATCH v4 3/3] ARM: shmobile: kzm9g-reference: add CPUFreq support
Date: Fri, 5 Apr 2013 09:40:20 +0900	[thread overview]
Message-ID: <20130405004020.GM29203@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1304042352180.21548@axis700.grange>

On Thu, Apr 04, 2013 at 11:54:20PM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> Thanks for the review
> 
> On Thu, 4 Apr 2013, Simon Horman wrote:
> 
> > On Sun, Mar 24, 2013 at 08:27:35PM +0100, Guennadi Liakhovetski wrote:
> > > This patch enables the use of the generic cpufreq-cpu0 driver on kzm9g.
> > > Providing a regulator, a list of OPPs in DT, combined with a virtual
> > > cpufreq-cpu0 platform device and a clock, attached to it is everything,
> > > the cpufreq-cpu0 driver needs.
> > 
> > I wonder if it would be possible to re-arange this patch a little.
> > 
> > 1) vdd_dvfs is added in this patch but it appears to be used in the
> >    previous patch in the series. I wonder if this can be resolved
> >    by re-ordering the patches.
> 
> Right, I'll change that.
> 
> > 2) It includes both kzm9g board and sh73a0 SoC changes.
> >    I would prefer if the sh73a0 SoC portion (setup-sh73a0.c)
> >    was moved into a separate patch. The arm-soc people
> >    like to have separate board and SoC branches.
> 
> Yes, I'll probably just merge the sh73a0-kzm9g-reference.dts hunk into the 
> previous patch.

Thanks, I think that approach should work well.

  reply	other threads:[~2013-04-05  0:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 19:27 [PATCH v4 0/3] CPUFreq for sh73a0 / kzm9g, using cpufreq-cpu0 Guennadi Liakhovetski
2013-03-24 19:27 ` Guennadi Liakhovetski
2013-03-24 19:27 ` Guennadi Liakhovetski
2013-03-24 19:27 ` [PATCH v4 1/3] ARM: shmobile: sh73a0: add support for adjusting CPU frequency Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-03-24 19:27 ` [PATCH v4 2/3] ARM: shmobile: kzm9g-reference: add AS3711 and CPUFreq DT bindings Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-03-24 19:27 ` [PATCH v4 3/3] ARM: shmobile: kzm9g-reference: add CPUFreq support Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-03-24 19:27   ` Guennadi Liakhovetski
2013-04-04  4:37   ` Simon Horman
2013-04-04  4:37     ` Simon Horman
2013-04-04  4:37     ` Simon Horman
2013-04-04 21:54     ` Guennadi Liakhovetski
2013-04-04 21:54       ` Guennadi Liakhovetski
2013-04-04 21:54       ` Guennadi Liakhovetski
2013-04-05  0:40       ` Simon Horman [this message]
2013-04-05  0:40         ` Simon Horman
2013-04-05  0:40         ` Simon Horman
2013-03-27  5:29 ` [PATCH v4 0/3] CPUFreq for sh73a0 / kzm9g, using cpufreq-cpu0 Simon Horman
2013-03-27  5:29   ` Simon Horman
2013-03-27  5:29   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130405004020.GM29203@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.