From: Borislav Petkov <bp@alien8.de>
To: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Mon, 8 Apr 2013 20:48:36 +0200 [thread overview]
Message-ID: <20130408184836.GI4395@pd.tnic> (raw)
In-Reply-To: <5162E5B1.2030707@amd.com>
On Mon, Apr 08, 2013 at 10:43:45AM -0500, Suravee Suthikulanit wrote:
> On 4/8/2013 9:50 AM, Borislav Petkov wrote:
> >Independent from Joerg's feedback on this, I have only one question:
> >you're not seriously considering on dumping this "Note:..." line above
> >on*every* IO-PF, right?
> If you think that is obvious, I can get rid of this also.
I don't know whether it is obvious or not, but this thing doesn't belong
there. I'm sure you can think of a much better fitting location to point
to the documentation. And while you do that, you can simply add a link
to the pdf version of the spec so that people don't have to look for it
at all.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Suravee Suthikulanit
<suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Mon, 8 Apr 2013 20:48:36 +0200 [thread overview]
Message-ID: <20130408184836.GI4395@pd.tnic> (raw)
In-Reply-To: <5162E5B1.2030707-5C7GfCeVMHo@public.gmane.org>
On Mon, Apr 08, 2013 at 10:43:45AM -0500, Suravee Suthikulanit wrote:
> On 4/8/2013 9:50 AM, Borislav Petkov wrote:
> >Independent from Joerg's feedback on this, I have only one question:
> >you're not seriously considering on dumping this "Note:..." line above
> >on*every* IO-PF, right?
> If you think that is obvious, I can get rid of this also.
I don't know whether it is obvious or not, but this thing doesn't belong
there. I'm sure you can think of a much better fitting location to point
to the documentation. And while you do that, you can simply add a link
to the pdf version of the spec so that people don't have to look for it
at all.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-08 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 0:06 [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag suravee.suthikulpanit
2013-04-03 0:06 ` suravee.suthikulpanit
2013-04-08 14:33 ` Suthikulpanit, Suravee
2013-04-08 14:50 ` Borislav Petkov
2013-04-08 14:50 ` Borislav Petkov
[not found] ` <20130408145003.GC4723-fF5Pk5pvG8Y@public.gmane.org>
2013-04-08 15:43 ` Suravee Suthikulanit
2013-04-08 18:48 ` Borislav Petkov [this message]
2013-04-08 18:48 ` Borislav Petkov
2013-04-09 9:41 ` Joerg Roedel
2013-04-09 9:41 ` Joerg Roedel
2013-04-09 15:12 ` Suravee Suthikulanit
2013-04-09 15:12 ` Suravee Suthikulanit
2013-04-09 19:52 ` Joerg Roedel
2013-04-09 19:52 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408184836.GI4395@pd.tnic \
--to=bp@alien8.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.