All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Will Deacon <Will.Deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: compiling issue, need add include/asm/vga.h file
Date: Wed, 24 Apr 2013 11:42:31 +0100	[thread overview]
Message-ID: <20130424104231.GJ23397@arm.com> (raw)
In-Reply-To: <5177B1F0.10106@asianux.com>

On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote:
> For compiling with allmodconfig, need vga.h file, so generate it which
> just only include the asm-generic one.
> 
> It is firstly used by drivers/gpu/drm/drm_irq.c.
> 
> The related error:
> include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/arm64/include/asm/vga.h |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm64/include/asm/vga.h

As Will said, please use asm/Kbuild.

> diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h
> new file mode 100644
> index 0000000..1c49d51
> --- /dev/null
> +++ b/arch/arm64/include/asm/vga.h
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (C) 2012 ARM Ltd.

ARM copyright? You either work for ARM or there is a copyright
assignment between you and ARM ;)

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: compiling issue, need add include/asm/vga.h file
Date: Wed, 24 Apr 2013 11:42:31 +0100	[thread overview]
Message-ID: <20130424104231.GJ23397@arm.com> (raw)
In-Reply-To: <5177B1F0.10106@asianux.com>

On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote:
> For compiling with allmodconfig, need vga.h file, so generate it which
> just only include the asm-generic one.
> 
> It is firstly used by drivers/gpu/drm/drm_irq.c.
> 
> The related error:
> include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/arm64/include/asm/vga.h |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm64/include/asm/vga.h

As Will said, please use asm/Kbuild.

> diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h
> new file mode 100644
> index 0000000..1c49d51
> --- /dev/null
> +++ b/arch/arm64/include/asm/vga.h
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (C) 2012 ARM Ltd.

ARM copyright? You either work for ARM or there is a copyright
assignment between you and ARM ;)

-- 
Catalin

  parent reply	other threads:[~2013-04-24 10:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24  3:44 [PATCH] arm64: compiling issue, need add include/asm/vga.h file Chen Gang
2013-04-24  3:44 ` Chen Gang
2013-04-24  8:22 ` Catalin Marinas
2013-04-24  8:22   ` Catalin Marinas
2013-04-24  8:44   ` Chen Gang
2013-04-24  8:44     ` Chen Gang
2013-04-24 10:20   ` [PATCH v2] " Chen Gang
2013-04-24 10:20     ` Chen Gang
2013-04-24 10:23     ` Will Deacon
2013-04-24 10:23       ` Will Deacon
2013-04-24 10:50       ` Chen Gang
2013-04-24 10:50         ` Chen Gang
2013-04-24 10:58       ` [PATCH v3] " Chen Gang
2013-04-24 10:58         ` Chen Gang
2013-04-24 11:05         ` Catalin Marinas
2013-04-24 11:05           ` Catalin Marinas
2013-04-24 11:06           ` Chen Gang
2013-04-24 11:06             ` Chen Gang
2013-05-20  4:19           ` [PATCH] arm64: compiling issue for allmodconfig, need "asm/parport.h" by "drivers/parport/parport_pc.c" Chen Gang
2013-05-20  4:19             ` Chen Gang
2013-05-21 13:17             ` Catalin Marinas
2013-05-21 13:17               ` Catalin Marinas
2013-05-22  0:45               ` Chen Gang
2013-05-22  0:45                 ` Chen Gang
2013-05-22  7:32                 ` Chen Gang
2013-05-22  7:32                   ` Chen Gang
2013-05-28 17:02                   ` Catalin Marinas
2013-05-28 17:02                     ` Catalin Marinas
2013-05-29  2:06                     ` Chen Gang
2013-05-29  2:06                       ` Chen Gang
2013-04-24 10:42     ` Catalin Marinas [this message]
2013-04-24 10:42       ` [PATCH v2] arm64: compiling issue, need add include/asm/vga.h file Catalin Marinas
2013-04-24 10:51       ` Chen Gang
2013-04-24 10:51         ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424104231.GJ23397@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=gang.chen@asianux.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.