From: Mel Gorman <mgorman@suse.de>
To: Glauber Costa <glommer@parallels.com>
Cc: Glauber Costa <glommer@openvz.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
hughd@google.com, Greg Thelen <gthelen@google.com>,
linux-fsdevel@vger.kernel.org, Dave Chinner <dchinner@redhat.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Kent Overstreet <koverstreet@google.com>,
Arve Hj?nnev?g <arve@android.com>,
John Stultz <john.stultz@linaro.org>,
David Rientjes <rientjes@google.com>,
Jerome Glisse <jglisse@redhat.com>,
Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [PATCH v5 17/31] drivers: convert shrinkers to new count/scan API
Date: Fri, 10 May 2013 10:00:26 +0100 [thread overview]
Message-ID: <20130510090026.GJ11497@suse.de> (raw)
In-Reply-To: <518C12D6.4060003@parallels.com>
On Fri, May 10, 2013 at 01:19:18AM +0400, Glauber Costa wrote:
> >
> > Last time I complained about some of the shrinker implementations but
> > I'm not expecting them to be fixed in this series. However I still have
> > questions about where -1 should be returned that I don't think were
> > addressed so I'll repeat them.
> >
>
> Note that the series try to keep the same behavior as we had before.
> (modulo mistakes, spotting them are mostly welcome)
>
> So if we are changing any of this, maybe better done in a separate patch?
>
Ok, that's fair enough and a separate patch does make sense. I thought
it was an oversight when the -1 return value was documented but not all
callers were updated even though it looked appropriate. Slap a comment
above the highlighted places suggesting that a return value of -1 be used
instead so it does not get lost maybe?
Whether you do that or not
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-10 9:00 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 6:06 [PATCH v5 00/31] kmemcg shrinkers Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 01/31] super: fix calculation of shrinkable objects for small numbers Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 02/31] vmscan: take at least one pass with shrinkers Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 11:12 ` Mel Gorman
2013-05-09 11:12 ` Mel Gorman
[not found] ` <20130509111226.GR11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 11:28 ` Glauber Costa
2013-05-09 11:28 ` Glauber Costa
2013-05-09 11:28 ` Glauber Costa
[not found] ` <518B884C.9090704-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-05-09 11:35 ` Glauber Costa
2013-05-09 11:35 ` Glauber Costa
2013-05-09 11:35 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 03/31] dcache: convert dentry_stat.nr_unused to per-cpu counters Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 04/31] dentry: move to per-sb LRU locks Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
[not found] ` <1368079608-5611-5-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-10 5:29 ` Dave Chinner
2013-05-10 5:29 ` Dave Chinner
2013-05-10 8:16 ` Dave Chinner
2013-05-09 6:06 ` [PATCH v5 05/31] dcache: remove dentries from LRU before putting on dispose list Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 06/31] mm: new shrinker API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 13:30 ` Mel Gorman
[not found] ` <1368079608-5611-1-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-09 6:06 ` [PATCH v5 07/31] shrinker: convert superblock shrinkers to new API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 13:33 ` Mel Gorman
2013-05-09 6:06 ` [PATCH v5 08/31] list: add a new LRU list type Glauber Costa
2013-05-09 6:06 ` Glauber Costa
[not found] ` <1368079608-5611-9-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-09 13:37 ` Mel Gorman
2013-05-09 13:37 ` Mel Gorman
[not found] ` <20130509133742.GW11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 21:02 ` Glauber Costa
2013-05-09 21:02 ` Glauber Costa
2013-05-09 21:02 ` Glauber Costa
2013-05-10 9:21 ` Mel Gorman
2013-05-10 9:56 ` Glauber Costa
2013-05-10 9:56 ` Glauber Costa
[not found] ` <518CC44D.1020409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-05-10 10:01 ` Mel Gorman
2013-05-10 10:01 ` Mel Gorman
2013-05-09 6:06 ` [PATCH v5 09/31] inode: convert inode lru list to generic lru list code Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 10/31] dcache: convert to use new lru list infrastructure Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 11/31] list_lru: per-node " Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 13:42 ` Mel Gorman
[not found] ` <20130509134246.GX11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 21:05 ` Glauber Costa
2013-05-09 21:05 ` Glauber Costa
2013-05-09 21:05 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 12/31] shrinker: add node awareness Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 13/31] fs: convert inode and dentry shrinking to be node aware Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 14/31] xfs: convert buftarg LRU to generic code Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
[not found] ` <1368079608-5611-15-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-09 13:43 ` Mel Gorman
2013-05-09 13:43 ` Mel Gorman
2013-05-09 6:06 ` [PATCH v5 15/31] xfs: convert dquot cache lru to list_lru Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 16/31] fs: convert fs shrinkers to new scan/count API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 17/31] drivers: convert shrinkers to new count/scan API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 13:52 ` Mel Gorman
2013-05-09 13:52 ` Mel Gorman
[not found] ` <20130509135209.GZ11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 21:19 ` Glauber Costa
2013-05-09 21:19 ` Glauber Costa
2013-05-09 21:19 ` Glauber Costa
2013-05-10 9:00 ` Mel Gorman [this message]
2013-05-09 6:06 ` [PATCH v5 18/31] shrinker: convert remaining shrinkers to " Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 19/31] hugepage: convert huge zero page shrinker to new shrinker API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
[not found] ` <1368079608-5611-20-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-10 1:24 ` Kirill A. Shutemov
2013-05-10 1:24 ` Kirill A. Shutemov
2013-05-09 6:06 ` [PATCH v5 20/31] shrinker: Kill old ->shrink API Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 13:53 ` Mel Gorman
2013-05-09 6:06 ` [PATCH v5 21/31] vmscan: also shrink slab in memcg pressure Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 22/31] memcg,list_lru: duplicate LRUs upon kmemcg creation Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 23/31] lru: add an element to a memcg list Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 24/31] list_lru: per-memcg walks Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 25/31] memcg: per-memcg kmem shrinking Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 26/31] memcg: scan cache objects hierarchically Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 27/31] super: targeted memcg reclaim Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 28/31] memcg: move initialization to memcg creation Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 29/31] vmpressure: in-kernel notifications Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 30/31] memcg: reap dead memcgs upon global memory pressure Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` [PATCH v5 31/31] memcg: debugging facility to access dangling memcgs Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 6:06 ` Glauber Costa
2013-05-09 10:55 ` [PATCH v5 00/31] kmemcg shrinkers Mel Gorman
[not found] ` <20130509105519.GQ11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 11:34 ` Glauber Costa
2013-05-09 11:34 ` Glauber Costa
2013-05-09 11:34 ` Glauber Costa
2013-05-09 13:18 ` Dave Chinner
2013-05-09 14:03 ` Mel Gorman
[not found] ` <20130509140311.GB11497-l3A5Bk7waGM@public.gmane.org>
2013-05-09 21:24 ` Glauber Costa
2013-05-09 21:24 ` Glauber Costa
2013-05-09 21:24 ` Glauber Costa
-- strict thread matches above, loose matches on Subject: below --
2013-05-08 20:22 Glauber Costa
2013-05-08 20:23 ` [PATCH v5 17/31] drivers: convert shrinkers to new count/scan API Glauber Costa
2013-05-08 20:23 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510090026.GJ11497@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dchinner@redhat.com \
--cc=glommer@openvz.org \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=john.stultz@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=koverstreet@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.