From: Glauber Costa <glommer@openvz.org> To: <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, <cgroups@vger.kernel.org>, <kamezawa.hiroyu@jp.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.cz>, hughd@google.com, Greg Thelen <gthelen@google.com>, <linux-fsdevel@vger.kernel.org>, Dave Chinner <dchinner@redhat.com>, Glauber Costa <glommer@openvz.org> Subject: [PATCH v5 20/31] shrinker: Kill old ->shrink API. Date: Thu, 9 May 2013 10:06:37 +0400 [thread overview] Message-ID: <1368079608-5611-21-git-send-email-glommer@openvz.org> (raw) In-Reply-To: <1368079608-5611-1-git-send-email-glommer@openvz.org> From: Dave Chinner <dchinner@redhat.com> There are no more users of this API, so kill it dead, dead, dead and quietly bury the corpse in a shallow, unmarked grave in a dark forest deep in the hills... [ glommer: added flowers to the grave ] Signed-off-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Glauber Costa <glommer@openvz.org> Reviewed-by: Greg Thelen <gthelen@google.com> --- include/linux/shrinker.h | 15 +++++---------- include/trace/events/vmscan.h | 4 ++-- mm/vmscan.c | 41 ++++++++--------------------------------- 3 files changed, 15 insertions(+), 45 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 98be3ab..00a3e57 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -7,14 +7,15 @@ * * The 'gfpmask' refers to the allocation we are currently trying to * fulfil. - * - * Note that 'shrink' will be passed nr_to_scan == 0 when the VM is - * querying the cache size, so a fastpath for that case is appropriate. */ struct shrink_control { gfp_t gfp_mask; - /* How many slab objects shrinker() should scan and try to reclaim */ + /* + * How many objects scan_objects should scan and try to reclaim. + * This is reset before every call, so it is safe for callees + * to modify. + */ long nr_to_scan; /* shrink from these nodes */ @@ -24,11 +25,6 @@ struct shrink_control { /* * A callback you can register to apply pressure to ageable caches. * - * @shrink() should look through the least-recently-used 'nr_to_scan' entries - * and attempt to free them up. It should return the number of objects which - * remain in the cache. If it returns -1, it means it cannot do any scanning at - * this time (eg. there is a risk of deadlock). - * * @count_objects should return the number of freeable items in the cache. If * there are no objects to free or the number of freeable items cannot be * determined, it should return 0. No deadlock checks should be done during the @@ -44,7 +40,6 @@ struct shrink_control { * @scan_objects will be made from the current reclaim context. */ struct shrinker { - int (*shrink)(struct shrinker *, struct shrink_control *sc); long (*count_objects)(struct shrinker *, struct shrink_control *sc); long (*scan_objects)(struct shrinker *, struct shrink_control *sc); diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index 63cfccc..132a985 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -202,7 +202,7 @@ TRACE_EVENT(mm_shrink_slab_start, TP_fast_assign( __entry->shr = shr; - __entry->shrink = shr->shrink; + __entry->shrink = shr->scan_objects; __entry->nr_objects_to_shrink = nr_objects_to_shrink; __entry->gfp_flags = sc->gfp_mask; __entry->pgs_scanned = pgs_scanned; @@ -241,7 +241,7 @@ TRACE_EVENT(mm_shrink_slab_end, TP_fast_assign( __entry->shr = shr; - __entry->shrink = shr->shrink; + __entry->shrink = shr->scan_objects; __entry->unused_scan = unused_scan_cnt; __entry->new_scan = new_scan_cnt; __entry->retval = shrinker_retval; diff --git a/mm/vmscan.c b/mm/vmscan.c index 3ab5291..024e9c9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -177,14 +177,6 @@ void unregister_shrinker(struct shrinker *shrinker) } EXPORT_SYMBOL(unregister_shrinker); -static inline int do_shrinker_shrink(struct shrinker *shrinker, - struct shrink_control *sc, - unsigned long nr_to_scan) -{ - sc->nr_to_scan = nr_to_scan; - return (*shrinker->shrink)(shrinker, sc); -} - #define SHRINK_BATCH 128 /* * Call the shrink functions to age shrinkable caches @@ -230,11 +222,8 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, long batch_size = shrinker->batch ? shrinker->batch : SHRINK_BATCH; - if (shrinker->scan_objects) { - max_pass = shrinker->count_objects(shrinker, shrinkctl); - WARN_ON(max_pass < 0); - } else - max_pass = do_shrinker_shrink(shrinker, shrinkctl, 0); + max_pass = shrinker->count_objects(shrinker, shrinkctl); + WARN_ON(max_pass < 0); if (max_pass <= 0) continue; @@ -253,7 +242,7 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, if (total_scan < 0) { printk(KERN_ERR "shrink_slab: %pF negative objects to delete nr=%ld\n", - shrinker->shrink, total_scan); + shrinker->scan_objects, total_scan); total_scan = max_pass; } @@ -305,25 +294,11 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, if (!total_scan) break; - if (shrinker->scan_objects) { - shrinkctl->nr_to_scan = min(batch_size, total_scan); - ret = shrinker->scan_objects(shrinker, shrinkctl); - - if (ret == -1) - break; - freed += ret; - } else { - int nr_before; - - nr_before = do_shrinker_shrink(shrinker, - shrinkctl, 0); - ret = do_shrinker_shrink(shrinker, shrinkctl, - min(batch_size, total_scan)); - if (ret == -1) - break; - if (ret < nr_before) - freed += nr_before - ret; - } + shrinkctl->nr_to_scan = min(batch_size, total_scan); + ret = shrinker->scan_objects(shrinker, shrinkctl); + if (ret == -1) + break; + freed += ret; count_vm_events(SLABS_SCANNED, batch_size); total_scan -= batch_size; -- 1.8.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@openvz.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.cz>, hughd@google.com, Greg Thelen <gthelen@google.com>, linux-fsdevel@vger.kernel.org, Dave Chinner <dchinner@redhat.com>, Glauber Costa <glommer@openvz.org> Subject: [PATCH v5 20/31] shrinker: Kill old ->shrink API. Date: Thu, 9 May 2013 10:06:37 +0400 [thread overview] Message-ID: <1368079608-5611-21-git-send-email-glommer@openvz.org> (raw) In-Reply-To: <1368079608-5611-1-git-send-email-glommer@openvz.org> From: Dave Chinner <dchinner@redhat.com> There are no more users of this API, so kill it dead, dead, dead and quietly bury the corpse in a shallow, unmarked grave in a dark forest deep in the hills... [ glommer: added flowers to the grave ] Signed-off-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Glauber Costa <glommer@openvz.org> Reviewed-by: Greg Thelen <gthelen@google.com> --- include/linux/shrinker.h | 15 +++++---------- include/trace/events/vmscan.h | 4 ++-- mm/vmscan.c | 41 ++++++++--------------------------------- 3 files changed, 15 insertions(+), 45 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 98be3ab..00a3e57 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -7,14 +7,15 @@ * * The 'gfpmask' refers to the allocation we are currently trying to * fulfil. - * - * Note that 'shrink' will be passed nr_to_scan == 0 when the VM is - * querying the cache size, so a fastpath for that case is appropriate. */ struct shrink_control { gfp_t gfp_mask; - /* How many slab objects shrinker() should scan and try to reclaim */ + /* + * How many objects scan_objects should scan and try to reclaim. + * This is reset before every call, so it is safe for callees + * to modify. + */ long nr_to_scan; /* shrink from these nodes */ @@ -24,11 +25,6 @@ struct shrink_control { /* * A callback you can register to apply pressure to ageable caches. * - * @shrink() should look through the least-recently-used 'nr_to_scan' entries - * and attempt to free them up. It should return the number of objects which - * remain in the cache. If it returns -1, it means it cannot do any scanning at - * this time (eg. there is a risk of deadlock). - * * @count_objects should return the number of freeable items in the cache. If * there are no objects to free or the number of freeable items cannot be * determined, it should return 0. No deadlock checks should be done during the @@ -44,7 +40,6 @@ struct shrink_control { * @scan_objects will be made from the current reclaim context. */ struct shrinker { - int (*shrink)(struct shrinker *, struct shrink_control *sc); long (*count_objects)(struct shrinker *, struct shrink_control *sc); long (*scan_objects)(struct shrinker *, struct shrink_control *sc); diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index 63cfccc..132a985 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -202,7 +202,7 @@ TRACE_EVENT(mm_shrink_slab_start, TP_fast_assign( __entry->shr = shr; - __entry->shrink = shr->shrink; + __entry->shrink = shr->scan_objects; __entry->nr_objects_to_shrink = nr_objects_to_shrink; __entry->gfp_flags = sc->gfp_mask; __entry->pgs_scanned = pgs_scanned; @@ -241,7 +241,7 @@ TRACE_EVENT(mm_shrink_slab_end, TP_fast_assign( __entry->shr = shr; - __entry->shrink = shr->shrink; + __entry->shrink = shr->scan_objects; __entry->unused_scan = unused_scan_cnt; __entry->new_scan = new_scan_cnt; __entry->retval = shrinker_retval; diff --git a/mm/vmscan.c b/mm/vmscan.c index 3ab5291..024e9c9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -177,14 +177,6 @@ void unregister_shrinker(struct shrinker *shrinker) } EXPORT_SYMBOL(unregister_shrinker); -static inline int do_shrinker_shrink(struct shrinker *shrinker, - struct shrink_control *sc, - unsigned long nr_to_scan) -{ - sc->nr_to_scan = nr_to_scan; - return (*shrinker->shrink)(shrinker, sc); -} - #define SHRINK_BATCH 128 /* * Call the shrink functions to age shrinkable caches @@ -230,11 +222,8 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, long batch_size = shrinker->batch ? shrinker->batch : SHRINK_BATCH; - if (shrinker->scan_objects) { - max_pass = shrinker->count_objects(shrinker, shrinkctl); - WARN_ON(max_pass < 0); - } else - max_pass = do_shrinker_shrink(shrinker, shrinkctl, 0); + max_pass = shrinker->count_objects(shrinker, shrinkctl); + WARN_ON(max_pass < 0); if (max_pass <= 0) continue; @@ -253,7 +242,7 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, if (total_scan < 0) { printk(KERN_ERR "shrink_slab: %pF negative objects to delete nr=%ld\n", - shrinker->shrink, total_scan); + shrinker->scan_objects, total_scan); total_scan = max_pass; } @@ -305,25 +294,11 @@ unsigned long shrink_slab(struct shrink_control *shrinkctl, if (!total_scan) break; - if (shrinker->scan_objects) { - shrinkctl->nr_to_scan = min(batch_size, total_scan); - ret = shrinker->scan_objects(shrinker, shrinkctl); - - if (ret == -1) - break; - freed += ret; - } else { - int nr_before; - - nr_before = do_shrinker_shrink(shrinker, - shrinkctl, 0); - ret = do_shrinker_shrink(shrinker, shrinkctl, - min(batch_size, total_scan)); - if (ret == -1) - break; - if (ret < nr_before) - freed += nr_before - ret; - } + shrinkctl->nr_to_scan = min(batch_size, total_scan); + ret = shrinker->scan_objects(shrinker, shrinkctl); + if (ret == -1) + break; + freed += ret; count_vm_events(SLABS_SCANNED, batch_size); total_scan -= batch_size; -- 1.8.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-09 6:06 UTC|newest] Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-09 6:06 [PATCH v5 00/31] kmemcg shrinkers Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 01/31] super: fix calculation of shrinkable objects for small numbers Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 02/31] vmscan: take at least one pass with shrinkers Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 11:12 ` Mel Gorman 2013-05-09 11:12 ` Mel Gorman [not found] ` <20130509111226.GR11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 11:28 ` Glauber Costa 2013-05-09 11:28 ` Glauber Costa 2013-05-09 11:28 ` Glauber Costa [not found] ` <518B884C.9090704-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> 2013-05-09 11:35 ` Glauber Costa 2013-05-09 11:35 ` Glauber Costa 2013-05-09 11:35 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 03/31] dcache: convert dentry_stat.nr_unused to per-cpu counters Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 04/31] dentry: move to per-sb LRU locks Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa [not found] ` <1368079608-5611-5-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> 2013-05-10 5:29 ` Dave Chinner 2013-05-10 5:29 ` Dave Chinner 2013-05-10 8:16 ` Dave Chinner 2013-05-09 6:06 ` [PATCH v5 05/31] dcache: remove dentries from LRU before putting on dispose list Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 06/31] mm: new shrinker API Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 13:30 ` Mel Gorman [not found] ` <1368079608-5611-1-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> 2013-05-09 6:06 ` [PATCH v5 07/31] shrinker: convert superblock shrinkers to new API Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 13:33 ` Mel Gorman 2013-05-09 6:06 ` [PATCH v5 08/31] list: add a new LRU list type Glauber Costa 2013-05-09 6:06 ` Glauber Costa [not found] ` <1368079608-5611-9-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> 2013-05-09 13:37 ` Mel Gorman 2013-05-09 13:37 ` Mel Gorman [not found] ` <20130509133742.GW11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 21:02 ` Glauber Costa 2013-05-09 21:02 ` Glauber Costa 2013-05-09 21:02 ` Glauber Costa 2013-05-10 9:21 ` Mel Gorman 2013-05-10 9:56 ` Glauber Costa 2013-05-10 9:56 ` Glauber Costa [not found] ` <518CC44D.1020409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> 2013-05-10 10:01 ` Mel Gorman 2013-05-10 10:01 ` Mel Gorman 2013-05-09 6:06 ` [PATCH v5 09/31] inode: convert inode lru list to generic lru list code Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 10/31] dcache: convert to use new lru list infrastructure Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 11/31] list_lru: per-node " Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 13:42 ` Mel Gorman [not found] ` <20130509134246.GX11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 21:05 ` Glauber Costa 2013-05-09 21:05 ` Glauber Costa 2013-05-09 21:05 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 12/31] shrinker: add node awareness Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 13/31] fs: convert inode and dentry shrinking to be node aware Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 14/31] xfs: convert buftarg LRU to generic code Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa [not found] ` <1368079608-5611-15-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> 2013-05-09 13:43 ` Mel Gorman 2013-05-09 13:43 ` Mel Gorman 2013-05-09 6:06 ` [PATCH v5 15/31] xfs: convert dquot cache lru to list_lru Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 16/31] fs: convert fs shrinkers to new scan/count API Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 17/31] drivers: convert shrinkers to new count/scan API Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 13:52 ` Mel Gorman 2013-05-09 13:52 ` Mel Gorman [not found] ` <20130509135209.GZ11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 21:19 ` Glauber Costa 2013-05-09 21:19 ` Glauber Costa 2013-05-09 21:19 ` Glauber Costa 2013-05-10 9:00 ` Mel Gorman 2013-05-09 6:06 ` [PATCH v5 18/31] shrinker: convert remaining shrinkers to " Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 19/31] hugepage: convert huge zero page shrinker to new shrinker API Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa [not found] ` <1368079608-5611-20-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> 2013-05-10 1:24 ` Kirill A. Shutemov 2013-05-10 1:24 ` Kirill A. Shutemov 2013-05-09 6:06 ` Glauber Costa [this message] 2013-05-09 6:06 ` [PATCH v5 20/31] shrinker: Kill old ->shrink API Glauber Costa 2013-05-09 13:53 ` Mel Gorman 2013-05-09 6:06 ` [PATCH v5 21/31] vmscan: also shrink slab in memcg pressure Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 22/31] memcg,list_lru: duplicate LRUs upon kmemcg creation Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 23/31] lru: add an element to a memcg list Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 24/31] list_lru: per-memcg walks Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 25/31] memcg: per-memcg kmem shrinking Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 26/31] memcg: scan cache objects hierarchically Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 27/31] super: targeted memcg reclaim Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 28/31] memcg: move initialization to memcg creation Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 29/31] vmpressure: in-kernel notifications Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 30/31] memcg: reap dead memcgs upon global memory pressure Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` [PATCH v5 31/31] memcg: debugging facility to access dangling memcgs Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 6:06 ` Glauber Costa 2013-05-09 10:55 ` [PATCH v5 00/31] kmemcg shrinkers Mel Gorman [not found] ` <20130509105519.GQ11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 11:34 ` Glauber Costa 2013-05-09 11:34 ` Glauber Costa 2013-05-09 11:34 ` Glauber Costa 2013-05-09 13:18 ` Dave Chinner 2013-05-09 14:03 ` Mel Gorman [not found] ` <20130509140311.GB11497-l3A5Bk7waGM@public.gmane.org> 2013-05-09 21:24 ` Glauber Costa 2013-05-09 21:24 ` Glauber Costa 2013-05-09 21:24 ` Glauber Costa -- strict thread matches above, loose matches on Subject: below -- 2013-05-08 20:22 Glauber Costa 2013-05-08 20:23 ` [PATCH v5 20/31] shrinker: Kill old ->shrink API Glauber Costa 2013-05-08 20:23 ` Glauber Costa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1368079608-5611-21-git-send-email-glommer@openvz.org \ --to=glommer@openvz.org \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=dchinner@redhat.com \ --cc=gthelen@google.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.