From: Oleg Nesterov <oleg@redhat.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command
Date: Mon, 13 May 2013 15:59:47 +0200 [thread overview]
Message-ID: <20130513135947.GA1613@redhat.com> (raw)
In-Reply-To: <CAKi4VAK3paytaMGBmu0oVGcLUeuCbL7i3aht-Ho7rz7cdf5KTg@mail.gmail.com>
On 05/10, Lucas De Marchi wrote:
>
> On Fri, May 10, 2013 at 2:35 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 05/10, Oleg Nesterov wrote:
> >>
> >> > > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe";
> >> > > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --";
> >>
> >> No. This is incompatible change, we shouldn't do this.
> >
> > Exactly. This can break a distro which writes to sys/kernel/modprobe.
> >
> > And if we do not do this, you can simply make a single trivial patch
> > which does
...
> > that it all. (or perhaps a kernel parameter makes more sense).
> >
> > Yes, this doesn't allow to pass the additional arguments, but is it
> > that important?
>
> Yes, because I don't want to simply change the binary to use, I want
> to be able to use a general "kmod" binary that accept a command like
> "load". Next version of kmod will accept things like this (see the
> commit message in patch 3/3):
Well, but a link to the binary which checks argv[0] or a trivial executable
which simply execs "kmod load" looks like the simple workaround. And this
doesn't need to recompile the kernel.
Lucas, I simply do not know...
Andrew, Rusty, what do you think? Can we do the change above? Do we
really want CONFIG_MODPROBE_PATH or a kernel parameter ?
Oleg.
next prev parent reply other threads:[~2013-05-13 14:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 4:15 [PATCH 1/3] argv_split(): Allow extra params Lucas De Marchi
2013-05-10 4:15 ` [PATCH 2/3] kmod: Use argv_split(), passing module as extra param Lucas De Marchi
2013-05-10 4:15 ` [PATCH 3/3] init/Kconfig: Add option to set modprobe command Lucas De Marchi
2013-05-10 12:58 ` Oleg Nesterov
2013-05-10 13:12 ` Oleg Nesterov
2013-05-10 13:15 ` Lucas De Marchi
2013-05-10 15:36 ` Oleg Nesterov
2013-05-10 16:03 ` Lucas De Marchi
2013-05-10 17:10 ` Oleg Nesterov
2013-05-10 17:35 ` Oleg Nesterov
2013-05-10 17:44 ` Lucas De Marchi
2013-05-13 13:59 ` Oleg Nesterov [this message]
2013-05-11 20:10 ` Lucas De Marchi
2013-05-13 14:16 ` Oleg Nesterov
2013-05-13 14:35 ` [RFC] teach argv_split() to ignore the spaces surrounded by \e Oleg Nesterov
2013-05-13 16:06 ` Colin Walters
2013-05-13 17:13 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513135947.GA1613@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.