From: Oleg Nesterov <oleg@redhat.com>
To: Colin Walters <walters@verbum.org>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Andi Kleen <andi@firstfloor.org>,
Neil Horman <nhorman@tuxdriver.com>,
Lennart Poettering <mzxreary@0pointer.de>,
Denys Vlasenko <vda.linux@googlemail.com>
Subject: Re: [RFC] teach argv_split() to ignore the spaces surrounded by \e
Date: Mon, 13 May 2013 19:13:29 +0200 [thread overview]
Message-ID: <20130513171329.GA21906@redhat.com> (raw)
In-Reply-To: <1368461167.11935.39.camel@localhost>
On 05/13, Colin Walters wrote:
>
> On Mon, 2013-05-13 at 16:35 +0200, Oleg Nesterov wrote:
>
> > Yes, we can change format_corename() to construct "argv" by hand, and
> > this was my iniital plan. But perhaps it would be better to not uglify
> > this code even more?
>
> Sure this \e is less code, but it seems pretty ugly to me.
Yes, I am not proud of this idea. But it is simple.
> Maybe a way
> to keep fs/coredump.c sane would be always constructing an argv, and
> then in the !ispipe case just join them into one string.
I don't think we should construct an argv if !ispipe, but this is minor.
The patch should be simple anyway. Just I do not want to touch this code ;)
and to complicate it more. and create another (2nd) case when when we need
to construct argv by hand.
> Though I'm still inclined to change systemd to read /proc/pid/cmdline
> like abrt does; that way it works on current kernels too.
Oh, I will be really happy to leave this this code alone and do nothing ;)
except format_corename() has another bug, it can leak ->corename but this
is another story (I'll send the patch).
Oleg.
prev parent reply other threads:[~2013-05-13 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 4:15 [PATCH 1/3] argv_split(): Allow extra params Lucas De Marchi
2013-05-10 4:15 ` [PATCH 2/3] kmod: Use argv_split(), passing module as extra param Lucas De Marchi
2013-05-10 4:15 ` [PATCH 3/3] init/Kconfig: Add option to set modprobe command Lucas De Marchi
2013-05-10 12:58 ` Oleg Nesterov
2013-05-10 13:12 ` Oleg Nesterov
2013-05-10 13:15 ` Lucas De Marchi
2013-05-10 15:36 ` Oleg Nesterov
2013-05-10 16:03 ` Lucas De Marchi
2013-05-10 17:10 ` Oleg Nesterov
2013-05-10 17:35 ` Oleg Nesterov
2013-05-10 17:44 ` Lucas De Marchi
2013-05-13 13:59 ` Oleg Nesterov
2013-05-11 20:10 ` Lucas De Marchi
2013-05-13 14:16 ` Oleg Nesterov
2013-05-13 14:35 ` [RFC] teach argv_split() to ignore the spaces surrounded by \e Oleg Nesterov
2013-05-13 16:06 ` Colin Walters
2013-05-13 17:13 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513171329.GA21906@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mzxreary@0pointer.de \
--cc=nhorman@tuxdriver.com \
--cc=rusty@rustcorp.com.au \
--cc=vda.linux@googlemail.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.