From: "Bruno Prémont" <bonbons@linux-vserver.org> To: "Davor Joja" <Davor.Joja@logicbricks.com> Cc: <linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org> Subject: Re: fb driver for logiCVC Date: Wed, 15 May 2013 18:41:12 +0200 [thread overview] Message-ID: <20130515184112.251bb949@neptune.home> (raw) In-Reply-To: <9D79B9A9194389468A922F618415D0A401229E7E@abc.xylon.local> Hello Davor, On Tue, 14 May 2013 "Davor Joja" wrote: > Can I get suggestion how to send driver to this list which consists of > several files and folders, as one (big) patch or as described in > "how-to" as link to some ftp or git? > My previous mail has not been replied, because of link to driver or > other issue (tested on kernel 3.8)? You should also send it to linux-fbdev (CCed) so interested people have a better chance of seeing it (and quoting previous mail below). If you have a git tree with history it might be nice. Otherwise it's easier to review if you can split the big-patch into multiple incremental parts adding some functionality each (that incremental nature would also be expected from a git tree). Your tree at https://github.com/logicbricks/linux_kernel looks weird, you seem to have imported just the subfolders of kernel tree you worked on instead of cloning e.g. v3.8 release and applying your driver on top of it. This way it's not possible to merge your tree and it's rather hard to find out what belongs to your driver or not. Bruno On Wed, 08 May 2013 "Davor Joja" wrote: > I am sending link to frame buffer driver for Xylon "logiCVC" FPGA IP > core, so I would kindly ask for driver review. > logiCVC is Configurable Video Controller developed for Xilinx FPGA > devices. > logiCVC device together with xylonfb driver is widely used in Xilinx > Targeted Referent Designs on Zynq SoC platforms (ZC702, ZC706, ZED, TED, > Xilinx customers and Xilinx university program) and on custom projects > from Xylon and Xylon customers. > > Driver implements platform and open firmware registration types. > It has built in interface with V4L2 ADV7511 HDMI transmitter driver for > handling EDID and miscellaneous clock generator SI570 driver. > I would seek an advice for above mentioned and other issues which will > get to surface in review. > > For now fb driver runs on 3.8 kernel (ARM architecture), and it was > tested in all its configurations with: > - Xylon test application > - fbdev - Frame buffer device test application > - DirectFB, > - QT > - Ubuntu 10.04 (16bpp and 32bpp color depth) Driver build was tested by > Open Source Technology Center. > > Latest driver is available at > https://github.com/logicbricks/linux_kernel.git under > "drivers/video/xylon" and "include/linux" "Documentation (xylonfb > devicetree parameters)" > It is available on https://github.com/xilinx but not latest version. > > I have placed on ftp.logicbricks.com logiCVC datasheet, application > note, current xylonfb driver user manual and test applications. > Username: xylonfb > Password: xylonfb
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Davor Joja <Davor.Joja@logicbricks.com> Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: fb driver for logiCVC Date: Wed, 15 May 2013 16:41:12 +0000 [thread overview] Message-ID: <20130515184112.251bb949@neptune.home> (raw) In-Reply-To: <9D79B9A9194389468A922F618415D0A401229E7E@abc.xylon.local> Hello Davor, On Tue, 14 May 2013 "Davor Joja" wrote: > Can I get suggestion how to send driver to this list which consists of > several files and folders, as one (big) patch or as described in > "how-to" as link to some ftp or git? > My previous mail has not been replied, because of link to driver or > other issue (tested on kernel 3.8)? You should also send it to linux-fbdev (CCed) so interested people have a better chance of seeing it (and quoting previous mail below). If you have a git tree with history it might be nice. Otherwise it's easier to review if you can split the big-patch into multiple incremental parts adding some functionality each (that incremental nature would also be expected from a git tree). Your tree at https://github.com/logicbricks/linux_kernel looks weird, you seem to have imported just the subfolders of kernel tree you worked on instead of cloning e.g. v3.8 release and applying your driver on top of it. This way it's not possible to merge your tree and it's rather hard to find out what belongs to your driver or not. Bruno On Wed, 08 May 2013 "Davor Joja" wrote: > I am sending link to frame buffer driver for Xylon "logiCVC" FPGA IP > core, so I would kindly ask for driver review. > logiCVC is Configurable Video Controller developed for Xilinx FPGA > devices. > logiCVC device together with xylonfb driver is widely used in Xilinx > Targeted Referent Designs on Zynq SoC platforms (ZC702, ZC706, ZED, TED, > Xilinx customers and Xilinx university program) and on custom projects > from Xylon and Xylon customers. > > Driver implements platform and open firmware registration types. > It has built in interface with V4L2 ADV7511 HDMI transmitter driver for > handling EDID and miscellaneous clock generator SI570 driver. > I would seek an advice for above mentioned and other issues which will > get to surface in review. > > For now fb driver runs on 3.8 kernel (ARM architecture), and it was > tested in all its configurations with: > - Xylon test application > - fbdev - Frame buffer device test application > - DirectFB, > - QT > - Ubuntu 10.04 (16bpp and 32bpp color depth) Driver build was tested by > Open Source Technology Center. > > Latest driver is available at > https://github.com/logicbricks/linux_kernel.git under > "drivers/video/xylon" and "include/linux" "Documentation (xylonfb > devicetree parameters)" > It is available on https://github.com/xilinx but not latest version. > > I have placed on ftp.logicbricks.com logiCVC datasheet, application > note, current xylonfb driver user manual and test applications. > Username: xylonfb > Password: xylonfb
next prev parent reply other threads:[~2013-05-15 16:41 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-14 9:54 fb driver for logiCVC Davor Joja 2013-05-15 16:41 ` Bruno Prémont [this message] 2013-05-15 16:41 ` Bruno Prémont 2013-05-16 10:35 ` Davor Joja 2013-05-16 10:35 ` Davor Joja 2013-05-16 11:23 ` Geert Uytterhoeven 2013-05-16 11:23 ` Geert Uytterhoeven 2013-05-16 11:51 ` Davor Joja 2013-05-16 11:51 ` Davor Joja -- strict thread matches above, loose matches on Subject: below -- 2013-05-08 17:36 Davor Joja
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130515184112.251bb949@neptune.home \ --to=bonbons@linux-vserver.org \ --cc=Davor.Joja@logicbricks.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.