All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Jon Hunter <jon-hunter@ti.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression
Date: Thu, 16 May 2013 11:09:34 -0700	[thread overview]
Message-ID: <20130516180933.GG5600@atomide.com> (raw)
In-Reply-To: <20130513205302.GA3157@blackmetal.musicnaut.iki.fi>

* Aaro Koskinen <aaro.koskinen@iki.fi> [130513 13:58]:
> Hi,
> 
> I tested 3.10-rc1 on OMAP1 / Nokia 770, and Retu MFD probe is broken:
> 
> [    2.264221] retu-mfd 2-0001: Retu v3.2 found
> [    2.281951] retu-mfd 2-0001: Failed to allocate IRQs: -12
> [    2.300140] retu-mfd: probe of 2-0001 failed with error -12
> 
> The error is coming from regmap code. According to git bisect, it is
> caused by:
> 
> 	commit ede4d7a5b9835510fd1f724367f68d2fa4128453
> 	Author: Jon Hunter <jon-hunter@ti.com>
> 	Date:   Fri Mar 1 11:22:47 2013 -0600
> 
> 	    gpio/omap: convert gpio irq domain to linear mapping
> 
> The commit does not anymore revert cleanly, and I haven't yet tried
> crafting a manual revert, so any fix proposals/ideas are welcome...

Hmm this might be a bit trickier to fix. Obviously the real solution
is to convert omap1 to SPARSE_IRQ like we did for omap2+.

For the -rc cycle, it might be possible to fix this by adding a
different irq_to_gpio() and gpio_to_irq() functions for omap1.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression
Date: Thu, 16 May 2013 11:09:34 -0700	[thread overview]
Message-ID: <20130516180933.GG5600@atomide.com> (raw)
In-Reply-To: <20130513205302.GA3157@blackmetal.musicnaut.iki.fi>

* Aaro Koskinen <aaro.koskinen@iki.fi> [130513 13:58]:
> Hi,
> 
> I tested 3.10-rc1 on OMAP1 / Nokia 770, and Retu MFD probe is broken:
> 
> [    2.264221] retu-mfd 2-0001: Retu v3.2 found
> [    2.281951] retu-mfd 2-0001: Failed to allocate IRQs: -12
> [    2.300140] retu-mfd: probe of 2-0001 failed with error -12
> 
> The error is coming from regmap code. According to git bisect, it is
> caused by:
> 
> 	commit ede4d7a5b9835510fd1f724367f68d2fa4128453
> 	Author: Jon Hunter <jon-hunter@ti.com>
> 	Date:   Fri Mar 1 11:22:47 2013 -0600
> 
> 	    gpio/omap: convert gpio irq domain to linear mapping
> 
> The commit does not anymore revert cleanly, and I haven't yet tried
> crafting a manual revert, so any fix proposals/ideas are welcome...

Hmm this might be a bit trickier to fix. Obviously the real solution
is to convert omap1 to SPARSE_IRQ like we did for omap2+.

For the -rc cycle, it might be possible to fix this by adding a
different irq_to_gpio() and gpio_to_irq() functions for omap1.

Regards,

Tony

  reply	other threads:[~2013-05-16 18:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 20:53 [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression Aaro Koskinen
2013-05-13 20:53 ` Aaro Koskinen
2013-05-16 18:09 ` Tony Lindgren [this message]
2013-05-16 18:09   ` Tony Lindgren
2013-05-16 21:00   ` Aaro Koskinen
2013-05-16 21:00     ` Aaro Koskinen
2013-05-16 21:44     ` Tony Lindgren
2013-05-16 21:44       ` Tony Lindgren
2013-05-20 17:46       ` Tony Lindgren
2013-05-20 17:46         ` Tony Lindgren
2013-05-21 17:39         ` Aaro Koskinen
2013-05-21 17:39           ` Aaro Koskinen
2013-05-21 19:37           ` Jon Hunter
2013-05-21 19:37             ` Jon Hunter
2013-05-22 21:20             ` Aaro Koskinen
2013-05-22 21:20               ` Aaro Koskinen
2013-05-23 19:02               ` Jon Hunter
2013-05-23 19:02                 ` Jon Hunter
2013-05-23 20:13                 ` Aaro Koskinen
2013-05-23 20:13                   ` Aaro Koskinen
2013-05-28 18:41                   ` Jon Hunter
2013-05-28 18:41                     ` Jon Hunter
2013-05-26 19:07                 ` Aaro Koskinen
2013-05-26 19:07                   ` Aaro Koskinen
2013-05-28 18:42                   ` Jon Hunter
2013-05-28 18:42                     ` Jon Hunter
2013-05-29 18:55                     ` Aaro Koskinen
2013-05-29 18:55                       ` Aaro Koskinen
2013-05-29 21:29                       ` Jon Hunter
2013-05-29 21:29                         ` Jon Hunter
2013-05-29 22:41                         ` Jon Hunter
2013-05-29 22:41                           ` Jon Hunter
2013-06-05 22:33         ` Grant Likely
2013-06-05 22:33           ` Grant Likely
2013-06-06 15:53           ` Tony Lindgren
2013-06-06 15:53             ` Tony Lindgren
2013-06-23 22:16             ` Aaro Koskinen
2013-06-23 22:16               ` Aaro Koskinen
2013-06-23 23:06               ` Javier Martinez Canillas
2013-06-23 23:06                 ` Javier Martinez Canillas
2013-06-23 23:43                 ` Aaro Koskinen
2013-06-23 23:43                   ` Aaro Koskinen
2013-06-24  1:01                   ` Javier Martinez Canillas
2013-06-24  1:01                     ` Javier Martinez Canillas
2013-06-24  7:21                     ` Tony Lindgren
2013-06-24  7:21                       ` Tony Lindgren
2013-06-24 15:35                       ` Javier Martinez Canillas
2013-06-24 15:35                         ` Javier Martinez Canillas
2013-06-25 18:14                         ` Aaro Koskinen
2013-06-25 18:14                           ` Aaro Koskinen
2013-06-24 15:53                       ` Grant Likely
2013-06-24 15:53                         ` Grant Likely
2013-06-25  7:04                         ` Tony Lindgren
2013-06-25  7:04                           ` Tony Lindgren
2013-06-25 11:49                           ` Grant Likely
2013-06-25 11:49                             ` Grant Likely
2013-06-26  7:06                             ` Tony Lindgren
2013-06-26  7:06                               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516180933.GG5600@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=grant.likely@secretlab.ca \
    --cc=jon-hunter@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.