All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c-i801: Document feature bits in modinfo
@ 2013-05-15 12:44 Jean Delvare
       [not found] ` <20130515144410.161c9065-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2013-05-15 12:44 UTC (permalink / raw)
  To: Linux I2C, Wolfram Sang; +Cc: Robert Norris

Duplicate the feature bits documentation in modinfo, as not every user
will read the driver's source code or documentation file.

Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
 drivers/i2c/busses/i2c-i801.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- linux-3.10-rc1.orig/drivers/i2c/busses/i2c-i801.c	2013-04-29 02:36:01.000000000 +0200
+++ linux-3.10-rc1/drivers/i2c/busses/i2c-i801.c	2013-05-15 12:42:11.573297161 +0200
@@ -231,7 +231,11 @@ static const char *i801_feature_names[]
 
 static unsigned int disable_features;
 module_param(disable_features, uint, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(disable_features, "Disable selected driver features");
+MODULE_PARM_DESC(disable_features, "Disable selected driver features:\n"
+	"\t\t  0x01  disable SMBus PEC\n"
+	"\t\t  0x02  disable the block buffer\n"
+	"\t\t  0x08  disable the I2C block read functionality\n"
+	"\t\t  0x10  don't use interrupts ");
 
 /* Make sure the SMBus host is ready to start transmitting.
    Return 0 if it is, -EBUSY if it is not. */


-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] i2c-i801: Document feature bits in modinfo
       [not found] ` <20130515144410.161c9065-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
@ 2013-05-17  8:50   ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-05-17  8:50 UTC (permalink / raw)
  To: Jean Delvare; +Cc: Linux I2C, Robert Norris

On Wed, May 15, 2013 at 02:44:10PM +0200, Jean Delvare wrote:
> Duplicate the feature bits documentation in modinfo, as not every user
> will read the driver's source code or documentation file.
> 
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

Applied to for-current, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-17  8:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-15 12:44 [PATCH] i2c-i801: Document feature bits in modinfo Jean Delvare
     [not found] ` <20130515144410.161c9065-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-05-17  8:50   ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.