[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Thomas Petazzoni]

Besides the two "classic" USB interfaces with normal USB ports on the
front side, the PlatHome OpenBlocks AX3 uses the third USB interface
of the Marvell SoC in the mini-PCIe connector. This allows certain
mini-PCIe cards to expose parts of their functionality as a USB
peripheral.

This commit enables this third USB interface in the OpenBlocks AX3
Device Tree, and also adds comments on top of the two other USB
interfaces so that the Device Tree makes it clear which USB interface
at the SoC level matches which USB interface visible on the board.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
index f14d36c..60a79e7 100644
--- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
+++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
@@ -134,13 +134,22 @@
 				nr-ports = <2>;
 				status = "okay";
 			};
+
+			/* Front side USB 0 */
 			usb at 50000 {
 				status = "okay";
 			};
+
+			/* Front side USB 1 */
 			usb at 51000 {
 				status = "okay";
 			};
 
+			/* USB interface in the mini-PCIe connector */
+			usb at 52000 {
+				status = "okay";
+			};
+
 			devbus-bootcs at 10400 {
 				status = "okay";
 				ranges = <0 0xf0000000 0x8000000>; /* @addr 0xf000000, size 0x8000000 */
-- 
1.7.9.5

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[yamagata at plathome.co.jp]

Dear Mr. Petazzoni

> Besides the two "classic" USB interfaces with normal USB ports on the
> front side, the PlatHome OpenBlocks AX3 uses the third USB interface
> of the Marvell SoC in the mini-PCIe connector. This allows certain
> mini-PCIe cards to expose parts of their functionality as a USB
> peripheral.
> 
> This commit enables this third USB interface in the OpenBlocks AX3
> Device Tree, and also adds comments on top of the two other USB
> interfaces so that the Device Tree makes it clear which USB interface
> at the SoC level matches which USB interface visible on the board.

I see the following messages by dmesg with your patch for
linux-3.10-rc1 and 3.9.2.

...
usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c
usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
usb 3-1: Manufacturer: Broadcom Corp
usb 3-1: SerialNumber: B4749F63C1B6
...
Bluetooth: Core ver 2.16
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP socket layer initialized
Bluetooth: SCO socket layer initialized
usbcore: registered new interface driver btusb
...

Best regards

Atsushi Yamagata
--- Atsushi Yamagata

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Gregory CLEMENT]

Hi Thomas,
On 05/17/2013 04:18 AM, yamagata at plathome.co.jp wrote:
> Dear Mr. Petazzoni
> 
>> Besides the two "classic" USB interfaces with normal USB ports on the
>> front side, the PlatHome OpenBlocks AX3 uses the third USB interface
>> of the Marvell SoC in the mini-PCIe connector. This allows certain
>> mini-PCIe cards to expose parts of their functionality as a USB
>> peripheral.
>>
>> This commit enables this third USB interface in the OpenBlocks AX3
>> Device Tree, and also adds comments on top of the two other USB
>> interfaces so that the Device Tree makes it clear which USB interface
>> at the SoC level matches which USB interface visible on the board.
> 
> I see the following messages by dmesg with your patch for
> linux-3.10-rc1 and 3.9.2.
> 
> ...
> usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c
> usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
> usb 3-1: Manufacturer: Broadcom Corp
> usb 3-1: SerialNumber: B4749F63C1B6
> ...
> Bluetooth: Core ver 2.16
> NET: Registered protocol family 31
> Bluetooth: HCI device and connection manager initialized
> Bluetooth: HCI socket layer initialized
> Bluetooth: L2CAP socket layer initialized
> Bluetooth: SCO socket layer initialized
> usbcore: registered new interface driver btusb

This patch is nice and adds useful information.

I applied and tested on my OpenBlocks AX3 and get the 3rd USB
interface detected. As I don't have any mini-PCIe card which use USB,
I didn't tested it furthermore, but as Atsushi Yamagata managed to
detect an USB device on this interface, we can be pretty confident
with this patch:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Willy Tarreau]

Hi Gregory,

On Fri, May 17, 2013 at 03:47:37PM +0200, Gregory CLEMENT wrote:
> I applied and tested on my OpenBlocks AX3 and get the 3rd USB
> interface detected. As I don't have any mini-PCIe card which use USB,
> I didn't tested it furthermore, but as Atsushi Yamagata managed to
> detect an USB device on this interface, we can be pretty confident
> with this patch:

I do have a mini-PCIe to PCIe+USB adapter [1]. I have plugged it
with a USB flash and it was correctly detected as well after I
applied the patch :

usb 3-1: new high-speed USB device number 2 using orion-ehci
usb 3-1: New USB device found, idVendor=0781, idProduct=5567
usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-1: Product: Cruzer Blade
usb 3-1: Manufacturer: SanDisk

Best regards,
Willy

[1] : http://www.hwtools.net/Adapter/PM2.html

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Jason Cooper]

Mr Yamagata, Willy,

I don't like to assume for people, so if you could please provided a
"Tested-by:" I'd appreciate it.

thx,

Jason.

On Fri, May 17, 2013 at 11:18:10AM +0900, yamagata at plathome.co.jp wrote:
> Dear Mr. Petazzoni
> 
> > Besides the two "classic" USB interfaces with normal USB ports on the
> > front side, the PlatHome OpenBlocks AX3 uses the third USB interface
> > of the Marvell SoC in the mini-PCIe connector. This allows certain
> > mini-PCIe cards to expose parts of their functionality as a USB
> > peripheral.
> > 
> > This commit enables this third USB interface in the OpenBlocks AX3
> > Device Tree, and also adds comments on top of the two other USB
> > interfaces so that the Device Tree makes it clear which USB interface
> > at the SoC level matches which USB interface visible on the board.
> 
> I see the following messages by dmesg with your patch for
> linux-3.10-rc1 and 3.9.2.
> 
> ...
> usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c
> usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
> usb 3-1: Manufacturer: Broadcom Corp
> usb 3-1: SerialNumber: B4749F63C1B6
> ...
> Bluetooth: Core ver 2.16
> NET: Registered protocol family 31
> Bluetooth: HCI device and connection manager initialized
> Bluetooth: HCI socket layer initialized
> Bluetooth: L2CAP socket layer initialized
> Bluetooth: SCO socket layer initialized
> usbcore: registered new interface driver btusb
> ...
> 
> Best regards
> 
> Atsushi Yamagata
> --- Atsushi Yamagata
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Willy Tarreau]

On Sun, May 19, 2013 at 04:19:39PM -0400, Jason Cooper wrote:
> Mr Yamagata, Willy,
> 
> I don't like to assume for people, so if you could please provided a
> "Tested-by:" I'd appreciate it.

Yes of course, I didn't propose it in order to save you the work of
collecting these tags :-)

  Tested-by: Willy Tarreau <w@1wt.eu>

Best regards,
Willy

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[yamagata at plathome.co.jp]

Dear Mr. Jason Cooper

> I don't like to assume for people, so if you could please provided a
> "Tested-by:" I'd appreciate it.

Tested-by: Atsushi Yamagata <yamagata@plathome.co.jp>

Best regards

Atsushi Yamagata
--- Atsushi Yamagata

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Jason Cooper]

On Sun, May 19, 2013 at 11:30:40PM +0200, Willy Tarreau wrote:
> On Sun, May 19, 2013 at 04:19:39PM -0400, Jason Cooper wrote:
> > Mr Yamagata, Willy,
> > 
> > I don't like to assume for people, so if you could please provided a
> > "Tested-by:" I'd appreciate it.
> 
> Yes of course, I didn't propose it in order to save you the work of
> collecting these tags :-)
> 
>   Tested-by: Willy Tarreau <w@1wt.eu>

Thanks!

Jason.

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Jason Cooper]

On Mon, May 20, 2013 at 02:50:44PM +0900, yamagata at plathome.co.jp wrote:
> Dear Mr. Jason Cooper
> 
> > I don't like to assume for people, so if you could please provided a
> > "Tested-by:" I'd appreciate it.
> 
> Tested-by: Atsushi Yamagata <yamagata@plathome.co.jp>

Thanks!

Jason.

[PATCH] arm: mvebu: enable the third USB interface on OpenBlocks AX3

[Jason Cooper]

On Thu, May 16, 2013 at 06:07:24PM +0200, Thomas Petazzoni wrote:
> Besides the two "classic" USB interfaces with normal USB ports on the
> front side, the PlatHome OpenBlocks AX3 uses the third USB interface
> of the Marvell SoC in the mini-PCIe connector. This allows certain
> mini-PCIe cards to expose parts of their functionality as a USB
> peripheral.
> 
> This commit enables this third USB interface in the OpenBlocks AX3
> Device Tree, and also adds comments on top of the two other USB
> interfaces so that the Device Tree makes it clear which USB interface
> at the SoC level matches which USB interface visible on the board.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
>  1 file changed, 9 insertions(+)

Applied to mvebu/dt with Willy's and Mr. Yamagata's Tested-by's

thx,

Jason.