* [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-04-29 15:45 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-04-29 15:45 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg; +Cc: linux-bluetooth, linux-kernel, shuahkhan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1001 bytes --]
Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
following message after power management device test. This change sets
reset_resume to btusb_resume().
[ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
[ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 2cc5f77..11d72de 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1230,6 +1230,7 @@ static struct usb_driver btusb_driver = {
#ifdef CONFIG_PM
.suspend = btusb_suspend,
.resume = btusb_resume,
+ .reset_resume = btusb_resume,
#endif
.id_table = btusb_table,
.supports_autosuspend = 1,
--
1.7.10.4
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-04-29 15:45 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-04-29 15:45 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg; +Cc: linux-bluetooth, linux-kernel, shuahkhan
QWRkIG1pc3NpbmcgcmVzZXRfcmVzdW1lIGRldl9wbV9vcHMuIE1pc3NpbmcgcmVzZXRfcmVzdW1l
IHJlc3VsdHMgaW4gdGhlDQpmb2xsb3dpbmcgbWVzc2FnZSBhZnRlciBwb3dlciBtYW5hZ2VtZW50
IGRldmljZSB0ZXN0LiBUaGlzIGNoYW5nZSBzZXRzDQpyZXNldF9yZXN1bWUgdG8gYnR1c2JfcmVz
dW1lKCkuDQoNClsgMjUwNi45MzYxMzRdIGJ0dXNiIDEtMS41OjEuMDogbm8gcmVzZXRfcmVzdW1l
IGZvciBkcml2ZXIgYnR1c2I/DQpbIDI1MDYuOTM2MTM3XSBidHVzYiAxLTEuNToxLjE6IG5vIHJl
c2V0X3Jlc3VtZSBmb3IgZHJpdmVyIGJ0dXNiPw0KDQpTaWduZWQtb2ZmLWJ5OiBTaHVhaCBLaGFu
IDxzaHVhaC5raEBzYW1zdW5nLmNvbT4NCi0tLQ0KIGRyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMg
fCAgICAxICsNCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBh
L2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMgYi9kcml2ZXJzL2JsdWV0b290aC9idHVzYi5jDQpp
bmRleCAyY2M1Zjc3Li4xMWQ3MmRlIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9ibHVldG9vdGgvYnR1
c2IuYw0KKysrIGIvZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYw0KQEAgLTEyMzAsNiArMTIzMCw3
IEBAIHN0YXRpYyBzdHJ1Y3QgdXNiX2RyaXZlciBidHVzYl9kcml2ZXIgPSB7DQogI2lmZGVmIENP
TkZJR19QTQ0KIAkuc3VzcGVuZAk9IGJ0dXNiX3N1c3BlbmQsDQogCS5yZXN1bWUJCT0gYnR1c2Jf
cmVzdW1lLA0KKwkucmVzZXRfcmVzdW1lCT0gYnR1c2JfcmVzdW1lLA0KICNlbmRpZg0KIAkuaWRf
dGFibGUJPSBidHVzYl90YWJsZSwNCiAJLnN1cHBvcnRzX2F1dG9zdXNwZW5kID0gMSwNCi0tIA0K
MS43LjEwLjQNCg0KDQo=
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops
2013-04-29 15:45 ` Shuah Khan
(?)
@ 2013-05-20 23:08 ` Gustavo Padovan
2013-05-20 23:34 ` Shuah Khan
-1 siblings, 1 reply; 12+ messages in thread
From: Gustavo Padovan @ 2013-05-20 23:08 UTC (permalink / raw)
To: Shuah Khan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
Hi Shuah,
* Shuah Khan <shuah.kh@samsung.com> [2013-04-29 15:45:34 +0000]:
> Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> following message after power management device test. This change sets
> reset_resume to btusb_resume().
>
> [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
This patch needs rebase on latest bluetooth-next. It doesn't apply anymore.
Please re-send it.
Gustavo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops
2013-05-20 23:08 ` Gustavo Padovan
@ 2013-05-20 23:34 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-20 23:34 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1102 bytes --]
On Mon, 2013-05-20 at 20:08 -0300, Gustavo Padovan wrote:
> Hi Shuah,
>
> * Shuah Khan <shuah.kh@samsung.com> [2013-04-29 15:45:34 +0000]:
>
> > Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> > following message after power management device test. This change sets
> > reset_resume to btusb_resume().
> >
> > [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> > [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
> >
> > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > ---
> > drivers/bluetooth/btusb.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> This patch needs rebase on latest bluetooth-next. It doesn't apply anymore.
> Please re-send it.
>
> Gustavo
Hi Gustavo,
Yes. I will rebase and resend it you shortly.
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group
Samsung Research America (Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-05-20 23:34 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-20 23:34 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
T24gTW9uLCAyMDEzLTA1LTIwIGF0IDIwOjA4IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6
DQo+IEhpIFNodWFoLA0KPiANCj4gKiBTaHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4g
WzIwMTMtMDQtMjkgMTU6NDU6MzQgKzAwMDBdOg0KPiANCj4gPiBBZGQgbWlzc2luZyByZXNldF9y
ZXN1bWUgZGV2X3BtX29wcy4gTWlzc2luZyByZXNldF9yZXN1bWUgcmVzdWx0cyBpbiB0aGUNCj4g
PiBmb2xsb3dpbmcgbWVzc2FnZSBhZnRlciBwb3dlciBtYW5hZ2VtZW50IGRldmljZSB0ZXN0LiBU
aGlzIGNoYW5nZSBzZXRzDQo+ID4gcmVzZXRfcmVzdW1lIHRvIGJ0dXNiX3Jlc3VtZSgpLg0KPiA+
IA0KPiA+IFsgMjUwNi45MzYxMzRdIGJ0dXNiIDEtMS41OjEuMDogbm8gcmVzZXRfcmVzdW1lIGZv
ciBkcml2ZXIgYnR1c2I/DQo+ID4gWyAyNTA2LjkzNjEzN10gYnR1c2IgMS0xLjU6MS4xOiBubyBy
ZXNldF9yZXN1bWUgZm9yIGRyaXZlciBidHVzYj8NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBT
aHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9i
bHVldG9vdGgvYnR1c2IuYyB8ICAgIDEgKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKykNCj4gDQo+IFRoaXMgcGF0Y2ggbmVlZHMgcmViYXNlIG9uIGxhdGVzdCBibHVldG9vdGgt
bmV4dC4gSXQgZG9lc24ndCBhcHBseSBhbnltb3JlLg0KPiBQbGVhc2UgcmUtc2VuZCBpdC4NCj4g
DQo+IAlHdXN0YXZvDQoNCkhpIEd1c3Rhdm8sDQoNClllcy4gSSB3aWxsIHJlYmFzZSBhbmQgcmVz
ZW5kIGl0IHlvdSBzaG9ydGx5Lg0KDQotLSBTaHVhaA0KDQpTaHVhaCBLaGFuLCBMaW51eCBLZXJu
ZWwgRGV2ZWxvcGVyIC0gT3BlbiBTb3VyY2UgR3JvdXAgDQpTYW1zdW5nIFJlc2VhcmNoIEFtZXJp
Y2EgKFNpbGljb24gVmFsbGV5KQ0Kc2h1YWgua2hAc2Ftc3VuZy5jb20gfCAoOTcwKSA2NzItMDY1
OA0KDQo=
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
2013-05-20 23:34 ` Shuah Khan
@ 2013-05-21 1:02 ` Shuah Khan
-1 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-21 1:02 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan,
Shuah Khan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1001 bytes --]
Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
following message after power management device test. This change sets
reset_resume to btusb_resume().
[ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
[ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a7e5f8..1eb90c0 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
#ifdef CONFIG_PM
.suspend = btusb_suspend,
.resume = btusb_resume,
+ .reset_resume = btusb_resume,
#endif
.id_table = btusb_table,
.supports_autosuspend = 1,
--
1.7.10.4
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-05-21 1:02 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-21 1:02 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan,
Shuah Khan
QWRkIG1pc3NpbmcgcmVzZXRfcmVzdW1lIGRldl9wbV9vcHMuIE1pc3NpbmcgcmVzZXRfcmVzdW1l
IHJlc3VsdHMgaW4gdGhlDQpmb2xsb3dpbmcgbWVzc2FnZSBhZnRlciBwb3dlciBtYW5hZ2VtZW50
IGRldmljZSB0ZXN0LiBUaGlzIGNoYW5nZSBzZXRzDQpyZXNldF9yZXN1bWUgdG8gYnR1c2JfcmVz
dW1lKCkuDQoNClsgMjUwNi45MzYxMzRdIGJ0dXNiIDEtMS41OjEuMDogbm8gcmVzZXRfcmVzdW1l
IGZvciBkcml2ZXIgYnR1c2I/DQpbIDI1MDYuOTM2MTM3XSBidHVzYiAxLTEuNToxLjE6IG5vIHJl
c2V0X3Jlc3VtZSBmb3IgZHJpdmVyIGJ0dXNiPw0KDQpTaWduZWQtb2ZmLWJ5OiBTaHVhaCBLaGFu
IDxzaHVhaC5raEBzYW1zdW5nLmNvbT4NCi0tLQ0KIGRyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMg
fCAgICAxICsNCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBh
L2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMgYi9kcml2ZXJzL2JsdWV0b290aC9idHVzYi5jDQpp
bmRleCA3YTdlNWY4Li4xZWI5MGMwIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9ibHVldG9vdGgvYnR1
c2IuYw0KKysrIGIvZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYw0KQEAgLTE2MTYsNiArMTYxNiw3
IEBAIHN0YXRpYyBzdHJ1Y3QgdXNiX2RyaXZlciBidHVzYl9kcml2ZXIgPSB7DQogI2lmZGVmIENP
TkZJR19QTQ0KIAkuc3VzcGVuZAk9IGJ0dXNiX3N1c3BlbmQsDQogCS5yZXN1bWUJCT0gYnR1c2Jf
cmVzdW1lLA0KKwkucmVzZXRfcmVzdW1lCT0gYnR1c2JfcmVzdW1lLA0KICNlbmRpZg0KIAkuaWRf
dGFibGUJPSBidHVzYl90YWJsZSwNCiAJLnN1cHBvcnRzX2F1dG9zdXNwZW5kID0gMSwNCi0tIA0K
MS43LjEwLjQNCg0KDQo=
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
2013-05-21 1:02 ` Shuah Khan
(?)
@ 2013-05-21 3:28 ` Gustavo Padovan
2013-05-21 15:32 ` Shuah Khan
-1 siblings, 1 reply; 12+ messages in thread
From: Gustavo Padovan @ 2013-05-21 3:28 UTC (permalink / raw)
To: Shuah Khan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
Hi Shuan,
* Shuah Khan <shuah.kh@samsung.com> [2013-05-21 01:02:58 +0000]:
> Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> following message after power management device test. This change sets
> reset_resume to btusb_resume().
>
> [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 7a7e5f8..1eb90c0 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
> #ifdef CONFIG_PM
> .suspend = btusb_suspend,
> .resume = btusb_resume,
> + .reset_resume = btusb_resume,
> #endif
> .id_table = btusb_table,
> .supports_autosuspend = 1,
Patch still doesn't apply, are you sending it with git-send-email?
Applying: Bluetooth: Add missing reset_resume dev_pm_ops
/home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:13: trailing whitespace.
.reset_resume = btusb_resume,
error: patch failed: drivers/bluetooth/btusb.c:1616
error: drivers/bluetooth/btusb.c: patch does not apply
Patch failed at 0001 Bluetooth: Add missing reset_resume dev_pm_ops
Gustavo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
2013-05-21 3:28 ` Gustavo Padovan
@ 2013-05-21 15:32 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-21 15:32 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2024 bytes --]
On Tue, 2013-05-21 at 00:28 -0300, Gustavo Padovan wrote:
> Hi Shuan,
>
> * Shuah Khan <shuah.kh@samsung.com> [2013-05-21 01:02:58 +0000]:
>
> > Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> > following message after power management device test. This change sets
> > reset_resume to btusb_resume().
> >
> > [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> > [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
> >
> > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > ---
> > drivers/bluetooth/btusb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 7a7e5f8..1eb90c0 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
> > #ifdef CONFIG_PM
> > .suspend = btusb_suspend,
> > .resume = btusb_resume,
> > + .reset_resume = btusb_resume,
> > #endif
> > .id_table = btusb_table,
> > .supports_autosuspend = 1,
>
> Patch still doesn't apply, are you sending it with git-send-email?
>
> Applying: Bluetooth: Add missing reset_resume dev_pm_ops
> /home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:13: trailing whitespace.
> .reset_resume = btusb_resume,
> error: patch failed: drivers/bluetooth/btusb.c:1616
> error: drivers/bluetooth/btusb.c: patch does not apply
> Patch failed at 0001 Bluetooth: Add missing reset_resume dev_pm_ops
>
> Gustavo
I saved the patch from the email I sent and applied to your latest git
and it applies. I am not sure what happened. In any case, I just resent
it using git-send-email. Hope that works.
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group
Samsung Research America (Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-05-21 15:32 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2013-05-21 15:32 UTC (permalink / raw)
To: Gustavo Padovan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
T24gVHVlLCAyMDEzLTA1LTIxIGF0IDAwOjI4IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6
DQo+IEhpIFNodWFuLA0KPiANCj4gKiBTaHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4g
WzIwMTMtMDUtMjEgMDE6MDI6NTggKzAwMDBdOg0KPiANCj4gPiBBZGQgbWlzc2luZyByZXNldF9y
ZXN1bWUgZGV2X3BtX29wcy4gTWlzc2luZyByZXNldF9yZXN1bWUgcmVzdWx0cyBpbiB0aGUNCj4g
PiBmb2xsb3dpbmcgbWVzc2FnZSBhZnRlciBwb3dlciBtYW5hZ2VtZW50IGRldmljZSB0ZXN0LiBU
aGlzIGNoYW5nZSBzZXRzDQo+ID4gcmVzZXRfcmVzdW1lIHRvIGJ0dXNiX3Jlc3VtZSgpLg0KPiA+
IA0KPiA+IFsgMjUwNi45MzYxMzRdIGJ0dXNiIDEtMS41OjEuMDogbm8gcmVzZXRfcmVzdW1lIGZv
ciBkcml2ZXIgYnR1c2I/DQo+ID4gWyAyNTA2LjkzNjEzN10gYnR1c2IgMS0xLjU6MS4xOiBubyBy
ZXNldF9yZXN1bWUgZm9yIGRyaXZlciBidHVzYj8NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBT
aHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9i
bHVldG9vdGgvYnR1c2IuYyB8ICAgIDEgKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYyBi
L2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMNCj4gPiBpbmRleCA3YTdlNWY4Li4xZWI5MGMwIDEw
MDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMNCj4gPiArKysgYi9kcml2
ZXJzL2JsdWV0b290aC9idHVzYi5jDQo+ID4gQEAgLTE2MTYsNiArMTYxNiw3IEBAIHN0YXRpYyBz
dHJ1Y3QgdXNiX2RyaXZlciBidHVzYl9kcml2ZXIgPSB7DQo+ID4gICNpZmRlZiBDT05GSUdfUE0N
Cj4gPiAgCS5zdXNwZW5kCT0gYnR1c2Jfc3VzcGVuZCwNCj4gPiAgCS5yZXN1bWUJCT0gYnR1c2Jf
cmVzdW1lLA0KPiA+ICsJLnJlc2V0X3Jlc3VtZQk9IGJ0dXNiX3Jlc3VtZSwNCj4gPiAgI2VuZGlm
DQo+ID4gIAkuaWRfdGFibGUJPSBidHVzYl90YWJsZSwNCj4gPiAgCS5zdXBwb3J0c19hdXRvc3Vz
cGVuZCA9IDEsDQo+IA0KPiBQYXRjaCBzdGlsbCBkb2Vzbid0IGFwcGx5LCBhcmUgeW91IHNlbmRp
bmcgaXQgd2l0aCBnaXQtc2VuZC1lbWFpbD8NCj4gDQo+IEFwcGx5aW5nOiBCbHVldG9vdGg6IEFk
ZCBtaXNzaW5nIHJlc2V0X3Jlc3VtZSBkZXZfcG1fb3BzDQo+IC9ob21lL3BhZG92YW4vcC9saW51
eC10cmVlcy9ibHVldG9vdGgtbmV4dC8uZ2l0L3JlYmFzZS1hcHBseS9wYXRjaDoxMzogdHJhaWxp
bmcgd2hpdGVzcGFjZS4NCj4gICAgICAgICAucmVzZXRfcmVzdW1lICAgPSBidHVzYl9yZXN1bWUs
DQo+IGVycm9yOiBwYXRjaCBmYWlsZWQ6IGRyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmM6MTYxNg0K
PiBlcnJvcjogZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYzogcGF0Y2ggZG9lcyBub3QgYXBwbHkN
Cj4gUGF0Y2ggZmFpbGVkIGF0IDAwMDEgQmx1ZXRvb3RoOiBBZGQgbWlzc2luZyByZXNldF9yZXN1
bWUgZGV2X3BtX29wcw0KPiANCj4gCUd1c3Rhdm8NCg0KSSBzYXZlZCB0aGUgcGF0Y2ggZnJvbSB0
aGUgZW1haWwgSSBzZW50IGFuZCBhcHBsaWVkIHRvIHlvdXIgbGF0ZXN0IGdpdA0KYW5kIGl0IGFw
cGxpZXMuIEkgYW0gbm90IHN1cmUgd2hhdCBoYXBwZW5lZC4gSW4gYW55IGNhc2UsIEkganVzdCBy
ZXNlbnQNCml0IHVzaW5nIGdpdC1zZW5kLWVtYWlsLiBIb3BlIHRoYXQgd29ya3MuDQoNCi0tIFNo
dWFoDQoNClNodWFoIEtoYW4sIExpbnV4IEtlcm5lbCBEZXZlbG9wZXIgLSBPcGVuIFNvdXJjZSBH
cm91cCANClNhbXN1bmcgUmVzZWFyY2ggQW1lcmljYSAoU2lsaWNvbiBWYWxsZXkpDQpzaHVhaC5r
aEBzYW1zdW5nLmNvbSB8ICg5NzApIDY3Mi0wNjU4DQoNCg==
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
2013-05-21 15:32 Shuah Khan
@ 2013-05-21 15:36 ` Gustavo Padovan
0 siblings, 0 replies; 12+ messages in thread
From: Gustavo Padovan @ 2013-05-21 15:36 UTC (permalink / raw)
To: Shuah Khan
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, shuahkhan
Hi Shuah,
* Shuah Khan <shuah.kh@samsung.com> [2013-05-21 09:32:06 -0600]:
> Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> following message after power management device test. This change sets
> reset_resume to btusb_resume().
>
> [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
@ 2013-05-21 15:32 Shuah Khan
2013-05-21 15:36 ` Gustavo Padovan
0 siblings, 1 reply; 12+ messages in thread
From: Shuah Khan @ 2013-05-21 15:32 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg
Cc: Shuah Khan, linux-bluetooth, linux-kernel, shuahkhan
Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
following message after power management device test. This change sets
reset_resume to btusb_resume().
[ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
[ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a7e5f8..1eb90c0 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
#ifdef CONFIG_PM
.suspend = btusb_suspend,
.resume = btusb_resume,
+ .reset_resume = btusb_resume,
#endif
.id_table = btusb_table,
.supports_autosuspend = 1,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-05-21 15:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-29 15:45 [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops Shuah Khan
2013-04-29 15:45 ` Shuah Khan
2013-05-20 23:08 ` Gustavo Padovan
2013-05-20 23:34 ` Shuah Khan
2013-05-20 23:34 ` Shuah Khan
2013-05-21 1:02 ` [PATCH rebased] " Shuah Khan
2013-05-21 1:02 ` Shuah Khan
2013-05-21 3:28 ` Gustavo Padovan
2013-05-21 15:32 ` Shuah Khan
2013-05-21 15:32 ` Shuah Khan
2013-05-21 15:32 Shuah Khan
2013-05-21 15:36 ` Gustavo Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.