All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: <wei.liu2@citrix.com>, <xen-devel@lists.xen.org>,
	<netdev@vger.kernel.org>, <ian.campbell@citrix.com>,
	<konrad.wilk@oracle.com>
Subject: Re: [PATCH net-next 0/2] Xen network: split event channels support
Date: Tue, 21 May 2013 09:00:40 +0100	[thread overview]
Message-ID: <20130521080040.GA11421@zion.uk.xensource.com> (raw)
In-Reply-To: <20130520.232752.896794972508019827.davem@davemloft.net>

On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
> 
> If you use the same exact subject line in all of your patches in the
> series, nobody reading the shortlog can tell what's different about
> them.
> 
> You absolutely must resubmit this with more descriptive subject lines
> which more accurately describe what each patch uniquely does.

I'm not sure I get what you mean. Their subject lines look alike, but
not exactly the same.

So this patch set adds a new feature to Xen network device, which is
called split event channels. The subject lines of two patches, one for
frontend and one for backend, speak for themselves.

No matter how I change the subject lines, they will probably still look
alike except for the leading "xen-netfront / xen-netback".  I can squash
them into one changeset if that better suits your workflow, but it is
better to leave them separate IMHO so that we can test them separately.

Advice welcomed.

Thanks
Wei.

  reply	other threads:[~2013-05-21  8:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 23:02 [PATCH net-next 0/2] Xen network: split event channels support Wei Liu
2013-05-20 23:02 ` [PATCH net-next 1/2] xen-netback: split event channels feature support Wei Liu
2013-05-20 23:02 ` Wei Liu
2013-05-21 13:34   ` David Vrabel
2013-05-21 13:34   ` [Xen-devel] " David Vrabel
2013-05-21 14:33     ` Wei Liu
2013-05-21 14:33     ` Wei Liu
2013-05-20 23:02 ` [PATCH net-next 2/2] xen-netfront: " Wei Liu
2013-05-20 23:02 ` Wei Liu
2013-05-21 13:39   ` [Xen-devel] " David Vrabel
2013-05-21 13:41     ` Wei Liu
2013-05-21 16:28       ` Konrad Rzeszutek Wilk
2013-05-21 16:28       ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-05-21 17:07         ` Wei Liu
2013-05-21 17:07         ` Wei Liu
2013-05-22 15:52       ` [Xen-devel] " David Vrabel
2013-05-22 15:52       ` David Vrabel
2013-05-21 13:41     ` Wei Liu
2013-05-21 13:39   ` David Vrabel
2013-05-21  6:27 ` [PATCH net-next 0/2] Xen network: split event channels support David Miller
2013-05-21  6:27 ` David Miller
2013-05-21  8:00   ` Wei Liu [this message]
2013-05-21  8:13     ` David Miller
2013-05-21  8:13     ` David Miller
2013-05-21  8:17     ` Ian Campbell
2013-05-21  8:34       ` Wei Liu
2013-05-21  8:34       ` Wei Liu
2013-05-21  8:17     ` Ian Campbell
2013-05-21  8:00   ` Wei Liu
  -- strict thread matches above, loose matches on Subject: below --
2013-05-20 23:02 Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521080040.GA11421@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=davem@davemloft.net \
    --cc=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.