Re: [PATCH net-next 2/2] xen-netfront: split event channels feature support

From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: netdev@vger.kernel.org, ian.campbell@citrix.com,
	Wei Liu <wei.liu2@citrix.com>,
	David Vrabel <david.vrabel@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH net-next 2/2] xen-netfront: split event channels feature support
Date: Tue, 21 May 2013 18:07:26 +0100	[thread overview]
Message-ID: <20130521170726.GA18489__41433.7186994546$1369156211$gmane$org@zion.uk.xensource.com> (raw)
In-Reply-To: <20130521162825.GA3669@phenom.dumpdata.com>

On Tue, May 21, 2013 at 12:28:25PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, May 21, 2013 at 02:41:49PM +0100, Wei Liu wrote:
> > On Tue, May 21, 2013 at 02:39:01PM +0100, David Vrabel wrote:
> > [...]
> > > > +	info->rx_evtchn = info->tx_evtchn;
> > > > +	info->rx_irq = info->tx_irq = err;
> > > > +	dev_info(&info->xbdev->dev,
> > > > +		 "single event channel, evtchn = %d, irq = %d\n",
> > > > +		 info->tx_evtchn, info->tx_irq);
> > > 
> > > This message is pointless chatter as the information is available
> > > elsewhere.  Please remove.
> > > 
> > 
> > Do you mean /proc/interrupt by "elsewhere"? Information there doesn't
> > give you irq<->evtchn mapping info.
> 
> If you really want to, that should be implemented via an DebugFS entry that can
> be driven from drivers/xen/events.c. As the events.c is the generic code that sets
> up the Xen events, pirqs, ipis, <-> Linux IRQs.

I mainly focus on upstreaming all necessary features for a new Xen
network baseline, so I would rather not touch other files.

I will delete these dev_info, they don't seem to be critical anyway.

Wei.