[U-Boot] [PATCH 1/2] powerpc/83xx/km: MV88e6122 errata fix for 1.9V

[U-Boot] [PATCH 1/2] powerpc/83xx/km: MV88e6122 errata fix for 1.9V

[Holger Brunck]

Errata Fix: 1.9V Output from Internal 1.8V Regulator, acc.
MV-S300889-00D.pdf , clause 4.5

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
---
 board/keymile/km83xx/km83xx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c
index faaa39b..71b9e96 100644
--- a/board/keymile/km83xx/km83xx.c
+++ b/board/keymile/km83xx/km83xx.c
@@ -243,6 +243,11 @@ static struct mv88e_sw_reg extsw_conf[] = {
 	{ PORT(5), 0x1A, 0xADB1 },
 	/* port 6, unused, this port has no phy */
 	{ PORT(6), PORT_CTRL, PORT_DIS },
+	/*
+	 * Errata Fix: 1.9V Output from Internal 1.8V Regulator,
+	 * acc . MV-S300889-00D.pdf , clause 4.5
+	 */
+	{ PORT(5), 0x1A, 0xADB1 },
 };
 #endif
 
-- 
1.8.0.1

[U-Boot] [PATCH 2/2] powerpc/83xx/km: make local functions and structs static

[Holger Brunck]

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
---
 board/keymile/common/common.c | 4 ++--
 board/keymile/common/ivm.c    | 4 ++--
 board/keymile/km83xx/km83xx.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index ef93ed3..544784a 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -242,7 +242,7 @@ U_BOOT_CMD(km_setboardid, 1, 0, do_setboardid, "setboardid", "read out bid and "
  *				application and in the init scripts (?)
  *	return 0 in case of match, 1 if not match or error
  */
-int do_checkboardidhwk(cmd_tbl_t *cmdtp, int flag, int argc,
+static int do_checkboardidhwk(cmd_tbl_t *cmdtp, int flag, int argc,
 			char *const argv[])
 {
 	unsigned long ivmbid = 0, ivmhwkey = 0;
@@ -383,7 +383,7 @@ U_BOOT_CMD(km_checkbidhwk, 2, 0, do_checkboardidhwk,
  *  if the testpin of the board is asserted, return 1
  *  *	else return 0
  */
-int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
+static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
 			char *const argv[])
 {
 	int testpin = 0;
diff --git a/board/keymile/common/ivm.c b/board/keymile/common/ivm.c
index 22d5256..0deed1d 100644
--- a/board/keymile/common/ivm.c
+++ b/board/keymile/common/ivm.c
@@ -26,7 +26,7 @@
 #include <i2c.h>
 #include "common.h"
 
-int ivm_calc_crc(unsigned char *buf, int len)
+static int ivm_calc_crc(unsigned char *buf, int len)
 {
 	const unsigned short crc_tab[16] = {
 		0x0000, 0xCC01, 0xD801, 0x1400,
@@ -252,7 +252,7 @@ static int ivm_analyze_block2(unsigned char *buf, int len)
 	return 0;
 }
 
-int ivm_analyze_eeprom(unsigned char *buf, int len)
+static int ivm_analyze_eeprom(unsigned char *buf, int len)
 {
 	unsigned short	val;
 	unsigned char	valbuf[CONFIG_SYS_IVM_EEPROM_PAGE_LEN];
diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c
index 71b9e96..d9f718e 100644
--- a/board/keymile/km83xx/km83xx.c
+++ b/board/keymile/km83xx/km83xx.c
@@ -31,7 +31,7 @@
 
 #include "../common/common.h"
 
-const qe_iop_conf_t qe_iop_conf_tab[] = {
+static const qe_iop_conf_t qe_iop_conf_tab[] = {
 	/* port pin dir open_drain assign */
 #if defined(CONFIG_MPC8360)
 	/* MDIO */
@@ -300,7 +300,7 @@ int last_stage_init(void)
 	return 0;
 }
 
-int fixed_sdram(void)
+static int fixed_sdram(void)
 {
 	immap_t *im = (immap_t *)CONFIG_SYS_IMMR;
 	u32 msize = 0;
-- 
1.8.0.1

[U-Boot] [PATCH 1/2] powerpc/83xx/km: MV88e6122 errata fix for 1.9V

[Kim Phillips]

On Mon, 6 May 2013 15:02:39 +0200
Holger Brunck <holger.brunck@keymile.com> wrote:

> Errata Fix: 1.9V Output from Internal 1.8V Regulator, acc.
> MV-S300889-00D.pdf , clause 4.5
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> ---

patches 1-2 applied to mpc83xx/next.

Thanks,

Kim

[U-Boot] [PATCH 1/2] powerpc/83xx/km: MV88e6122 errata fix for 1.9V

[Holger Brunck]

Hi Kim,

On 05/22/2013 01:12 AM, Kim Phillips wrote:
> On Mon, 6 May 2013 15:02:39 +0200
> Holger Brunck <holger.brunck@keymile.com> wrote:
> 
>> Errata Fix: 1.9V Output from Internal 1.8V Regulator, acc.
>> MV-S300889-00D.pdf , clause 4.5
>>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> ---
> 
> patches 1-2 applied to mpc83xx/next.
> 

I wonder what happened to these patches. I see them in your tree but not in
u-boot mainline. Did you miss to send a pull request?

Anyway it's no problem for us if they get in within the next merge window.

Regards
Holger