From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Peter Stuge <peter@stuge.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arch@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pcmcia@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
cluster-devel@redhat.com, linux-mm@kvack.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Pavel Machek <pavel@ucw.cz>,
Doug Thompson <dougthompson@xmission.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Whitehouse <swhiteho@redhat.com>,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] Finally eradicate CONFIG_HOTPLUG
Date: Wed, 22 May 2013 10:04:47 +1000 [thread overview]
Message-ID: <20130522100447.0f04799ea138a2f391d38850@canb.auug.org.au> (raw)
In-Reply-To: <20130521101349.30660.qmail@stuge.se>
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
Hi Peter,
On Tue, 21 May 2013 12:13:49 +0200 Peter Stuge <peter@stuge.se> wrote:
>
> Are you changing the code to have HOTPLUG always -on- or -off- ?
>
> From the commit message I had expected always -on-.
Yes, it has been that way for some time.
> Stephen Rothwell wrote:
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -68,14 +68,6 @@
> > * are handled as text/data or they can be discarded (which
> > * often happens at runtime)
> > */
> > -#ifdef CONFIG_HOTPLUG
> > -#define DEV_KEEP(sec) *(.dev##sec)
> > -#define DEV_DISCARD(sec)
> > -#else
> > -#define DEV_KEEP(sec)
> > -#define DEV_DISCARD(sec) *(.dev##sec)
> > -#endif
> > -
> > #ifdef CONFIG_HOTPLUG_CPU
> > #define CPU_KEEP(sec) *(.cpu##sec)
> > #define CPU_DISCARD(sec)
> > @@ -182,8 +174,6 @@
> > *(.data) \
> > *(.ref.data) \
> > *(.data..shared_aligned) /* percpu related */ \
> > - DEV_KEEP(init.data) \
> > - DEV_KEEP(exit.data) \
> ..
> > @@ -503,7 +489,6 @@
> > /* init and exit section handling */
> > #define INIT_DATA \
> > *(.init.data) \
> > - DEV_DISCARD(init.data) \
>
> Shouldn't the effect of one of the above remain?
As far as I can tell, all references to devinit and devexit have now been
removed from the kernel, so nothing will generate code in these sections
any more, so the linker script no longer needs to deal with them at all.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: sfr@canb.auug.org.au (Stephen Rothwell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Finally eradicate CONFIG_HOTPLUG
Date: Wed, 22 May 2013 10:04:47 +1000 [thread overview]
Message-ID: <20130522100447.0f04799ea138a2f391d38850@canb.auug.org.au> (raw)
In-Reply-To: <20130521101349.30660.qmail@stuge.se>
Hi Peter,
On Tue, 21 May 2013 12:13:49 +0200 Peter Stuge <peter@stuge.se> wrote:
>
> Are you changing the code to have HOTPLUG always -on- or -off- ?
>
> From the commit message I had expected always -on-.
Yes, it has been that way for some time.
> Stephen Rothwell wrote:
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -68,14 +68,6 @@
> > * are handled as text/data or they can be discarded (which
> > * often happens at runtime)
> > */
> > -#ifdef CONFIG_HOTPLUG
> > -#define DEV_KEEP(sec) *(.dev##sec)
> > -#define DEV_DISCARD(sec)
> > -#else
> > -#define DEV_KEEP(sec)
> > -#define DEV_DISCARD(sec) *(.dev##sec)
> > -#endif
> > -
> > #ifdef CONFIG_HOTPLUG_CPU
> > #define CPU_KEEP(sec) *(.cpu##sec)
> > #define CPU_DISCARD(sec)
> > @@ -182,8 +174,6 @@
> > *(.data) \
> > *(.ref.data) \
> > *(.data..shared_aligned) /* percpu related */ \
> > - DEV_KEEP(init.data) \
> > - DEV_KEEP(exit.data) \
> ..
> > @@ -503,7 +489,6 @@
> > /* init and exit section handling */
> > #define INIT_DATA \
> > *(.init.data) \
> > - DEV_DISCARD(init.data) \
>
> Shouldn't the effect of one of the above remain?
As far as I can tell, all references to devinit and devexit have now been
removed from the kernel, so nothing will generate code in these sections
any more, so the linker script no longer needs to deal with them at all.
--
Cheers,
Stephen Rothwell sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130522/177a0623/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Finally eradicate CONFIG_HOTPLUG
Date: Wed, 22 May 2013 10:04:47 +1000 [thread overview]
Message-ID: <20130522100447.0f04799ea138a2f391d38850@canb.auug.org.au> (raw)
In-Reply-To: <20130521101349.30660.qmail@stuge.se>
Hi Peter,
On Tue, 21 May 2013 12:13:49 +0200 Peter Stuge <peter@stuge.se> wrote:
>
> Are you changing the code to have HOTPLUG always -on- or -off- ?
>
> From the commit message I had expected always -on-.
Yes, it has been that way for some time.
> Stephen Rothwell wrote:
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -68,14 +68,6 @@
> > * are handled as text/data or they can be discarded (which
> > * often happens at runtime)
> > */
> > -#ifdef CONFIG_HOTPLUG
> > -#define DEV_KEEP(sec) *(.dev##sec)
> > -#define DEV_DISCARD(sec)
> > -#else
> > -#define DEV_KEEP(sec)
> > -#define DEV_DISCARD(sec) *(.dev##sec)
> > -#endif
> > -
> > #ifdef CONFIG_HOTPLUG_CPU
> > #define CPU_KEEP(sec) *(.cpu##sec)
> > #define CPU_DISCARD(sec)
> > @@ -182,8 +174,6 @@
> > *(.data) \
> > *(.ref.data) \
> > *(.data..shared_aligned) /* percpu related */ \
> > - DEV_KEEP(init.data) \
> > - DEV_KEEP(exit.data) \
> ..
> > @@ -503,7 +489,6 @@
> > /* init and exit section handling */
> > #define INIT_DATA \
> > *(.init.data) \
> > - DEV_DISCARD(init.data) \
>
> Shouldn't the effect of one of the above remain?
As far as I can tell, all references to devinit and devexit have now been
removed from the kernel, so nothing will generate code in these sections
any more, so the linker script no longer needs to deal with them at all.
--
Cheers,
Stephen Rothwell sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20130522/177a0623/attachment.sig>
next prev parent reply other threads:[~2013-05-22 0:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 3:49 [PATCH] Finally eradicate CONFIG_HOTPLUG Stephen Rothwell
2013-05-21 3:49 ` [Cluster-devel] " Stephen Rothwell
2013-05-21 3:49 ` Stephen Rothwell
2013-05-21 7:38 ` Hans Verkuil
2013-05-21 7:38 ` [Cluster-devel] " Hans Verkuil
2013-05-21 7:38 ` Hans Verkuil
2013-05-21 7:38 ` Hans Verkuil
2013-05-21 10:13 ` Peter Stuge
2013-05-21 10:13 ` [Cluster-devel] " Peter Stuge
2013-05-21 10:13 ` Peter Stuge
2013-05-22 0:04 ` Stephen Rothwell [this message]
2013-05-22 0:04 ` [Cluster-devel] " Stephen Rothwell
2013-05-22 0:04 ` Stephen Rothwell
2013-05-21 10:21 ` Mauro Carvalho Chehab
2013-05-21 10:21 ` [Cluster-devel] " Mauro Carvalho Chehab
2013-05-21 10:21 ` Mauro Carvalho Chehab
2013-05-21 10:21 ` Mauro Carvalho Chehab
2013-05-21 11:39 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522100447.0f04799ea138a2f391d38850@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cluster-devel@redhat.com \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=peter@stuge.se \
--cc=rjw@sisk.pl \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.