All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cifs.upcall.c: the exit code should be 0 when print version
@ 2013-05-17  9:27 Peng Haitao
       [not found] ` <1368782822-15039-1-git-send-email-penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Haitao @ 2013-05-17  9:27 UTC (permalink / raw)
  To: jlayton-eUNUBHrolfbYtjvyW6yDsg; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA

When print version number, the exit code should be 0
and syslog() should not send "Negating key" to the system logger.

Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 cifs.upcall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cifs.upcall.c b/cifs.upcall.c
index 12d5900..6c0b9de 100644
--- a/cifs.upcall.c
+++ b/cifs.upcall.c
@@ -857,6 +857,7 @@ int main(const int argc, char *const argv[])
 			legacy_uid++;
 			break;
 		case 'v':
+			rc = 0;
 			printf("version: %s\n", VERSION);
 			goto out;
 		default:
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cifs.upcall.c: the exit code should be 0 when print version
       [not found] ` <1368782822-15039-1-git-send-email-penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2013-05-23 10:41   ` Jeff Layton
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2013-05-23 10:41 UTC (permalink / raw)
  To: Peng Haitao; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA

On Fri, 17 May 2013 17:27:02 +0800
Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:

> When print version number, the exit code should be 0
> and syslog() should not send "Negating key" to the system logger.
> 
> Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  cifs.upcall.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cifs.upcall.c b/cifs.upcall.c
> index 12d5900..6c0b9de 100644
> --- a/cifs.upcall.c
> +++ b/cifs.upcall.c
> @@ -857,6 +857,7 @@ int main(const int argc, char *const argv[])
>  			legacy_uid++;
>  			break;
>  		case 'v':
> +			rc = 0;
>  			printf("version: %s\n", VERSION);
>  			goto out;
>  		default:

Merged...
-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-23 10:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-17  9:27 [PATCH] cifs.upcall.c: the exit code should be 0 when print version Peng Haitao
     [not found] ` <1368782822-15039-1-git-send-email-penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-05-23 10:41   ` Jeff Layton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.