All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/12] ARM: shmobile: r8a7740: Add Suspend-To-RAM A3SM
Date: Tue, 28 May 2013 05:29:00 +0000	[thread overview]
Message-ID: <20130528052900.GB25005@verge.net.au> (raw)
In-Reply-To: <20130528035019.GI13532@quad.lixom.net>

On Mon, May 27, 2013 at 08:50:19PM -0700, Olof Johansson wrote:
> Hi,
> 
> On Mon, May 27, 2013 at 05:59:50PM +0900, Simon Horman wrote:
> > From: Bastian Hecht <hechtb@gmail.com>
> > 
> > We add 2 Suspend to RAM modes:
> > - A3SM PLL0 on/off:     Power domain A3SM that contains the ARM core
> >                         and the 2nd level cache with either PLL0 on
> >                         or off
> > 
> > As the suspend to memory mechanism we use A3SM PLL off. A3SM PLL on
> > is included here too, so CPUIdle can use both power down modes (not
> > included in this patch).
> > 
> > The setup of the SYSC regarding the external IRQs is taken from
> > pm-sh7372.c from Magnus Damm.
> > 
> > Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> 
> Missing S-o-b from you, Simon?

Oops sorry about that.

> > +	.text
> > +ENTRY(v7_cpu_resume)
> > +	bl	v7_invalidate_l1
> > +	b	cpu_resume
> > +ENDPROC(v7_cpu_resume)
> 
> This is a global namespace so it'll conflict with i.MX whenever
> you multiplatform enable shmobile. Might want to pick a more
> unique name.

Bastian, could you suggest an alternate name?

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/12] ARM: shmobile: r8a7740: Add Suspend-To-RAM A3SM
Date: Tue, 28 May 2013 14:29:00 +0900	[thread overview]
Message-ID: <20130528052900.GB25005@verge.net.au> (raw)
In-Reply-To: <20130528035019.GI13532@quad.lixom.net>

On Mon, May 27, 2013 at 08:50:19PM -0700, Olof Johansson wrote:
> Hi,
> 
> On Mon, May 27, 2013 at 05:59:50PM +0900, Simon Horman wrote:
> > From: Bastian Hecht <hechtb@gmail.com>
> > 
> > We add 2 Suspend to RAM modes:
> > - A3SM PLL0 on/off:     Power domain A3SM that contains the ARM core
> >                         and the 2nd level cache with either PLL0 on
> >                         or off
> > 
> > As the suspend to memory mechanism we use A3SM PLL off. A3SM PLL on
> > is included here too, so CPUIdle can use both power down modes (not
> > included in this patch).
> > 
> > The setup of the SYSC regarding the external IRQs is taken from
> > pm-sh7372.c from Magnus Damm.
> > 
> > Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> 
> Missing S-o-b from you, Simon?

Oops sorry about that.

> > +	.text
> > +ENTRY(v7_cpu_resume)
> > +	bl	v7_invalidate_l1
> > +	b	cpu_resume
> > +ENDPROC(v7_cpu_resume)
> 
> This is a global namespace so it'll conflict with i.MX whenever
> you multiplatform enable shmobile. Might want to pick a more
> unique name.

Bastian, could you suggest an alternate name?

  reply	other threads:[~2013-05-28  5:29 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  8:59 [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Simon Horman
2013-05-27  8:59 ` Simon Horman
2013-05-27  8:59 ` [PATCH 01/12] ARM: shmobile: remove ";" from SH_FIXED_RATIO_CLK*() macro Simon Horman
2013-05-27  8:59   ` [PATCH 01/12] ARM: shmobile: remove "; " " Simon Horman
2013-05-27  8:59 ` [PATCH 02/12] ARM: shmobile: r8a7740 pinmux platform device cleanup Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27  8:59 ` [PATCH 03/12] ARM: shmobile: r8a7740: Add interim sh-eth device name to clocks list Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27  8:59 ` [PATCH 04/12] ARM: shmobile: r8a7740: Add DT name to clock list for CMT10 Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-28  3:29   ` Olof Johansson
2013-05-28  3:29     ` Olof Johansson
2013-05-28  5:29     ` Simon Horman
2013-05-28  5:29       ` Simon Horman
2013-05-28  6:22       ` Olof Johansson
2013-05-28  6:22         ` Olof Johansson
2013-05-31  7:57         ` Magnus Damm
2013-05-31  7:57           ` Magnus Damm
2013-05-31 21:39           ` Arnd Bergmann
2013-05-31 21:39             ` Arnd Bergmann
2013-06-01  4:20             ` Olof Johansson
2013-06-01  4:20               ` Olof Johansson
2013-05-27  8:59 ` [PATCH 05/12] ARM: shmobile: r8a7740: Make private clock arrays static Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27  8:59 ` [PATCH 06/12] ARM: shmobile: r8a7740: Add I2C DT clock names Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-28  3:30   ` Olof Johansson
2013-05-28  3:30     ` Olof Johansson
2013-05-27  8:59 ` [PATCH 07/12] ARM: shmobile: r8a7740: Add OF support to initialze the GIC Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-28  3:36   ` Olof Johansson
2013-05-28  3:36     ` Olof Johansson
2013-05-27  8:59 ` [PATCH 08/12] ARM: shmobile: r8a7740: Prepare for reference DT setup Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27  8:59 ` [PATCH 09/12] ARM: shmobile: r8a7740: Add Suspend-To-RAM A3SM Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-28  3:50   ` Olof Johansson
2013-05-28  3:50     ` Olof Johansson
2013-05-28  5:29     ` Simon Horman [this message]
2013-05-28  5:29       ` Simon Horman
2013-05-28 21:20       ` Bastian Hecht
2013-05-28 21:20         ` Bastian Hecht
2013-06-04  5:09     ` Simon Horman
2013-06-04  5:09       ` Simon Horman
2013-06-04 15:34       ` Bastian Hecht
2013-06-04 15:34         ` Bastian Hecht
2013-06-06  1:10         ` Simon Horman
2013-06-06  1:10           ` Simon Horman
2013-05-27  8:59 ` [PATCH 10/12] ARM: shmobile: r8a7740: Add CPUIdle Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27 11:03   ` Daniel Lezcano
2013-05-27 11:03     ` Daniel Lezcano
2013-05-27 11:03     ` Daniel Lezcano
2013-05-28  3:54     ` Olof Johansson
2013-05-28  3:54       ` Olof Johansson
2013-05-28  3:54       ` Olof Johansson
2013-05-28  6:08       ` Daniel Lezcano
2013-05-28  6:08         ` Daniel Lezcano
2013-05-28  6:08         ` Daniel Lezcano
2013-06-04  5:10       ` Simon Horman
2013-06-04  5:10         ` Simon Horman
2013-06-04  5:10         ` Simon Horman
2013-05-27  8:59 ` [PATCH 11/12] ARM: shmobile: fix sleep-r8a7740.S miscompiles Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-27  8:59 ` [PATCH 12/12] ARM: shmobile: clock-r8a7740: add TPU PWM support Simon Horman
2013-05-27  8:59   ` Simon Horman
2013-05-28  3:58 ` [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Olof Johansson
2013-05-28  3:58   ` Olof Johansson
2013-05-28  5:33   ` Simon Horman
2013-05-28  5:33     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130528052900.GB25005@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.