All of lore.kernel.org
 help / color / mirror / Atom feed
* [libnftables PATCH] data_reg: conditional XML code for snprintf_xml
@ 2013-05-28 15:06 Arturo Borrero
  2013-05-29 12:11 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero @ 2013-05-28 15:06 UTC (permalink / raw)
  To: netfilter-devel; +Cc: pablo

Having or not XML parsing support doesn't break XML printing.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/expr/data_reg.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index c0a048c..24497ff 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -262,7 +262,6 @@ static
 int nft_data_reg_value_snprintf_xml(char *buf, size_t size,
 				    union nft_data_reg *reg, uint32_t flags)
 {
-#ifdef XML_PARSING
 	int len = size, offset = 0, ret, i, j;
 	uint8_t *tmp;
 	int data_len = reg->len/sizeof(uint32_t);
@@ -292,10 +291,6 @@ int nft_data_reg_value_snprintf_xml(char *buf, size_t size,
 	SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
 
 	return offset;
-#else
-	errno = EOPNOTSUPP;
-	return -1;
-#endif
 }
 
 static int


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [libnftables PATCH] data_reg: conditional XML code for snprintf_xml
  2013-05-28 15:06 [libnftables PATCH] data_reg: conditional XML code for snprintf_xml Arturo Borrero
@ 2013-05-29 12:11 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-05-29 12:11 UTC (permalink / raw)
  To: Arturo Borrero; +Cc: netfilter-devel

On Tue, May 28, 2013 at 05:06:21PM +0200, Arturo Borrero wrote:
> Having or not XML parsing support doesn't break XML printing.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-29 12:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-28 15:06 [libnftables PATCH] data_reg: conditional XML code for snprintf_xml Arturo Borrero
2013-05-29 12:11 ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.