* [meta-fsl-arm][PATCH v4 1/3] amd-gpu-x11-bin-mx51: only enable when x11 is in DISTRO_FEATURES @ 2013-05-29 18:01 Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 2/3] amd-gpu-x11-bin-mx51: factorize the recipes Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 3/3] amd-gpu-bin-mx51: new recipe Eric Bénard 0 siblings, 2 replies; 9+ messages in thread From: Eric Bénard @ 2013-05-29 18:01 UTC (permalink / raw) To: meta-freescale this prevent warnings and parse errors Signed-off-by: Eric Bénard <eric@eukrea.com> --- recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb index 2dee47a..60fcafc 100644 --- a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb +++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb @@ -84,5 +84,5 @@ FILES_lib2dz160-mx51-dbg = "${libdir}/.debug/lib2dz160${SOLIBS}" FILES_lib2dz430-mx51 = "${libdir}/lib2dz430${SOLIBS}" FILES_lib2dz430-mx51-dbg = "${libdir}/.debug/lib2dz430${SOLIBS}" -COMPATIBLE_MACHINE = "(mx5)" +COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" PACKAGE_ARCH = "${MACHINE_ARCH}" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [meta-fsl-arm][PATCH v4 2/3] amd-gpu-x11-bin-mx51: factorize the recipes 2013-05-29 18:01 [meta-fsl-arm][PATCH v4 1/3] amd-gpu-x11-bin-mx51: only enable when x11 is in DISTRO_FEATURES Eric Bénard @ 2013-05-29 18:01 ` Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 3/3] amd-gpu-bin-mx51: new recipe Eric Bénard 1 sibling, 0 replies; 9+ messages in thread From: Eric Bénard @ 2013-05-29 18:01 UTC (permalink / raw) To: meta-freescale this will allow easier addition of non x11 package Signed-off-by: Eric Bénard <eric@eukrea.com> --- recipes-graphics/amd-gpu-x11-bin/amd-gpu-mx51.inc | 82 ++++++++++++++++++++ .../amd-gpu-x11-bin-mx51_11.09.01.bb | 74 +----------------- .../fix-linux-build-check.patch | 0 3 files changed, 83 insertions(+), 73 deletions(-) create mode 100644 recipes-graphics/amd-gpu-x11-bin/amd-gpu-mx51.inc rename recipes-graphics/amd-gpu-x11-bin/{amd-gpu-x11-bin-mx51 => files}/fix-linux-build-check.patch (100%) diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-mx51.inc b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-mx51.inc new file mode 100644 index 0000000..b081695 --- /dev/null +++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-mx51.inc @@ -0,0 +1,82 @@ +# Copyright (C) 2011, 2012 Freescale +# Released under the MIT license (see COPYING.MIT for the terms) + +LICENSE = "Proprietary" +SECTION = "libs" + +# FIXME: Replace for correct AMD license +LIC_FILES_CHKSUM = "file://usr/include/VG/openvg.h;endline=30;md5=b0109611dd76961057d4c45ae6519802" + +PROVIDES = "virtual/egl virtual/libgles1 virtual/libgles2" + +SRC_URI = "${FSL_MIRROR}/${PN}-${PV}.bin;fsl-eula=true \ + file://fix-linux-build-check.patch" + +inherit fsl-eula-unpack + +# FIXME: All binaries lack GNU_HASH in elf binary but as we don't have +# the source we cannot fix it. Disable the insane check for now. +python populate_packages_prepend() { + for p in d.getVar('PACKAGES', True).split(): + d.setVar("INSANE_SKIP_%s" % p, "ldflags") +} + +do_install () { + install -d ${D}${libdir} + install -d ${D}${bindir} + install -d ${D}${includedir} + + cp -axr ${S}/usr/bin/* ${D}${bindir} + cp -axf ${S}/usr/lib/* ${D}${libdir} + cp -axr ${S}/usr/include/* ${D}${includedir} + + find ${D}${bindir} -type f -exec chmod 755 {} \; + find ${D}${libdir} -type f -exec chmod 644 {} \; + find ${D}${includedir} -type f -exec chmod 644 {} \; + + # FIXME: Fix sonames of broken libraries + mv ${D}${libdir}/lib2dz160.so ${D}${libdir}/lib2dz160.so.0 + mv ${D}${libdir}/lib2dz430.so ${D}${libdir}/lib2dz430.so.0 + + # FIXME: Remove unkown files + rm -r ${D}${libdir}/libcsi.a \ + ${D}${libdir}/libres.a +} + +PACKAGES =+ "libgsl-fsl-mx51 libgsl-fsl-mx51-dev libgsl-fsl-mx51-dbg \ + libegl-mx51 libegl-mx51-dev libegl-mx51-dbg \ + libgles-mx51 libgles-mx51-dev libgles-mx51-dbg \ + libgles2-mx51 libgles2-mx51-dev libgles2-mx51-dbg \ + libopenvg-mx51 libopenvg-mx51-dev libopenvg-mx51-dbg \ + lib2dz160-mx51 lib2dz160-mx51-dbg \ + lib2dz430-mx51 lib2dz430-mx51-dbg" + +FILES_${PN}-dbg = "${bindir}/.debug/*" + +FILES_libgsl-fsl-mx51 = "${libdir}/libgsl-fsl${SOLIBS}" +FILES_libgsl-fsl-mx51-dev = "${libdir}/libgsl-fsl${SOLIBSDEV}" +FILES_libgsl-fsl-mx51-dbg = "${libdir}/.debug/libgsl-fsl${SOLIBS}" + +FILES_libegl-mx51 = "${libdir}/libEGL${SOLIBS}" +FILES_libegl-mx51-dev = "${includedir}/EGL ${includedir}/KHR ${libdir}/libEGL${SOLIBSDEV}" +FILES_libegl-mx51-dbg = "${libdir}/.debug/libEGL${SOLIBS}" + +FILES_libgles-mx51 = "${libdir}/libGLESv1*${SOLIBS}" +FILES_libgles-mx51-dev = "${includedir}/GLES ${libdir}/libGLESv1*${SOLIBSDEV}" +FILES_libgles-mx51-dbg = "${libdir}/.debug/libGLESv1*${SOLIBS}" + +FILES_libgles2-mx51 = "${libdir}/libGLESv2${SOLIBS}" +FILES_libgles2-mx51-dev = "${includedir}/GLES2 ${libdir}/libGLESv2${SOLIBSDEV}" +FILES_libgles2-mx51-dbg = "${libdir}/.debug/libGLESv2${SOLIBS}" + +FILES_libopenvg-mx51 = "${libdir}/libOpenVG${SOLIBS}" +FILES_libopenvg-mx51-dev = "${includedir}/VG ${libdir}/libOpenVG${SOLIBSDEV}" +FILES_libopenvg-mx51-dbg = "${libdir}/.debug/libOpenVG${SOLIBS}" + +FILES_lib2dz160-mx51 = "${libdir}/lib2dz160${SOLIBS}" +FILES_lib2dz160-mx51-dbg = "${libdir}/.debug/lib2dz160${SOLIBS}" + +FILES_lib2dz430-mx51 = "${libdir}/lib2dz430${SOLIBS}" +FILES_lib2dz430-mx51-dbg = "${libdir}/.debug/lib2dz430${SOLIBS}" + +PACKAGE_ARCH = "${MACHINE_ARCH}" diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb index 60fcafc..f33f114 100644 --- a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb +++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb @@ -2,87 +2,15 @@ # Released under the MIT license (see COPYING.MIT for the terms) DESCRIPTION = "GPU driver and apps for x11 on mx51" -LICENSE = "Proprietary" -SECTION = "libs" PR = "r12" # FIXME: Replace for correct AMD license LIC_FILES_CHKSUM = "file://usr/include/VG/openvg.h;endline=30;md5=b0109611dd76961057d4c45ae6519802" DEPENDS = "virtual/libx11 libxrender" -PROVIDES = "virtual/egl virtual/libgles1 virtual/libgles2" +include amd-gpu-mx51.inc -SRC_URI = "${FSL_MIRROR}/amd-gpu-x11-bin-mx51-${PV}.bin;fsl-eula=true \ - file://fix-linux-build-check.patch" SRC_URI[md5sum] = "54391a4e670b597d06d01253fb217cad" SRC_URI[sha256sum] = "c7a6fa03b7aa2a375556c59908876554ba720c1e744baba2debb84a408f790db" -inherit fsl-eula-unpack - -# FIXME: All binaries lack GNU_HASH in elf binary but as we don't have -# the source we cannot fix it. Disable the insane check for now. -python populate_packages_prepend() { - for p in d.getVar('PACKAGES', True).split(): - d.setVar("INSANE_SKIP_%s" % p, "ldflags") -} - -do_install () { - install -d ${D}${libdir} - install -d ${D}${bindir} - install -d ${D}${includedir} - - cp -axr ${S}/usr/bin/* ${D}${bindir} - cp -axf ${S}/usr/lib/* ${D}${libdir} - cp -axr ${S}/usr/include/* ${D}${includedir} - - find ${D}${bindir} -type f -exec chmod 755 {} \; - find ${D}${libdir} -type f -exec chmod 644 {} \; - find ${D}${includedir} -type f -exec chmod 644 {} \; - - # FIXME: Fix sonames of broken libraries - mv ${D}${libdir}/lib2dz160.so ${D}${libdir}/lib2dz160.so.0 - mv ${D}${libdir}/lib2dz430.so ${D}${libdir}/lib2dz430.so.0 - - # FIXME: Remove unkown files - rm -r ${D}${libdir}/libcsi.a \ - ${D}${libdir}/libres.a -} - -PACKAGES =+ "libgsl-fsl-mx51 libgsl-fsl-mx51-dev libgsl-fsl-mx51-dbg \ - libegl-mx51 libegl-mx51-dev libegl-mx51-dbg \ - libgles-mx51 libgles-mx51-dev libgles-mx51-dbg \ - libgles2-mx51 libgles2-mx51-dev libgles2-mx51-dbg \ - libopenvg-mx51 libopenvg-mx51-dev libopenvg-mx51-dbg \ - lib2dz160-mx51 lib2dz160-mx51-dbg \ - lib2dz430-mx51 lib2dz430-mx51-dbg" - -FILES_${PN}-dbg = "${bindir}/.debug/*" - -FILES_libgsl-fsl-mx51 = "${libdir}/libgsl-fsl${SOLIBS}" -FILES_libgsl-fsl-mx51-dev = "${libdir}/libgsl-fsl${SOLIBSDEV}" -FILES_libgsl-fsl-mx51-dbg = "${libdir}/.debug/libgsl-fsl${SOLIBS}" - -FILES_libegl-mx51 = "${libdir}/libEGL${SOLIBS}" -FILES_libegl-mx51-dev = "${includedir}/EGL ${includedir}/KHR ${libdir}/libEGL${SOLIBSDEV}" -FILES_libegl-mx51-dbg = "${libdir}/.debug/libEGL${SOLIBS}" - -FILES_libgles-mx51 = "${libdir}/libGLESv1*${SOLIBS}" -FILES_libgles-mx51-dev = "${includedir}/GLES ${libdir}/libGLESv1*${SOLIBSDEV}" -FILES_libgles-mx51-dbg = "${libdir}/.debug/libGLESv1*${SOLIBS}" - -FILES_libgles2-mx51 = "${libdir}/libGLESv2${SOLIBS}" -FILES_libgles2-mx51-dev = "${includedir}/GLES2 ${libdir}/libGLESv2${SOLIBSDEV}" -FILES_libgles2-mx51-dbg = "${libdir}/.debug/libGLESv2${SOLIBS}" - -FILES_libopenvg-mx51 = "${libdir}/libOpenVG${SOLIBS}" -FILES_libopenvg-mx51-dev = "${includedir}/VG ${libdir}/libOpenVG${SOLIBSDEV}" -FILES_libopenvg-mx51-dbg = "${libdir}/.debug/libOpenVG${SOLIBS}" - -FILES_lib2dz160-mx51 = "${libdir}/lib2dz160${SOLIBS}" -FILES_lib2dz160-mx51-dbg = "${libdir}/.debug/lib2dz160${SOLIBS}" - -FILES_lib2dz430-mx51 = "${libdir}/lib2dz430${SOLIBS}" -FILES_lib2dz430-mx51-dbg = "${libdir}/.debug/lib2dz430${SOLIBS}" - COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" -PACKAGE_ARCH = "${MACHINE_ARCH}" diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51/fix-linux-build-check.patch b/recipes-graphics/amd-gpu-x11-bin/files/fix-linux-build-check.patch similarity index 100% rename from recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51/fix-linux-build-check.patch rename to recipes-graphics/amd-gpu-x11-bin/files/fix-linux-build-check.patch -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [meta-fsl-arm][PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-29 18:01 [meta-fsl-arm][PATCH v4 1/3] amd-gpu-x11-bin-mx51: only enable when x11 is in DISTRO_FEATURES Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 2/3] amd-gpu-x11-bin-mx51: factorize the recipes Eric Bénard @ 2013-05-29 18:01 ` Eric Bénard 2013-05-30 9:49 ` [PATCH " Javier Viguera 1 sibling, 1 reply; 9+ messages in thread From: Eric Bénard @ 2013-05-29 18:01 UTC (permalink / raw) To: meta-freescale this provides the GPU libraries for framebuffer Signed-off-by: Eric Bénard <eric@eukrea.com> --- .../amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb | 13 +++++++++++++ .../amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb | 2 ++ 2 files changed, 15 insertions(+) create mode 100644 recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb new file mode 100644 index 0000000..ecf38f2 --- /dev/null +++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb @@ -0,0 +1,13 @@ +# Copyright (C) 2011, 2012 Freescale +# Released under the MIT license (see COPYING.MIT for the terms) + +DESCRIPTION = "GPU driver and apps for frambuffer on mx51" + +include amd-gpu-mx51.inc + +SRC_URI[md5sum] = "9f9b5f67b595721a08793aae8bd8fc46" +SRC_URI[sha256sum] = "f0db68a764b5fb199729e7435f606b8d12b61ca97990336c647b7e81f4a584d9" + +RCONFLICTS_${PN} = "amd-gpu-x11-bin-mx51" + +COMPATIBLE_MACHINE = "(mx5)" diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb index f33f114..f8dbcc2 100644 --- a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb +++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb @@ -13,4 +13,6 @@ include amd-gpu-mx51.inc SRC_URI[md5sum] = "54391a4e670b597d06d01253fb217cad" SRC_URI[sha256sum] = "c7a6fa03b7aa2a375556c59908876554ba720c1e744baba2debb84a408f790db" +RCONFLICTS_${PN} = "amd-gpu-bin-mx51" + COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 3/3] amd-gpu-bin-mx51: new recipe Eric Bénard @ 2013-05-30 9:49 ` Javier Viguera 2013-05-30 10:29 ` Eric Bénard 2013-05-31 20:38 ` Eric Bénard 0 siblings, 2 replies; 9+ messages in thread From: Javier Viguera @ 2013-05-30 9:49 UTC (permalink / raw) To: meta-freescale Hi Eric, On 29/05/13 20:01, Eric Bénard wrote: > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb > +COMPATIBLE_MACHINE = "(mx5)" > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" I'm still learning yocto/openembedded so bear with me if all the following does not make sense, but is this correct? When DISTRO_FEATURES contains x11, *both* packages will have: COMPATIBLE_MACHINE = "(mx5)" so both will be available. When DISTRO_FEATURES does *NOT* contain x11, then: amd-gpu-bin-mx51: COMPATIBLE_MACHINE = "(mx5)" amd-gpu-x11-bin-mx51: COMPATIBLE_MACHINE = "" But in this case if i have not misunderstood the semantics of COMPATIBLE_MACHINE both will be again available as an empty COMPATIBLE_MACHINE means that it's available. Not sure it it's very elegant, but i have seen in meta-openembedded layer something similar using "Invalid!" string to invalidate one or the other recipe depending on the distro feature. Shouldn't then be something like the following: amd-gpu-bin-mx51: COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', 'Invalid!', '(mx5)', d)}" amd-gpu-x11-bin-mx51: COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', 'Invalid!', d)}" - Javier Viguera Software Engineer Digi International® Spain S.A.U. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-30 9:49 ` [PATCH " Javier Viguera @ 2013-05-30 10:29 ` Eric Bénard 2013-05-30 12:02 ` Javier Viguera 2013-05-31 20:38 ` Eric Bénard 1 sibling, 1 reply; 9+ messages in thread From: Eric Bénard @ 2013-05-30 10:29 UTC (permalink / raw) To: Javier Viguera; +Cc: meta-freescale Hi Javier, Le Thu, 30 May 2013 11:49:44 +0200, Javier Viguera <javier.viguera@digi.com> a écrit : > On 29/05/13 20:01, Eric Bénard wrote: > > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb > > +COMPATIBLE_MACHINE = "(mx5)" > > > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb > > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" > > I'm still learning yocto/openembedded so bear with me if all the > following does not make sense, but is this correct? > > When DISTRO_FEATURES contains x11, *both* packages will have: > > COMPATIBLE_MACHINE = "(mx5)" > > so both will be available. > > When DISTRO_FEATURES does *NOT* contain x11, then: > > amd-gpu-bin-mx51: COMPATIBLE_MACHINE = "(mx5)" > amd-gpu-x11-bin-mx51: COMPATIBLE_MACHINE = "" > > But in this case if i have not misunderstood the semantics of > COMPATIBLE_MACHINE both will be again available as an empty > COMPATIBLE_MACHINE means that it's available. > > Not sure it it's very elegant, but i have seen in meta-openembedded > layer something similar using "Invalid!" string to invalidate one or > the other recipe depending on the distro feature. > > Shouldn't then be something like the following: > > amd-gpu-bin-mx51: > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', 'Invalid!', '(mx5)', d)}" > > amd-gpu-x11-bin-mx51: > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', 'Invalid!', d)}" > interesting I didn't tought in that way but that seems possible and as the warnings disapeared I thought the x11 package was no more available. This raise an other problem : - when x11 is not in DISTRO_FEATURES, we shouldn't have the x11-bin package. - when x11 is in DISTRO_FEATURES, we could have the non x11 package as nothing prevents users to have x11 in their distro features _and_ to build non x11 images : how to handle that (same problem in the mx6 gpu package) ? Eric ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-30 10:29 ` Eric Bénard @ 2013-05-30 12:02 ` Javier Viguera 2013-05-30 12:07 ` Eric Bénard 0 siblings, 1 reply; 9+ messages in thread From: Javier Viguera @ 2013-05-30 12:02 UTC (permalink / raw) To: Eric Bénard; +Cc: meta-freescale Hi Eric, On 30/05/13 12:29, Eric Bénard wrote: > This raise an other problem : > - when x11 is not in DISTRO_FEATURES, we shouldn't have the x11-bin > package. Well, this probably is solved by something like: amd-gpu-x11-bin-mx51: COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', 'Invalid!', d)}" If x11 is not in DISTRO_FEATURES, then COMPATIBLE_MACHINE becomes 'Invalid!' and that does not match your machine (unless you have a machine named "Invalid!" :-) ) > - when x11 is in DISTRO_FEATURES, we could have the non x11 package > as nothing prevents users to have x11 in their distro features _and_ to > build non x11 images : how to handle that (same problem in the mx6 gpu > package) ? Agree with you that this is a real problem, but unfortunately my yocto skills are not good enough to know how to solve it. Hopefully someone in the list will shed some light. - Javier Viguera Software Engineer Digi International® Spain S.A.U. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-30 12:02 ` Javier Viguera @ 2013-05-30 12:07 ` Eric Bénard 2013-05-31 13:21 ` Otavio Salvador 0 siblings, 1 reply; 9+ messages in thread From: Eric Bénard @ 2013-05-30 12:07 UTC (permalink / raw) To: Javier Viguera; +Cc: meta-freescale Le Thu, 30 May 2013 14:02:33 +0200, Javier Viguera <javier.viguera@digi.com> a écrit : > Hi Eric, > > On 30/05/13 12:29, Eric Bénard wrote: > > This raise an other problem : > > - when x11 is not in DISTRO_FEATURES, we shouldn't have the x11-bin > > package. > > Well, this probably is solved by something like: > > amd-gpu-x11-bin-mx51: > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', 'Invalid!', d)}" > > If x11 is not in DISTRO_FEATURES, then COMPATIBLE_MACHINE becomes > 'Invalid!' and that does not match your machine (unless you have a > machine named "Invalid!" :-) ) > yes that's the behaviour I expected by emptying the COMPATIBLE_MACHINE value. I have to check that more in detail to see if that works (and why my change allowed to get rid of the warnings). Eric ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-30 12:07 ` Eric Bénard @ 2013-05-31 13:21 ` Otavio Salvador 0 siblings, 0 replies; 9+ messages in thread From: Otavio Salvador @ 2013-05-31 13:21 UTC (permalink / raw) To: Eric Bénard; +Cc: meta-freescale, Javier Viguera [-- Attachment #1: Type: text/plain, Size: 1228 bytes --] On Thu, May 30, 2013 at 9:07 AM, Eric Bénard <eric@eukrea.com> wrote: > Le Thu, 30 May 2013 14:02:33 +0200, > Javier Viguera <javier.viguera@digi.com> a écrit : > > > Hi Eric, > > > > On 30/05/13 12:29, Eric Bénard wrote: > > > This raise an other problem : > > > - when x11 is not in DISTRO_FEATURES, we shouldn't have the x11-bin > > > package. > > > > Well, this probably is solved by something like: > > > > amd-gpu-x11-bin-mx51: > > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', > '(mx5)', 'Invalid!', d)}" > > > > If x11 is not in DISTRO_FEATURES, then COMPATIBLE_MACHINE becomes > > 'Invalid!' and that does not match your machine (unless you have a > > machine named "Invalid!" :-) ) > > > yes that's the behaviour I expected by emptying the COMPATIBLE_MACHINE > value. I have to check that more in detail to see if that works (and > why my change allowed to get rid of the warnings). > I will wait your reworked patchset for review it again. Thanks for looking at it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 [-- Attachment #2: Type: text/html, Size: 1992 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] amd-gpu-bin-mx51: new recipe 2013-05-30 9:49 ` [PATCH " Javier Viguera 2013-05-30 10:29 ` Eric Bénard @ 2013-05-31 20:38 ` Eric Bénard 1 sibling, 0 replies; 9+ messages in thread From: Eric Bénard @ 2013-05-31 20:38 UTC (permalink / raw) To: Javier Viguera; +Cc: meta-freescale Hi Javier, Le Thu, 30 May 2013 11:49:44 +0200, Javier Viguera <javier.viguera@digi.com> a écrit : > On 29/05/13 20:01, Eric Bénard wrote: > > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-bin-mx51_11.09.01.bb > > +COMPATIBLE_MACHINE = "(mx5)" > > > diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb > > COMPATIBLE_MACHINE = "${@base_contains('DISTRO_FEATURES', 'x11', '(mx5)', '', d)}" > > I'm still learning yocto/openembedded so bear with me if all the > following does not make sense, but is this correct? > > When DISTRO_FEATURES contains x11, *both* packages will have: > > COMPATIBLE_MACHINE = "(mx5)" > > so both will be available. > > When DISTRO_FEATURES does *NOT* contain x11, then: > > amd-gpu-bin-mx51: COMPATIBLE_MACHINE = "(mx5)" > amd-gpu-x11-bin-mx51: COMPATIBLE_MACHINE = "" > > But in this case if i have not misunderstood the semantics of > COMPATIBLE_MACHINE both will be again available as an empty > COMPATIBLE_MACHINE means that it's available. > after some testings I confirm you are right. Eric ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-31 20:39 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-05-29 18:01 [meta-fsl-arm][PATCH v4 1/3] amd-gpu-x11-bin-mx51: only enable when x11 is in DISTRO_FEATURES Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 2/3] amd-gpu-x11-bin-mx51: factorize the recipes Eric Bénard 2013-05-29 18:01 ` [meta-fsl-arm][PATCH v4 3/3] amd-gpu-bin-mx51: new recipe Eric Bénard 2013-05-30 9:49 ` [PATCH " Javier Viguera 2013-05-30 10:29 ` Eric Bénard 2013-05-30 12:02 ` Javier Viguera 2013-05-30 12:07 ` Eric Bénard 2013-05-31 13:21 ` Otavio Salvador 2013-05-31 20:38 ` Eric Bénard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.