* [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
@ 2013-05-29 20:30 Paul Moore
2013-05-29 21:16 ` Corey Bryant
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paul Moore @ 2013-05-29 20:30 UTC (permalink / raw)
To: qemu-devel; +Cc: coreyb, otubo
In order to enable the asynchronous I/O functionality when using the
seccomp sandbox we need to add the associated syscalls to the
whitelist.
Signed-off-by: Paul Moore <pmoore@redhat.com>
---
qemu-seccomp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index 031da1d..ca123bf 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
{ SCMP_SYS(stat), 245 },
{ SCMP_SYS(uname), 245 },
{ SCMP_SYS(eventfd2), 245 },
+ { SCMP_SYS(io_getevents), 245 },
{ SCMP_SYS(dup), 245 },
{ SCMP_SYS(dup2), 245 },
{ SCMP_SYS(dup3), 245 },
@@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
{ SCMP_SYS(sendmmsg), 241 },
{ SCMP_SYS(recvmmsg), 241 },
{ SCMP_SYS(prlimit64), 241 },
- { SCMP_SYS(waitid), 241 }
+ { SCMP_SYS(waitid), 241 },
+ { SCMP_SYS(io_setup), 241 },
+ { SCMP_SYS(io_destroy), 241 }
};
int seccomp_start(void)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
2013-05-29 20:30 [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist Paul Moore
@ 2013-05-29 21:16 ` Corey Bryant
2013-05-31 18:48 ` Anthony Liguori
2013-07-10 14:31 ` Paul Moore
2 siblings, 0 replies; 6+ messages in thread
From: Corey Bryant @ 2013-05-29 21:16 UTC (permalink / raw)
To: Paul Moore; +Cc: qemu-devel, otubo
On 05/29/2013 04:30 PM, Paul Moore wrote:
> In order to enable the asynchronous I/O functionality when using the
> seccomp sandbox we need to add the associated syscalls to the
> whitelist.
>
> Signed-off-by: Paul Moore <pmoore@redhat.com>
> ---
> qemu-seccomp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 031da1d..ca123bf 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
> { SCMP_SYS(stat), 245 },
> { SCMP_SYS(uname), 245 },
> { SCMP_SYS(eventfd2), 245 },
> + { SCMP_SYS(io_getevents), 245 },
> { SCMP_SYS(dup), 245 },
> { SCMP_SYS(dup2), 245 },
> { SCMP_SYS(dup3), 245 },
> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
> { SCMP_SYS(sendmmsg), 241 },
> { SCMP_SYS(recvmmsg), 241 },
> { SCMP_SYS(prlimit64), 241 },
> - { SCMP_SYS(waitid), 241 }
> + { SCMP_SYS(waitid), 241 },
> + { SCMP_SYS(io_setup), 241 },
> + { SCMP_SYS(io_destroy), 241 }
> };
>
> int seccomp_start(void)
>
>
>
Thanks for the patch. It looks good to me and I see these are used by
the block aio code.
Reviewed-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
--
Regards,
Corey Bryant
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
2013-05-29 20:30 [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist Paul Moore
2013-05-29 21:16 ` Corey Bryant
@ 2013-05-31 18:48 ` Anthony Liguori
2013-07-10 14:31 ` Paul Moore
2 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-05-31 18:48 UTC (permalink / raw)
To: Paul Moore, qemu-devel; +Cc: coreyb, otubo
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
2013-05-29 20:30 [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist Paul Moore
2013-05-29 21:16 ` Corey Bryant
2013-05-31 18:48 ` Anthony Liguori
@ 2013-07-10 14:31 ` Paul Moore
2013-07-10 20:02 ` Andreas Färber
2 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2013-07-10 14:31 UTC (permalink / raw)
To: qemu-devel; +Cc: coreyb, otubo
On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote:
> In order to enable the asynchronous I/O functionality when using the
> seccomp sandbox we need to add the associated syscalls to the
> whitelist.
>
> Signed-off-by: Paul Moore <pmoore@redhat.com>
> ---
> qemu-seccomp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 031da1d..ca123bf 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
> = { { SCMP_SYS(stat), 245 },
> { SCMP_SYS(uname), 245 },
> { SCMP_SYS(eventfd2), 245 },
> + { SCMP_SYS(io_getevents), 245 },
> { SCMP_SYS(dup), 245 },
> { SCMP_SYS(dup2), 245 },
> { SCMP_SYS(dup3), 245 },
> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall
> seccomp_whitelist[] = { { SCMP_SYS(sendmmsg), 241 },
> { SCMP_SYS(recvmmsg), 241 },
> { SCMP_SYS(prlimit64), 241 },
> - { SCMP_SYS(waitid), 241 }
> + { SCMP_SYS(waitid), 241 },
> + { SCMP_SYS(io_setup), 241 },
> + { SCMP_SYS(io_destroy), 241 }
> };
>
> int seccomp_start(void)
Any reason this patch wasn't pulled in for 1.5.1?
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
2013-07-10 14:31 ` Paul Moore
@ 2013-07-10 20:02 ` Andreas Färber
2013-07-10 20:19 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2013-07-10 20:02 UTC (permalink / raw)
To: Paul Moore; +Cc: qemu-stable, coreyb, qemu-devel, otubo
Am 10.07.2013 16:31, schrieb Paul Moore:
> On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote:
>> In order to enable the asynchronous I/O functionality when using the
>> seccomp sandbox we need to add the associated syscalls to the
>> whitelist.
>>
>> Signed-off-by: Paul Moore <pmoore@redhat.com>
>> ---
>> qemu-seccomp.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> index 031da1d..ca123bf 100644
>> --- a/qemu-seccomp.c
>> +++ b/qemu-seccomp.c
>> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
>> = { { SCMP_SYS(stat), 245 },
>> { SCMP_SYS(uname), 245 },
>> { SCMP_SYS(eventfd2), 245 },
>> + { SCMP_SYS(io_getevents), 245 },
>> { SCMP_SYS(dup), 245 },
>> { SCMP_SYS(dup2), 245 },
>> { SCMP_SYS(dup3), 245 },
>> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall
>> seccomp_whitelist[] = { { SCMP_SYS(sendmmsg), 241 },
>> { SCMP_SYS(recvmmsg), 241 },
>> { SCMP_SYS(prlimit64), 241 },
>> - { SCMP_SYS(waitid), 241 }
>> + { SCMP_SYS(waitid), 241 },
>> + { SCMP_SYS(io_setup), 241 },
>> + { SCMP_SYS(io_destroy), 241 }
>> };
>>
>> int seccomp_start(void)
>
> Any reason this patch wasn't pulled in for 1.5.1?
Yes: You forget to put a line Cc: qemu-stable@nongnu.org into the commit
message nor was it ever CC'ed while on the list. ;)
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
2013-07-10 20:02 ` Andreas Färber
@ 2013-07-10 20:19 ` Paul Moore
0 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2013-07-10 20:19 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-stable, coreyb, qemu-devel, otubo
On Wednesday, July 10, 2013 10:02:55 PM Andreas Färber wrote:
> Am 10.07.2013 16:31, schrieb Paul Moore:
> > On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote:
> >> In order to enable the asynchronous I/O functionality when using the
> >> seccomp sandbox we need to add the associated syscalls to the
> >> whitelist.
> >>
> >> Signed-off-by: Paul Moore <pmoore@redhat.com>
> >> ---
> >>
> >> qemu-seccomp.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> >> index 031da1d..ca123bf 100644
> >> --- a/qemu-seccomp.c
> >> +++ b/qemu-seccomp.c
> >> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall
> >> seccomp_whitelist[] = { { SCMP_SYS(stat), 245 },
> >>
> >> { SCMP_SYS(uname), 245 },
> >> { SCMP_SYS(eventfd2), 245 },
> >>
> >> + { SCMP_SYS(io_getevents), 245 },
> >>
> >> { SCMP_SYS(dup), 245 },
> >> { SCMP_SYS(dup2), 245 },
> >> { SCMP_SYS(dup3), 245 },
> >>
> >> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall
> >> seccomp_whitelist[] = { { SCMP_SYS(sendmmsg), 241 },
> >>
> >> { SCMP_SYS(recvmmsg), 241 },
> >> { SCMP_SYS(prlimit64), 241 },
> >>
> >> - { SCMP_SYS(waitid), 241 }
> >> + { SCMP_SYS(waitid), 241 },
> >> + { SCMP_SYS(io_setup), 241 },
> >> + { SCMP_SYS(io_destroy), 241 }
> >>
> >> };
> >>
> >> int seccomp_start(void)
> >
> > Any reason this patch wasn't pulled in for 1.5.1?
>
> Yes: You forget to put a line Cc: qemu-stable@nongnu.org into the commit
> message nor was it ever CC'ed while on the list. ;)
You learn something new everyday, thanks.
Can I assume this will make it into 1.5.2 now?
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-10 20:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-29 20:30 [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist Paul Moore
2013-05-29 21:16 ` Corey Bryant
2013-05-31 18:48 ` Anthony Liguori
2013-07-10 14:31 ` Paul Moore
2013-07-10 20:02 ` Andreas Färber
2013-07-10 20:19 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.