All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: tegra: fix clk_out parents list
@ 2013-05-27  7:54 ` Prashant Gaikwad
  0 siblings, 0 replies; 8+ messages in thread
From: Prashant Gaikwad @ 2013-05-27  7:54 UTC (permalink / raw)
  To: mturquette-QSEj5FYQhm4dnm+yROfE0A,
	swarren-3lzwWm7+Weoh9ZMKESR00Q,
	pdeschrijver-DDmLM1+adcrQT0dZR+AlfA
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Prashant Gaikwad

Number of parents for clk_out_2 and clk_out_3 was incorrectly set
to clk_out1_parents. Even though it did not break anything since the
size was same better to fix.

Signed-off-by: Prashant Gaikwad <pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/clk/tegra/clk-tegra114.c |    4 ++--
 drivers/clk/tegra/clk-tegra30.c  |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
index e0ee077..6d438bb 100644
--- a/drivers/clk/tegra/clk-tegra114.c
+++ b/drivers/clk/tegra/clk-tegra114.c
@@ -1602,7 +1602,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
 
 	/* clk_out_2 */
 	clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out2_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
 			       &clk_out_lock);
 	clks[clk_out_2_mux] = clk;
@@ -1614,7 +1614,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
 
 	/* clk_out_3 */
 	clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out3_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
 			       &clk_out_lock);
 	clks[clk_out_3_mux] = clk;
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index 985ad69..b62e140 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1223,7 +1223,7 @@ static void __init tegra30_pmc_clk_init(void)
 
 	/* clk_out_2 */
 	clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out2_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
 			       &clk_out_lock);
 	clk = clk_register_gate(NULL, "clk_out_2", "clk_out_2_mux", 0,
@@ -1234,7 +1234,7 @@ static void __init tegra30_pmc_clk_init(void)
 
 	/* clk_out_3 */
 	clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out3_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
 			       &clk_out_lock);
 	clk = clk_register_gate(NULL, "clk_out_3", "clk_out_3_mux", 0,
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] clk: tegra: fix clk_out parents list
@ 2013-05-27  7:54 ` Prashant Gaikwad
  0 siblings, 0 replies; 8+ messages in thread
From: Prashant Gaikwad @ 2013-05-27  7:54 UTC (permalink / raw)
  To: linux-arm-kernel

Number of parents for clk_out_2 and clk_out_3 was incorrectly set
to clk_out1_parents. Even though it did not break anything since the
size was same better to fix.

Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
---
 drivers/clk/tegra/clk-tegra114.c |    4 ++--
 drivers/clk/tegra/clk-tegra30.c  |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
index e0ee077..6d438bb 100644
--- a/drivers/clk/tegra/clk-tegra114.c
+++ b/drivers/clk/tegra/clk-tegra114.c
@@ -1602,7 +1602,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
 
 	/* clk_out_2 */
 	clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out2_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
 			       &clk_out_lock);
 	clks[clk_out_2_mux] = clk;
@@ -1614,7 +1614,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
 
 	/* clk_out_3 */
 	clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out3_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
 			       &clk_out_lock);
 	clks[clk_out_3_mux] = clk;
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index 985ad69..b62e140 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1223,7 +1223,7 @@ static void __init tegra30_pmc_clk_init(void)
 
 	/* clk_out_2 */
 	clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out2_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
 			       &clk_out_lock);
 	clk = clk_register_gate(NULL, "clk_out_2", "clk_out_2_mux", 0,
@@ -1234,7 +1234,7 @@ static void __init tegra30_pmc_clk_init(void)
 
 	/* clk_out_3 */
 	clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
-			       ARRAY_SIZE(clk_out1_parents), 0,
+			       ARRAY_SIZE(clk_out3_parents), 0,
 			       pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
 			       &clk_out_lock);
 	clk = clk_register_gate(NULL, "clk_out_3", "clk_out_3_mux", 0,
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] clk: tegra: fix clk_out parents list
  2013-05-27  7:54 ` Prashant Gaikwad
@ 2013-05-27 14:55     ` Thierry Reding
  -1 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2013-05-27 14:55 UTC (permalink / raw)
  To: Prashant Gaikwad
  Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A,
	swarren-3lzwWm7+Weoh9ZMKESR00Q,
	pdeschrijver-DDmLM1+adcrQT0dZR+AlfA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On Mon, May 27, 2013 at 01:24:39PM +0530, Prashant Gaikwad wrote:
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.

This last part of the sentence is hard to understand, I think you meant:

	Even though it did not break anything since the size was the
	same, it should still be fixed.

Other than that:

Reviewed-by: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] clk: tegra: fix clk_out parents list
@ 2013-05-27 14:55     ` Thierry Reding
  0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2013-05-27 14:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, May 27, 2013 at 01:24:39PM +0530, Prashant Gaikwad wrote:
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.

This last part of the sentence is hard to understand, I think you meant:

	Even though it did not break anything since the size was the
	same, it should still be fixed.

Other than that:

Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130527/7121415c/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] clk: tegra: fix clk_out parents list
  2013-05-27  7:54 ` Prashant Gaikwad
@ 2013-05-28 15:16     ` Stephen Warren
  -1 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2013-05-28 15:16 UTC (permalink / raw)
  To: Prashant Gaikwad
  Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A,
	pdeschrijver-DDmLM1+adcrQT0dZR+AlfA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

On 05/27/2013 01:54 AM, Prashant Gaikwad wrote:
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] clk: tegra: fix clk_out parents list
@ 2013-05-28 15:16     ` Stephen Warren
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2013-05-28 15:16 UTC (permalink / raw)
  To: linux-arm-kernel

On 05/27/2013 01:54 AM, Prashant Gaikwad wrote:
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.

Acked-by: Stephen Warren <swarren@nvidia.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] clk: tegra: fix clk_out parents list
  2013-05-27  7:54 ` Prashant Gaikwad
@ 2013-05-31 19:23     ` Mike Turquette
  -1 siblings, 0 replies; 8+ messages in thread
From: Mike Turquette @ 2013-05-31 19:23 UTC (permalink / raw)
  To: swarren-3lzwWm7+Weoh9ZMKESR00Q, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Prashant Gaikwad

Quoting Prashant Gaikwad (2013-05-27 00:54:39)
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.
> 
> Signed-off-by: Prashant Gaikwad <pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Taken into clk-next since this fix doesn't appear to fix anything.

Thanks,
Mike

> ---
>  drivers/clk/tegra/clk-tegra114.c |    4 ++--
>  drivers/clk/tegra/clk-tegra30.c  |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> index e0ee077..6d438bb 100644
> --- a/drivers/clk/tegra/clk-tegra114.c
> +++ b/drivers/clk/tegra/clk-tegra114.c
> @@ -1602,7 +1602,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
>  
>         /* clk_out_2 */
>         clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out2_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
>                                &clk_out_lock);
>         clks[clk_out_2_mux] = clk;
> @@ -1614,7 +1614,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
>  
>         /* clk_out_3 */
>         clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out3_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
>                                &clk_out_lock);
>         clks[clk_out_3_mux] = clk;
> diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
> index 985ad69..b62e140 100644
> --- a/drivers/clk/tegra/clk-tegra30.c
> +++ b/drivers/clk/tegra/clk-tegra30.c
> @@ -1223,7 +1223,7 @@ static void __init tegra30_pmc_clk_init(void)
>  
>         /* clk_out_2 */
>         clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out2_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
>                                &clk_out_lock);
>         clk = clk_register_gate(NULL, "clk_out_2", "clk_out_2_mux", 0,
> @@ -1234,7 +1234,7 @@ static void __init tegra30_pmc_clk_init(void)
>  
>         /* clk_out_3 */
>         clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out3_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
>                                &clk_out_lock);
>         clk = clk_register_gate(NULL, "clk_out_3", "clk_out_3_mux", 0,
> -- 
> 1.7.4.1

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] clk: tegra: fix clk_out parents list
@ 2013-05-31 19:23     ` Mike Turquette
  0 siblings, 0 replies; 8+ messages in thread
From: Mike Turquette @ 2013-05-31 19:23 UTC (permalink / raw)
  To: linux-arm-kernel

Quoting Prashant Gaikwad (2013-05-27 00:54:39)
> Number of parents for clk_out_2 and clk_out_3 was incorrectly set
> to clk_out1_parents. Even though it did not break anything since the
> size was same better to fix.
> 
> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>

Taken into clk-next since this fix doesn't appear to fix anything.

Thanks,
Mike

> ---
>  drivers/clk/tegra/clk-tegra114.c |    4 ++--
>  drivers/clk/tegra/clk-tegra30.c  |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> index e0ee077..6d438bb 100644
> --- a/drivers/clk/tegra/clk-tegra114.c
> +++ b/drivers/clk/tegra/clk-tegra114.c
> @@ -1602,7 +1602,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
>  
>         /* clk_out_2 */
>         clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out2_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
>                                &clk_out_lock);
>         clks[clk_out_2_mux] = clk;
> @@ -1614,7 +1614,7 @@ static void __init tegra114_pmc_clk_init(void __iomem *pmc_base)
>  
>         /* clk_out_3 */
>         clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out3_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
>                                &clk_out_lock);
>         clks[clk_out_3_mux] = clk;
> diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
> index 985ad69..b62e140 100644
> --- a/drivers/clk/tegra/clk-tegra30.c
> +++ b/drivers/clk/tegra/clk-tegra30.c
> @@ -1223,7 +1223,7 @@ static void __init tegra30_pmc_clk_init(void)
>  
>         /* clk_out_2 */
>         clk = clk_register_mux(NULL, "clk_out_2_mux", clk_out2_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out2_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 14, 3, 0,
>                                &clk_out_lock);
>         clk = clk_register_gate(NULL, "clk_out_2", "clk_out_2_mux", 0,
> @@ -1234,7 +1234,7 @@ static void __init tegra30_pmc_clk_init(void)
>  
>         /* clk_out_3 */
>         clk = clk_register_mux(NULL, "clk_out_3_mux", clk_out3_parents,
> -                              ARRAY_SIZE(clk_out1_parents), 0,
> +                              ARRAY_SIZE(clk_out3_parents), 0,
>                                pmc_base + PMC_CLK_OUT_CNTRL, 22, 3, 0,
>                                &clk_out_lock);
>         clk = clk_register_gate(NULL, "clk_out_3", "clk_out_3_mux", 0,
> -- 
> 1.7.4.1

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-05-31 19:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-27  7:54 [PATCH] clk: tegra: fix clk_out parents list Prashant Gaikwad
2013-05-27  7:54 ` Prashant Gaikwad
     [not found] ` <1369641279-6894-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-27 14:55   ` Thierry Reding
2013-05-27 14:55     ` Thierry Reding
2013-05-28 15:16   ` Stephen Warren
2013-05-28 15:16     ` Stephen Warren
2013-05-31 19:23   ` Mike Turquette
2013-05-31 19:23     ` Mike Turquette

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.