All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Gao <bin.gao@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: i2c: introduce i2c helper i2c_find_client_by_name()
Date: Thu, 6 Jun 2013 14:26:20 -0700	[thread overview]
Message-ID: <20130606212620.GA13620@bingao-desk1.fm.intel.com> (raw)
In-Reply-To: <CAHp75VcYgpUVpOnKOzkYoZXbEPO_0QG7=WUXza55wpOyRwcKCA@mail.gmail.com>

With v4l2, the camera sensor i2c devices are taken over by v4l2 master
driver, i.e. ISP driver, and are not expected to be accessed from
user sapce by ioctl. So ISP driver has to register them by itself to
get all related information for further communication. Please check
v4l2_i2c_new_subdev_board() in drivers/media/video/v4l2-common.c for details.

The platform code can definitely disallow calling i2c_register_board_info()
to register them but keep the i2c devices list and then let ISP driver register
them. But, problems come when a single kernel is going to run on two platforms
- one platform has ACPI5 and the other has SFI. The dynamic unregister and then
register based on this new helper will not have dependency on firmware interface -
the same platform code will work for all platforms.

On Thu, Jun 06, 2013 at 11:32:06PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 6, 2013 at 9:33 PM, Bin Gao <bin.gao@linux.intel.com> wrote:
> > There is a requirement to get the i2c_client pointer dynamically without
> > knowing the bus and slave address. But we do know the client name,
> > i.e. the name in the i2c_board_info. This patch is to fit this requirement.
> >
> > A good example is that an ISP(Imaging Signal Processor) driver needs
> > register i2c camera sensor devices via v4l2, so it has to unregister
> > all i2c clients that were previously registered by calling
> > i2c_register_board_info(), and then re-register. For this case we
> > can use this helper to get i2c_client by passing the client name.
> 
> Why ISP driver would like to register sensor drivers in the first place?
> That seems the task of platform code, or DT, or ACPI5
> 
> Why do you need to re-register them at run time?
> 
> --
> With Best Regards,
> Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: Bin Gao <bin.gao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Andy Shevchenko
	<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: i2c: introduce i2c helper i2c_find_client_by_name()
Date: Thu, 6 Jun 2013 14:26:20 -0700	[thread overview]
Message-ID: <20130606212620.GA13620@bingao-desk1.fm.intel.com> (raw)
In-Reply-To: <CAHp75VcYgpUVpOnKOzkYoZXbEPO_0QG7=WUXza55wpOyRwcKCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

With v4l2, the camera sensor i2c devices are taken over by v4l2 master
driver, i.e. ISP driver, and are not expected to be accessed from
user sapce by ioctl. So ISP driver has to register them by itself to
get all related information for further communication. Please check
v4l2_i2c_new_subdev_board() in drivers/media/video/v4l2-common.c for details.

The platform code can definitely disallow calling i2c_register_board_info()
to register them but keep the i2c devices list and then let ISP driver register
them. But, problems come when a single kernel is going to run on two platforms
- one platform has ACPI5 and the other has SFI. The dynamic unregister and then
register based on this new helper will not have dependency on firmware interface -
the same platform code will work for all platforms.

On Thu, Jun 06, 2013 at 11:32:06PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 6, 2013 at 9:33 PM, Bin Gao <bin.gao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> > There is a requirement to get the i2c_client pointer dynamically without
> > knowing the bus and slave address. But we do know the client name,
> > i.e. the name in the i2c_board_info. This patch is to fit this requirement.
> >
> > A good example is that an ISP(Imaging Signal Processor) driver needs
> > register i2c camera sensor devices via v4l2, so it has to unregister
> > all i2c clients that were previously registered by calling
> > i2c_register_board_info(), and then re-register. For this case we
> > can use this helper to get i2c_client by passing the client name.
> 
> Why ISP driver would like to register sensor drivers in the first place?
> That seems the task of platform code, or DT, or ACPI5
> 
> Why do you need to re-register them at run time?
> 
> --
> With Best Regards,
> Andy Shevchenko

  reply	other threads:[~2013-06-06 21:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 18:33 i2c: introduce i2c helper i2c_find_client_by_name() Bin Gao
2013-06-06 18:33 ` Bin Gao
2013-06-06 20:32 ` Andy Shevchenko
2013-06-06 20:32   ` Andy Shevchenko
2013-06-06 21:26   ` Bin Gao [this message]
2013-06-06 21:26     ` Bin Gao
2013-06-09 19:53     ` Andy Shevchenko
2013-06-09 19:53       ` Andy Shevchenko
2013-06-11 17:11       ` Bin Gao
2013-06-14  7:29         ` Andy Shevchenko
2013-06-14  7:29           ` Andy Shevchenko
2013-06-14 19:00           ` Bin Gao
2013-06-14 19:00             ` Bin Gao
2013-06-19 10:13             ` Wolfram Sang
2013-06-19 10:13               ` Wolfram Sang
2013-06-22  0:27               ` Bin Gao
2013-06-22  0:27                 ` Bin Gao
2013-06-23 12:43                 ` Wolfram Sang
2013-06-23 12:43                   ` Wolfram Sang
2013-07-05 19:55 ` Mark Brown
2013-07-12 10:54   ` Andy Shevchenko
2013-07-12 10:54     ` Andy Shevchenko
2013-07-12 11:00     ` Wolfram Sang
2013-07-12 11:00       ` Wolfram Sang
2013-07-12 11:02       ` Laurent Pinchart
2013-07-12 11:02         ` Laurent Pinchart
2013-07-12 11:29       ` Andy Shevchenko
2013-07-12 11:29         ` Andy Shevchenko
2013-07-12 11:35         ` Laurent Pinchart
2013-07-12 11:35           ` Laurent Pinchart
2013-07-12 11:56           ` Andy Shevchenko
2013-07-12 11:56             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606212620.GA13620@bingao-desk1.fm.intel.com \
    --to=bin.gao@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.