From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v9 07/14] gst1-plugins-base: add gstreamer1 base plugins
Date: Fri, 7 Jun 2013 11:47:01 +0200 [thread overview]
Message-ID: <20130607114701.0f249b68@skate> (raw)
In-Reply-To: <1369931437-12445-8-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Thu, 30 May 2013 11:30:30 -0500, Spenser Gilliland wrote:
> diff --git a/package/multimedia/gst1-plugins-base/Config.in b/package/multimedia/gst1-plugins-base/Config.in
> new file mode 100644
> index 0000000..2a95846
> --- /dev/null
> +++ b/package/multimedia/gst1-plugins-base/Config.in
> @@ -0,0 +1,106 @@
> +menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE
> + bool "gst1-plugins-base"
> + depends on BR2_PACKAGE_GSTREAMER1
> + select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
> + select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
> + select BR2_PACKAGE_XLIB_LIBXV if BR2_PACKAGE_XORG7
I know it's done this way in the existing gst-plugins-base, but I find
it odd that X.org support is enabled automagically, while the other
plugins have sub-options below.
What do others think?
> diff --git a/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk
> new file mode 100644
> index 0000000..22676d6
> --- /dev/null
> +++ b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk
> @@ -0,0 +1,201 @@
> +#############################################################
> +#
> +# gst1-plugins-base
> +#
> +#############################################################
Missing empty new line between header and variables.
Also ensure the headers lines contain 80 '#' characters, as per the new
rule.
> +GST1_PLUGINS_BASE_VERSION = 1.0.7
> +GST1_PLUGINS_BASE_SOURCE = gst-plugins-base-$(GST1_PLUGINS_BASE_VERSION).tar.xz
> +GST1_PLUGINS_BASE_SITE = http://gstreamer.freedesktop.org/src/gst-plugins-base
> +GST1_PLUGINS_BASE_INSTALL_STAGING = YES
license + license files.
> +
> +# freetype is only used by examples, but if it is not found
> +# and the host has a freetype-config script, then the host
> +# include dirs are added to the search path causing trouble
> +GST1_PLUGINS_BASE_CONF_ENV =
> + FT2_CONFIG=/bin/false \
> + ac_cv_header_stdint_t="stdint.h"
> +
> +GST1_PLUGINS_BASE_CONF_OPT = \
> + --disable-examples \
> + --disable-oggtest \
> + --disable-vorbistest \
> + --disable-freetypetest \
> + --disable-valgrind \
> + --disable-debug
> +
> +# Options which require currently unpackaged libraries
> +GST1_PLUGINS_BASE_CONF_OPT += \
> + --disable-cdparanoia \
> + --disable-libvisual \
> + --disable-iso-codes
Only one tab when indenting.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-06-07 9:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 16:30 [Buildroot] [PATCH v9 00/14] add Gstreamer 1.X for gst-omx support Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 01/14] libglib2: Bump libglib2 to 2.36.1 Spenser Gilliland
2013-06-07 9:09 ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 02/14] gdk-pixbuf: bump to version 2.28.1 Spenser Gilliland
2013-06-07 9:10 ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 03/14] libgtk2: bump to version 2.24.18 Spenser Gilliland
2013-05-30 16:48 ` Thomas Petazzoni
2013-05-30 17:06 ` Spenser Gilliland
2013-06-07 9:31 ` Peter Korsgaard
2013-06-07 15:08 ` Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 04/14] libsoup: bump to version 2.43.1 Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 05/14] webkit: bump to version 1.9.6 Spenser Gilliland
2013-05-30 16:45 ` Thomas Petazzoni
2013-05-30 16:55 ` Spenser Gilliland
2013-05-31 20:06 ` Samuel Martin
2013-05-30 16:30 ` [Buildroot] [PATCH v9 06/14] gstreamer1: Add gstreamer version 1.0.7 package Spenser Gilliland
2013-06-07 9:42 ` Thomas Petazzoni
2013-05-30 16:30 ` [Buildroot] [PATCH v9 07/14] gst1-plugins-base: add gstreamer1 base plugins Spenser Gilliland
2013-06-07 9:47 ` Thomas Petazzoni [this message]
2013-05-30 16:30 ` [Buildroot] [PATCH v9 08/14] gst1-plugins-good: add gstreamer1 good plugins Spenser Gilliland
2013-05-31 20:10 ` Samuel Martin
2013-05-30 16:30 ` [Buildroot] [PATCH v9 09/14] gst1-plugins-bad: add gstreamer1 bad plugins Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 10/14] gst1-plugins-ugly: add gstreamer1 ugly plugins Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 11/14] libvpx: new package libvpx Spenser Gilliland
2013-05-30 19:26 ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 12/14] gst1-plugins-good: add libvpx support Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 13/14] libopenmax: Add libopenmax virtual package Spenser Gilliland
2013-05-30 19:34 ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 14/14] gst-omx: add gst-omx package Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607114701.0f249b68@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.