All of lore.kernel.org
 help / color / mirror / Atom feed
From: Spenser Gilliland <spenser@gillilanding.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v9 03/14] libgtk2: bump to version 2.24.18
Date: Thu, 30 May 2013 12:06:13 -0500	[thread overview]
Message-ID: <CAEBucnD_Og0do1jj5AhSPCY=nfbfKHMOS7PAO2wPfUSc=g--jA@mail.gmail.com> (raw)
In-Reply-To: <20130530184859.3ace3c42@skate>

Thomas,

> Please mention explicitly in the commit log that you are dropping
> DirectFB support for good. Generally speaking, your commit log would
> need to be a little bit more detailed about what you're doing. No need
> to give gazillion of details, but highlighting the important changes is
> good when the bump is not simply a mechanical bump.
>
> Also, I believe more parts of libgtk2.mk can be removed if you remove
> DirectFB support:
>
> ifeq ($(BR2_PACKAGE_DIRECTFB),y)
>         LIBGTK2_CONF_OPT += --with-gdktarget=directfb
>         LIBGTK2_DEPENDENCIES += directfb
> endif
>
> and also all the code that was enclosed in a ifeq
> ($(BR2_PACKAGE_XORG7),y) can now go out of this conditional.

This has been fixed in the newest version.

> Or maybe you want to do two separate patches: one that drops the
> DirectFB support, and then one that bumps to 2.24.18.

I've update the patch title to

libgtk2: bump to version 2.24.18 and drop DirectFB

the commit message states.

 * Drop DirectFB support from libgtk2
 * bump libgtk2 to version 2.24.18

> Thanks!

Thanks,
Spenser


--
Spenser Gilliland
Computer Engineer
Doctoral Candidate

  reply	other threads:[~2013-05-30 17:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 16:30 [Buildroot] [PATCH v9 00/14] add Gstreamer 1.X for gst-omx support Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 01/14] libglib2: Bump libglib2 to 2.36.1 Spenser Gilliland
2013-06-07  9:09   ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 02/14] gdk-pixbuf: bump to version 2.28.1 Spenser Gilliland
2013-06-07  9:10   ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 03/14] libgtk2: bump to version 2.24.18 Spenser Gilliland
2013-05-30 16:48   ` Thomas Petazzoni
2013-05-30 17:06     ` Spenser Gilliland [this message]
2013-06-07  9:31   ` Peter Korsgaard
2013-06-07 15:08     ` Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 04/14] libsoup: bump to version 2.43.1 Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 05/14] webkit: bump to version 1.9.6 Spenser Gilliland
2013-05-30 16:45   ` Thomas Petazzoni
2013-05-30 16:55     ` Spenser Gilliland
2013-05-31 20:06   ` Samuel Martin
2013-05-30 16:30 ` [Buildroot] [PATCH v9 06/14] gstreamer1: Add gstreamer version 1.0.7 package Spenser Gilliland
2013-06-07  9:42   ` Thomas Petazzoni
2013-05-30 16:30 ` [Buildroot] [PATCH v9 07/14] gst1-plugins-base: add gstreamer1 base plugins Spenser Gilliland
2013-06-07  9:47   ` Thomas Petazzoni
2013-05-30 16:30 ` [Buildroot] [PATCH v9 08/14] gst1-plugins-good: add gstreamer1 good plugins Spenser Gilliland
2013-05-31 20:10   ` Samuel Martin
2013-05-30 16:30 ` [Buildroot] [PATCH v9 09/14] gst1-plugins-bad: add gstreamer1 bad plugins Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 10/14] gst1-plugins-ugly: add gstreamer1 ugly plugins Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 11/14] libvpx: new package libvpx Spenser Gilliland
2013-05-30 19:26   ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 12/14] gst1-plugins-good: add libvpx support Spenser Gilliland
2013-05-30 16:30 ` [Buildroot] [PATCH v9 13/14] libopenmax: Add libopenmax virtual package Spenser Gilliland
2013-05-30 19:34   ` Peter Korsgaard
2013-05-30 16:30 ` [Buildroot] [PATCH v9 14/14] gst-omx: add gst-omx package Spenser Gilliland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEBucnD_Og0do1jj5AhSPCY=nfbfKHMOS7PAO2wPfUSc=g--jA@mail.gmail.com' \
    --to=spenser@gillilanding.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.