* [lm-sensors] [PATCH] sensors-detect: Drop outdated comment about MAX1617 and LM84 detection
@ 2013-06-07 17:47 Guenter Roeck
2013-06-07 18:39 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2013-06-07 17:47 UTC (permalink / raw)
To: lm-sensors
Drop comment that additional checks for MAX1617 and LM84 are not
done in adm1021 driver, as this is no longer correct.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
prog/detect/sensors-detect | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/prog/detect/sensors-detect b/prog/detect/sensors-detect
index 19bfe1a..518e5d8 100755
--- a/prog/detect/sensors-detect
+++ b/prog/detect/sensors-detect
@@ -5534,8 +5534,7 @@ sub adm1021_detect
# Extra checks for MAX1617 and LM84, since those are often misdetected.
# We verify several assertions (6 for the MAX1617, 4 for the LM84) and
- # discard the chip if any fail. Note that these checks are not done
- # by the adm1021 driver.
+ # discard the chip if any fail.
if ($chip = 2 || $chip = 5) {
my $lte = i2c_smbus_read_byte_data($file, 0x00);
my $rte = i2c_smbus_read_byte_data($file, 0x01);
--
1.7.9.7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [lm-sensors] [PATCH] sensors-detect: Drop outdated comment about MAX1617 and LM84 detection
2013-06-07 17:47 [lm-sensors] [PATCH] sensors-detect: Drop outdated comment about MAX1617 and LM84 detection Guenter Roeck
@ 2013-06-07 18:39 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2013-06-07 18:39 UTC (permalink / raw)
To: lm-sensors
On Fri, 7 Jun 2013 10:47:35 -0700, Guenter Roeck wrote:
> Drop comment that additional checks for MAX1617 and LM84 are not
> done in adm1021 driver, as this is no longer correct.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> prog/detect/sensors-detect | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/prog/detect/sensors-detect b/prog/detect/sensors-detect
> index 19bfe1a..518e5d8 100755
> --- a/prog/detect/sensors-detect
> +++ b/prog/detect/sensors-detect
> @@ -5534,8 +5534,7 @@ sub adm1021_detect
>
> # Extra checks for MAX1617 and LM84, since those are often misdetected.
> # We verify several assertions (6 for the MAX1617, 4 for the LM84) and
> - # discard the chip if any fail. Note that these checks are not done
> - # by the adm1021 driver.
> + # discard the chip if any fail.
> if ($chip = 2 || $chip = 5) {
> my $lte = i2c_smbus_read_byte_data($file, 0x00);
> my $rte = i2c_smbus_read_byte_data($file, 0x01);
Yep, please just commit.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-07 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-07 17:47 [lm-sensors] [PATCH] sensors-detect: Drop outdated comment about MAX1617 and LM84 detection Guenter Roeck
2013-06-07 18:39 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.