build warning on 32-bit

build warning on 32-bit

[Dave Airlie]

  CC [M]  drivers/gpu/drm/i915/i915_gem.o
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
‘i915_gem_object_bind_to_gtt’:
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
type ‘size_t’ [-Wformat]
  CC [M]  drivers/gpu/drm/i915/i915_gem_context.o

commit a36689cb771f06819c3fa8139c3d3716dfdf6d53
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue May 21 16:58:49 2013 +0100

    drm/i915: Be more informative when reporting "too large for aperture" error

    This should help debugging the truly unexpected cases where it occurs -
    in particular to see which value is garbage.

    References: https://bugzilla.kernel.org/show_bug.cgi?id=58511
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    [danvet: s/%ld/%zd/ as spotted by Wu Fengguang's autobuilder.]
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Dave.

Re: build warning on 32-bit

[Ville Syrjälä]

On Tue, Jun 11, 2013 at 08:55:03AM +1000, Dave Airlie wrote:
>   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
> ‘i915_gem_object_bind_to_gtt’:
> /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
> format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
> type ‘size_t’ [-Wformat]
>   CC [M]  drivers/gpu/drm/i915/i915_gem_context.o

I think Jani had a fix for this one:
https://patchwork.kernel.org/patch/2686801/

> 
> commit a36689cb771f06819c3fa8139c3d3716dfdf6d53
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Tue May 21 16:58:49 2013 +0100
> 
>     drm/i915: Be more informative when reporting "too large for aperture" error
> 
>     This should help debugging the truly unexpected cases where it occurs -
>     in particular to see which value is garbage.
> 
>     References: https://bugzilla.kernel.org/show_bug.cgi?id=58511
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     [danvet: s/%ld/%zd/ as spotted by Wu Fengguang's autobuilder.]
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Dave.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: build warning on 32-bit

[Daniel Vetter]

On Tue, Jun 11, 2013 at 10:03:06AM +0300, Ville Syrjälä wrote:
> On Tue, Jun 11, 2013 at 08:55:03AM +1000, Dave Airlie wrote:
> >   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
> > ‘i915_gem_object_bind_to_gtt’:
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
> > format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
> > type ‘size_t’ [-Wformat]
> >   CC [M]  drivers/gpu/drm/i915/i915_gem_context.o
> 
> I think Jani had a fix for this one:
> https://patchwork.kernel.org/patch/2686801/

Yeah, I apparently sucked at doing the printf fixup :(

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> on the patch to shut up
the warning in drm-next.
-Daniel

> 
> > 
> > commit a36689cb771f06819c3fa8139c3d3716dfdf6d53
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date:   Tue May 21 16:58:49 2013 +0100
> > 
> >     drm/i915: Be more informative when reporting "too large for aperture" error
> > 
> >     This should help debugging the truly unexpected cases where it occurs -
> >     in particular to see which value is garbage.
> > 
> >     References: https://bugzilla.kernel.org/show_bug.cgi?id=58511
> >     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >     [danvet: s/%ld/%zd/ as spotted by Wu Fengguang's autobuilder.]
> >     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > Dave.
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Ville Syrjälä
> Intel OTC

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: build warning on 32-bit

[Chris Wilson]

On Tue, Jun 11, 2013 at 10:03:06AM +0300, Ville Syrjälä wrote:
> On Tue, Jun 11, 2013 at 08:55:03AM +1000, Dave Airlie wrote:
> >   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
> > ‘i915_gem_object_bind_to_gtt’:
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
> > format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
> > type ‘size_t’ [-Wformat]
> >   CC [M]  drivers/gpu/drm/i915/i915_gem_context.o
> 
> I think Jani had a fix for this one:
> https://patchwork.kernel.org/patch/2686801/

It is fixing the wrong thing, imo. The issue is that we have a random mix
of types that we need to sort out. (Here is a prime example, the
conditional switching between gtt.total and gtt.mappable_end, both
describing limits in the GTT have size_t and unsigned long respectively.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: build warning on 32-bit

[Daniel Vetter]

On Tue, Jun 11, 2013 at 08:39:16AM +0100, Chris Wilson wrote:
> On Tue, Jun 11, 2013 at 10:03:06AM +0300, Ville Syrjälä wrote:
> > On Tue, Jun 11, 2013 at 08:55:03AM +1000, Dave Airlie wrote:
> > >   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> > > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
> > > ‘i915_gem_object_bind_to_gtt’:
> > > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
> > > format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
> > > type ‘size_t’ [-Wformat]
> > >   CC [M]  drivers/gpu/drm/i915/i915_gem_context.o
> > 
> > I think Jani had a fix for this one:
> > https://patchwork.kernel.org/patch/2686801/
> 
> It is fixing the wrong thing, imo. The issue is that we have a random mix
> of types that we need to sort out. (Here is a prime example, the
> conditional switching between gtt.total and gtt.mappable_end, both
> describing limits in the GTT have size_t and unsigned long respectively.)

Agreed, but since I've bitched around about that on irc I haven't seen
patches float around yet to fix it. So duct-tape looks like a decent
solution for now ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel