From: Oleg Nesterov <oleg@redhat.com> To: Kent Overstreet <koverstreet@google.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, akpm@linux-foundation.org, Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux-foundation.org>, Ingo Molnar <mingo@redhat.com> Subject: Re: [PATCH 17/21] Percpu tag allocator Date: Tue, 11 Jun 2013 19:42:38 +0200 [thread overview] Message-ID: <20130611174238.GA8139@redhat.com> (raw) In-Reply-To: <20130610232030.GA6151@google.com> On 06/10, Kent Overstreet wrote: > > On Wed, May 15, 2013 at 05:41:21PM +0200, Oleg Nesterov wrote: > > > > Do you really think that, say, > > > > unsigned tag_alloc(struct tag_pool *pool, bool wait) > > { > > struct tag_cpu_freelist *tags; > > unsigned ret = 0; > > retry: > > tags = get_cpu_ptr(pool->tag_cpu); > > local_irq_disable(); > > if (!tags->nr_free && pool->nr_free) { > > spin_lock(&pool->wq.lock); > > if (pool->nr_free) > > move_tags(...); > > spin_unlock(&pool->wq.lock); > > } > > > > if (tags->nr_free) > > ret = tags->free[--tags->nr_free]; > > local_irq_enable(); > > put_cpu_var(pool->tag_cpu); > > > > if (ret || !wait) > > return ret; > > > > __wait_event(&pool->wq, pool->nr_free); > > goto retry; > > } > > > > will be much slower? > > The overhead from doing nested irqsave/restore() sucks. I've had it bite > me hard with the recent aio work. Not sure I understand... Only __wait_event() does irqsave/restore and we are going to sleep anyway. > But screw it, it's not going to matter > that much here. Yes. And, imho, even if we need some optimizations here, it would be better to make a separate patch backed by the numbers or at least the detailed explanation. > > Question. tag_free() does move_tags+wakeup if nr_free = pool->watermark * 2. > > Perhaps it should should also take waitqueue_active() into account ? > > tag_alloc() can sleep more than necessary, it seems. > > No. > > By "sleeping more than necessary" you mean sleeping when there's tags > available on other percpu freelists. Yes, > That's just unavoidable if the thing's to be percpu - efficient use of > available tags requires global knowledge. Sleeping less would require > more global cacheline contention, and would defeat the purpose of this > code. Yes, yes, I understand, there is a tradeoff. Just it is still not clear to me what would be better "in practice"... So, > So when you're deciding how many tag structs to allocate, you just > double the number you'd allocate otherwise when you're using this code. I am not sure this is really needed. But OK, I see your point, thanks. Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com> To: Kent Overstreet <koverstreet@google.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, akpm@linux-foundation.org, Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux-foundation.org>, Ingo Molnar <mingo@redhat.com> Subject: Re: [PATCH 17/21] Percpu tag allocator Date: Tue, 11 Jun 2013 19:42:38 +0200 [thread overview] Message-ID: <20130611174238.GA8139@redhat.com> (raw) In-Reply-To: <20130610232030.GA6151@google.com> On 06/10, Kent Overstreet wrote: > > On Wed, May 15, 2013 at 05:41:21PM +0200, Oleg Nesterov wrote: > > > > Do you really think that, say, > > > > unsigned tag_alloc(struct tag_pool *pool, bool wait) > > { > > struct tag_cpu_freelist *tags; > > unsigned ret = 0; > > retry: > > tags = get_cpu_ptr(pool->tag_cpu); > > local_irq_disable(); > > if (!tags->nr_free && pool->nr_free) { > > spin_lock(&pool->wq.lock); > > if (pool->nr_free) > > move_tags(...); > > spin_unlock(&pool->wq.lock); > > } > > > > if (tags->nr_free) > > ret = tags->free[--tags->nr_free]; > > local_irq_enable(); > > put_cpu_var(pool->tag_cpu); > > > > if (ret || !wait) > > return ret; > > > > __wait_event(&pool->wq, pool->nr_free); > > goto retry; > > } > > > > will be much slower? > > The overhead from doing nested irqsave/restore() sucks. I've had it bite > me hard with the recent aio work. Not sure I understand... Only __wait_event() does irqsave/restore and we are going to sleep anyway. > But screw it, it's not going to matter > that much here. Yes. And, imho, even if we need some optimizations here, it would be better to make a separate patch backed by the numbers or at least the detailed explanation. > > Question. tag_free() does move_tags+wakeup if nr_free = pool->watermark * 2. > > Perhaps it should should also take waitqueue_active() into account ? > > tag_alloc() can sleep more than necessary, it seems. > > No. > > By "sleeping more than necessary" you mean sleeping when there's tags > available on other percpu freelists. Yes, > That's just unavoidable if the thing's to be percpu - efficient use of > available tags requires global knowledge. Sleeping less would require > more global cacheline contention, and would defeat the purpose of this > code. Yes, yes, I understand, there is a tradeoff. Just it is still not clear to me what would be better "in practice"... So, > So when you're deciding how many tag structs to allocate, you just > double the number you'd allocate otherwise when you're using this code. I am not sure this is really needed. But OK, I see your point, thanks. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2013-06-11 17:46 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-14 1:18 AIO refactoring/performance improvements/cancellation Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 01/21] aio: fix kioctx not being freed after cancellation at exit time Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 02/21] aio: reqs_active -> reqs_available Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 03/21] aio: percpu reqs_available Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 04/21] Generic percpu refcounting Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 13:51 ` Oleg Nesterov 2013-05-14 13:51 ` Oleg Nesterov 2013-05-15 8:21 ` Kent Overstreet 2013-05-15 8:21 ` Kent Overstreet 2013-05-14 14:59 ` Tejun Heo 2013-05-14 14:59 ` Tejun Heo 2013-05-14 15:28 ` Oleg Nesterov 2013-05-14 15:28 ` Oleg Nesterov 2013-05-15 9:00 ` Kent Overstreet 2013-05-15 9:00 ` Kent Overstreet 2013-05-15 8:58 ` Kent Overstreet 2013-05-15 8:58 ` Kent Overstreet 2013-05-15 17:37 ` Tejun Heo 2013-05-15 17:37 ` Tejun Heo 2013-05-28 23:47 ` Kent Overstreet 2013-05-28 23:47 ` Kent Overstreet 2013-05-29 1:11 ` Tejun Heo 2013-05-29 1:11 ` Tejun Heo 2013-05-29 4:59 ` Rusty Russell 2013-05-29 4:59 ` Rusty Russell 2013-05-31 20:12 ` Kent Overstreet 2013-05-31 20:12 ` Kent Overstreet 2013-05-14 21:59 ` Tejun Heo 2013-05-14 21:59 ` Tejun Heo 2013-05-14 22:15 ` Tejun Heo 2013-05-14 22:15 ` Tejun Heo 2013-05-15 9:07 ` Kent Overstreet 2013-05-15 9:07 ` Kent Overstreet 2013-05-15 17:56 ` Tejun Heo 2013-05-15 17:56 ` Tejun Heo 2013-05-16 0:26 ` Rusty Russell 2013-05-16 0:26 ` Rusty Russell 2013-05-14 1:18 ` [PATCH 05/21] aio: percpu ioctx refcount Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 06/21] aio: io_cancel() no longer returns the io_event Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 07/21] aio: Don't use ctx->tail unnecessarily Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 08/21] aio: Kill aio_rw_vect_retry() Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 09/21] aio: Kill unneeded kiocb members Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 10/21] aio: Kill ki_users Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 11/21] aio: Kill ki_dtor Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 12/21] aio: convert the ioctx list to radix tree Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 13/21] block: prep work for batch completion Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 14/21] block, aio: batch completion for bios/kiocbs Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 15/21] virtio-blk: convert to batch completion Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 16/21] mtip32xx: " Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 17/21] Percpu tag allocator Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 13:48 ` Oleg Nesterov 2013-05-14 13:48 ` Oleg Nesterov 2013-05-14 14:24 ` Oleg Nesterov 2013-05-14 14:24 ` Oleg Nesterov 2013-05-15 9:34 ` Kent Overstreet 2013-05-15 9:34 ` Kent Overstreet 2013-05-15 9:25 ` Kent Overstreet 2013-05-15 9:25 ` Kent Overstreet 2013-05-15 15:41 ` Oleg Nesterov 2013-05-15 15:41 ` Oleg Nesterov 2013-05-15 16:10 ` Oleg Nesterov 2013-05-15 16:10 ` Oleg Nesterov 2013-06-10 23:20 ` Kent Overstreet 2013-06-10 23:20 ` Kent Overstreet 2013-06-11 17:42 ` Oleg Nesterov [this message] 2013-06-11 17:42 ` Oleg Nesterov 2013-05-14 15:03 ` Tejun Heo 2013-05-14 15:03 ` Tejun Heo 2013-05-15 20:19 ` Andi Kleen 2013-05-15 20:19 ` Andi Kleen 2013-05-14 1:18 ` [PATCH 18/21] aio: Allow cancellation without a cancel callback, new kiocb lookup Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 19/21] aio/usb: Update cancellation for new synchonization Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 20/21] direct-io: Set dio->io_error directly Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-14 1:18 ` [PATCH 21/21] block: Bio cancellation Kent Overstreet 2013-05-14 1:18 ` Kent Overstreet 2013-05-15 17:52 ` Jens Axboe 2013-05-15 17:52 ` Jens Axboe 2013-05-15 19:29 ` Kent Overstreet 2013-05-15 19:29 ` Kent Overstreet 2013-05-15 20:01 ` Jens Axboe 2013-05-15 20:01 ` Jens Axboe 2013-05-31 22:52 ` Kent Overstreet 2013-05-31 22:52 ` Kent Overstreet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130611174238.GA8139@redhat.com \ --to=oleg@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux-foundation.org \ --cc=koverstreet@google.com \ --cc=linux-aio@kvack.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.