From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>Peter De
Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: tegra: fix pllre initilization
Date: Tue, 11 Jun 2013 17:45:37 -0700 [thread overview]
Message-ID: <20130612004537.8816.13976@quantum> (raw)
In-Reply-To: <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Quoting Peter De Schrijver (2013-06-05 07:21:46)
> The PLLRE flags weren't set correctly. Fixed in this patch.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Taken into clk-next.
Thanks,
Mike
> ---
> drivers/clk/tegra/clk-pll.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 4293643..197074a 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1424,7 +1424,7 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> struct tegra_clk_pll *pll;
> struct clk *clk;
>
> - pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
> + pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_LOCK_MISC;
> pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
> freq_table, lock);
> if (IS_ERR(pll))
> @@ -1451,7 +1451,6 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> val &= ~BIT(29);
> pll_writel_misc(val, pll);
>
> - pll_flags |= TEGRA_PLL_LOCK_MISC;
> clk = _tegra_clk_register_pll(pll, name, parent_name, flags,
> &tegra_clk_pllre_ops);
> if (IS_ERR(clk))
> --
> 1.7.7.rc0.72.g4b5ea.dirty
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: tegra: fix pllre initilization
Date: Tue, 11 Jun 2013 17:45:37 -0700 [thread overview]
Message-ID: <20130612004537.8816.13976@quantum> (raw)
In-Reply-To: <1370442111-13215-1-git-send-email-pdeschrijver@nvidia.com>
Quoting Peter De Schrijver (2013-06-05 07:21:46)
> The PLLRE flags weren't set correctly. Fixed in this patch.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Taken into clk-next.
Thanks,
Mike
> ---
> drivers/clk/tegra/clk-pll.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 4293643..197074a 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1424,7 +1424,7 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> struct tegra_clk_pll *pll;
> struct clk *clk;
>
> - pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
> + pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_LOCK_MISC;
> pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
> freq_table, lock);
> if (IS_ERR(pll))
> @@ -1451,7 +1451,6 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> val &= ~BIT(29);
> pll_writel_misc(val, pll);
>
> - pll_flags |= TEGRA_PLL_LOCK_MISC;
> clk = _tegra_clk_register_pll(pll, name, parent_name, flags,
> &tegra_clk_pllre_ops);
> if (IS_ERR(clk))
> --
> 1.7.7.rc0.72.g4b5ea.dirty
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: tegra: fix pllre initilization
Date: Tue, 11 Jun 2013 17:45:37 -0700 [thread overview]
Message-ID: <20130612004537.8816.13976@quantum> (raw)
In-Reply-To: <1370442111-13215-1-git-send-email-pdeschrijver@nvidia.com>
Quoting Peter De Schrijver (2013-06-05 07:21:46)
> The PLLRE flags weren't set correctly. Fixed in this patch.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Taken into clk-next.
Thanks,
Mike
> ---
> drivers/clk/tegra/clk-pll.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 4293643..197074a 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1424,7 +1424,7 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> struct tegra_clk_pll *pll;
> struct clk *clk;
>
> - pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
> + pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_LOCK_MISC;
> pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
> freq_table, lock);
> if (IS_ERR(pll))
> @@ -1451,7 +1451,6 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
> val &= ~BIT(29);
> pll_writel_misc(val, pll);
>
> - pll_flags |= TEGRA_PLL_LOCK_MISC;
> clk = _tegra_clk_register_pll(pll, name, parent_name, flags,
> &tegra_clk_pllre_ops);
> if (IS_ERR(clk))
> --
> 1.7.7.rc0.72.g4b5ea.dirty
next prev parent reply other threads:[~2013-06-12 0:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 14:21 [PATCH] clk: tegra: fix pllre initilization Peter De Schrijver
2013-06-05 14:21 ` Peter De Schrijver
2013-06-05 14:21 ` Peter De Schrijver
[not found] ` <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-05 16:30 ` Stephen Warren
2013-06-05 16:30 ` Stephen Warren
2013-06-05 16:30 ` Stephen Warren
2013-06-12 0:45 ` Mike Turquette [this message]
2013-06-12 0:45 ` Mike Turquette
2013-06-12 0:45 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612004537.8816.13976@quantum \
--to=mturquette-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.