From: Eliezer Tamir <eliezer.tamir@linux.intel.com> To: David Miller <davem@davemloft.net> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jesse Brandeburg <jesse.brandeburg@intel.com>, Don Skidmore <donald.c.skidmore@intel.com>, e1000-devel@lists.sourceforge.net, Willem de Bruijn <willemb@google.com>, Eric Dumazet <erdnetdev@gmail.com>, Ben Hutchings <bhutchings@solarflare.com>, Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>, Eilon Greenstien <eilong@broadcom.com>, Or Gerlitz <or.gerlitz@gmail.com>, Amir Vadai <amirv@mellanox.com>, Alex Rosenbaum <alexr@mellanox.com>, Avner Ben Hanoch <avnerb@mellanox.com>, Or Kehati <ork@mellanox.com>, Eliezer Tamir <eliezer@tamir.org.il> Subject: [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int Date: Wed, 12 Jun 2013 14:20:05 +0300 [thread overview] Message-ID: <20130612112005.19288.81197.stgit@ladj378.jer.intel.com> (raw) In-Reply-To: <20130612111942.19288.12131.stgit@ladj378.jer.intel.com> There is no reason for sysctl_net_ll_poll to be an unsigned long. Change it into an unsigned int. Fix the proc handler. Add a cast in ll_end_time() Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com> --- include/net/ll_poll.h | 5 +++-- net/core/sysctl_net_core.c | 4 ++-- net/socket.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h index bc262f8..d20508d 100644 --- a/include/net/ll_poll.h +++ b/include/net/ll_poll.h @@ -34,7 +34,7 @@ #ifdef CONFIG_NET_LL_RX_POLL struct napi_struct; -extern unsigned long sysctl_net_ll_poll __read_mostly; +extern unsigned int sysctl_net_ll_poll __read_mostly; /* return values from ndo_ll_poll */ #define LL_FLUSH_FAILED -1 @@ -45,7 +45,8 @@ extern unsigned long sysctl_net_ll_poll __read_mostly; static inline cycles_t ll_end_time(void) { - return TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll) + get_cycles(); + return (cycles_t)TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll) + + get_cycles(); } static inline bool sk_valid_ll(struct sock *sk) diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 4b48f39..3c78b75 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -289,9 +289,9 @@ static struct ctl_table net_core_table[] = { { .procname = "low_latency_poll", .data = &sysctl_net_ll_poll, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_doulongvec_minmax + .proc_handler = proc_dointvec }, #endif #endif /* CONFIG_NET */ diff --git a/net/socket.c b/net/socket.c index 21fd29f..caaffa1 100644 --- a/net/socket.c +++ b/net/socket.c @@ -107,7 +107,7 @@ #include <net/ll_poll.h> #ifdef CONFIG_NET_LL_RX_POLL -unsigned long sysctl_net_ll_poll __read_mostly; +unsigned int sysctl_net_ll_poll __read_mostly; EXPORT_SYMBOL_GPL(sysctl_net_ll_poll); #endif
WARNING: multiple messages have this Message-ID (diff)
From: Eliezer Tamir <eliezer.tamir@linux.intel.com> To: David Miller <davem@davemloft.net> Cc: Willem de Bruijn <willemb@google.com>, Or Kehati <ork@mellanox.com>, Or Gerlitz <or.gerlitz@gmail.com>, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, HPA <hpa@zytor.com>, Amir Vadai <amirv@mellanox.com>, linux-kernel@vger.kernel.org, Alex Rosenbaum <alexr@mellanox.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Eliezer Tamir <eliezer@tamir.org.il>, Avner Ben Hanoch <avnerb@mellanox.com>, Andi Kleen <andi@firstfloor.org>, Ben Hutchings <bhutchings@solarflare.com>, Eric Dumazet <erdnetdev@gmail.com>, Eilon Greenstien <eilong@broadcom.com> Subject: [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int Date: Wed, 12 Jun 2013 14:20:05 +0300 [thread overview] Message-ID: <20130612112005.19288.81197.stgit@ladj378.jer.intel.com> (raw) In-Reply-To: <20130612111942.19288.12131.stgit@ladj378.jer.intel.com> There is no reason for sysctl_net_ll_poll to be an unsigned long. Change it into an unsigned int. Fix the proc handler. Add a cast in ll_end_time() Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com> --- include/net/ll_poll.h | 5 +++-- net/core/sysctl_net_core.c | 4 ++-- net/socket.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h index bc262f8..d20508d 100644 --- a/include/net/ll_poll.h +++ b/include/net/ll_poll.h @@ -34,7 +34,7 @@ #ifdef CONFIG_NET_LL_RX_POLL struct napi_struct; -extern unsigned long sysctl_net_ll_poll __read_mostly; +extern unsigned int sysctl_net_ll_poll __read_mostly; /* return values from ndo_ll_poll */ #define LL_FLUSH_FAILED -1 @@ -45,7 +45,8 @@ extern unsigned long sysctl_net_ll_poll __read_mostly; static inline cycles_t ll_end_time(void) { - return TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll) + get_cycles(); + return (cycles_t)TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll) + + get_cycles(); } static inline bool sk_valid_ll(struct sock *sk) diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 4b48f39..3c78b75 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -289,9 +289,9 @@ static struct ctl_table net_core_table[] = { { .procname = "low_latency_poll", .data = &sysctl_net_ll_poll, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_doulongvec_minmax + .proc_handler = proc_dointvec }, #endif #endif /* CONFIG_NET */ diff --git a/net/socket.c b/net/socket.c index 21fd29f..caaffa1 100644 --- a/net/socket.c +++ b/net/socket.c @@ -107,7 +107,7 @@ #include <net/ll_poll.h> #ifdef CONFIG_NET_LL_RX_POLL -unsigned long sysctl_net_ll_poll __read_mostly; +unsigned int sysctl_net_ll_poll __read_mostly; EXPORT_SYMBOL_GPL(sysctl_net_ll_poll); #endif ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-06-12 11:20 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-12 11:19 [PATCH v2 net-next 0/3] net: low latency sockets follow ups Eliezer Tamir 2013-06-12 11:19 ` Eliezer Tamir 2013-06-12 11:19 ` [PATCH v2 net-next 1/3] net: remove NET_LL_RX_POLL config menue Eliezer Tamir 2013-06-12 11:19 ` Eliezer Tamir 2013-06-12 11:20 ` Eliezer Tamir [this message] 2013-06-12 11:20 ` [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int Eliezer Tamir 2013-06-12 12:04 ` Avner Ben Hanoch 2013-06-12 12:04 ` Avner Ben Hanoch 2013-06-12 12:44 ` Eliezer Tamir 2013-06-12 12:44 ` Eliezer Tamir 2013-06-12 11:20 ` [PATCH v2 net-next 3/3] net: add socket option for low latency polling Eliezer Tamir 2013-06-12 11:20 ` Eliezer Tamir 2013-06-12 12:44 ` Eric Dumazet 2013-06-12 12:54 ` Eliezer Tamir 2013-06-12 12:54 ` Eliezer Tamir 2013-06-12 12:58 ` Eliezer Tamir 2013-06-12 13:55 ` Eric Dumazet 2013-06-12 13:55 ` Eric Dumazet 2013-06-12 11:22 ` [PATCH v2 sockperf] sockperf: add SO_LL socketop support Eliezer Tamir 2013-06-12 11:22 ` Eliezer Tamir
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130612112005.19288.81197.stgit@ladj378.jer.intel.com \ --to=eliezer.tamir@linux.intel.com \ --cc=alexr@mellanox.com \ --cc=amirv@mellanox.com \ --cc=andi@firstfloor.org \ --cc=avnerb@mellanox.com \ --cc=bhutchings@solarflare.com \ --cc=davem@davemloft.net \ --cc=donald.c.skidmore@intel.com \ --cc=e1000-devel@lists.sourceforge.net \ --cc=eilong@broadcom.com \ --cc=eliezer@tamir.org.il \ --cc=erdnetdev@gmail.com \ --cc=hpa@zytor.com \ --cc=jesse.brandeburg@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=or.gerlitz@gmail.com \ --cc=ork@mellanox.com \ --cc=willemb@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.