* [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private()
@ 2013-05-14 14:50 Jeff Liu
2013-06-17 21:58 ` Ben Myers
2013-06-17 22:45 ` Ben Myers
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Liu @ 2013-05-14 14:50 UTC (permalink / raw)
To: xfs
From: Jie Liu <jeff.liu@oracle.com>
Commit eab4e633 "xfs: uncached buffer reads need to return an error".
Remove redundant error variable, using the function level error variable
to store bp->b_error instead.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/xfs/xfs_fsops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index 2866b8c..7a99854 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -174,7 +174,7 @@ xfs_growfs_data_private(
if (!bp)
return EIO;
if (bp->b_error) {
- int error = bp->b_error;
+ error = bp->b_error;
xfs_buf_relse(bp);
return error;
}
--
1.7.9.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private()
2013-05-14 14:50 [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private() Jeff Liu
@ 2013-06-17 21:58 ` Ben Myers
2013-06-17 22:45 ` Ben Myers
1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2013-06-17 21:58 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs
On Tue, May 14, 2013 at 10:50:21PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Commit eab4e633 "xfs: uncached buffer reads need to return an error".
>
> Remove redundant error variable, using the function level error variable
> to store bp->b_error instead.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private()
2013-05-14 14:50 [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private() Jeff Liu
2013-06-17 21:58 ` Ben Myers
@ 2013-06-17 22:45 ` Ben Myers
1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2013-06-17 22:45 UTC (permalink / raw)
To: Jeff Liu, g; +Cc: xfs
On Tue, May 14, 2013 at 10:50:21PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Commit eab4e633 "xfs: uncached buffer reads need to return an error".
>
> Remove redundant error variable, using the function level error variable
> to store bp->b_error instead.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-17 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-14 14:50 [PATCH] xfs: Remove redundant error variable from xfs_growfs_data_private() Jeff Liu
2013-06-17 21:58 ` Ben Myers
2013-06-17 22:45 ` Ben Myers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.