All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Zhu Richard-R65037 <r65037@freescale.com>
Cc: Richard Zhu <richard.zhuhongxing@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"jgarzik@pobox.com" <jgarzik@pobox.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [v1 2/3] ata: ahci_platform: enable imx6q ahci sata support
Date: Tue, 18 Jun 2013 10:32:38 +0800	[thread overview]
Message-ID: <20130618023236.GA28384@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D303700@039-SN2MPN1-013.039d.mgd.msft.net>

On Tue, Jun 18, 2013 at 02:19:52AM +0000, Zhu Richard-R65037 wrote:
> Hi Tejun&Shawn:
> Thanks for your comments.
> 
> Hi Tejun:
> I looked through the for-next branch of the libata git-repo, there maybe a merge conflict.
> "
> static const struct of_device_id ahci_of_match[] = { 
>         { .compatible = "snps,spear-ahci", },
>         { .compatible = "snps,exynos5440-ahci", },

This is exactly what I'm concerned about.  We will end up with a huge
match table with all different platform specific compatible strings in
there.  But they're all matching to the same programming model of the
same IP block.  That's not how device tree compatible table works.

>         {}, 
> };
> MODULE_DEVICE_TABLE(of, ahci_of_match);
> "
> 
> How about to re-change the patch, based on for-next branch of the libata git-repo.
> 
Yes, I think the driver part and platform part can go separately.

Shawn


WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [v1 2/3] ata: ahci_platform: enable imx6q ahci sata support
Date: Tue, 18 Jun 2013 10:32:38 +0800	[thread overview]
Message-ID: <20130618023236.GA28384@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D303700@039-SN2MPN1-013.039d.mgd.msft.net>

On Tue, Jun 18, 2013 at 02:19:52AM +0000, Zhu Richard-R65037 wrote:
> Hi Tejun&Shawn:
> Thanks for your comments.
> 
> Hi Tejun:
> I looked through the for-next branch of the libata git-repo, there maybe a merge conflict.
> "
> static const struct of_device_id ahci_of_match[] = { 
>         { .compatible = "snps,spear-ahci", },
>         { .compatible = "snps,exynos5440-ahci", },

This is exactly what I'm concerned about.  We will end up with a huge
match table with all different platform specific compatible strings in
there.  But they're all matching to the same programming model of the
same IP block.  That's not how device tree compatible table works.

>         {}, 
> };
> MODULE_DEVICE_TABLE(of, ahci_of_match);
> "
> 
> How about to re-change the patch, based on for-next branch of the libata git-repo.
> 
Yes, I think the driver part and platform part can go separately.

Shawn

  reply	other threads:[~2013-06-18  2:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17  9:52 [PATCH V1 0/3] ahci: enable ahci sata support on imx6q Richard Zhu
2013-06-17  9:52 ` Richard Zhu
2013-06-17  9:52 ` [v1 1/3] ARM: dtsi: enable ahci sata on imx6q platforms Richard Zhu
2013-06-18  2:06   ` Shawn Guo
2013-06-18  2:06     ` Shawn Guo
2013-06-18  2:20     ` Zhu Richard-R65037
2013-06-18  2:20       ` Zhu Richard-R65037
2013-06-17  9:52 ` [v1 2/3] ata: ahci_platform: enable imx6q ahci sata support Richard Zhu
2013-06-17 18:27   ` Tejun Heo
2013-06-17 18:27     ` Tejun Heo
2013-06-18  2:01   ` Shawn Guo
2013-06-18  2:01     ` Shawn Guo
2013-06-18  2:19     ` Zhu Richard-R65037
2013-06-18  2:19       ` Zhu Richard-R65037
2013-06-18  2:32       ` Shawn Guo [this message]
2013-06-18  2:32         ` Shawn Guo
2013-06-17  9:52 ` [v1 3/3] imx: ahci: enable ahci sata on imx6q platforms Richard Zhu
2013-06-18  3:03   ` Shawn Guo
2013-06-18  3:03     ` Shawn Guo
2013-06-18  5:00     ` Zhu Richard-R65037
2013-06-18  5:00       ` Zhu Richard-R65037
2013-06-18  5:59       ` Shawn Guo
2013-06-18  5:59         ` Shawn Guo
2013-06-18 19:56         ` Sascha Hauer
2013-06-18 19:56           ` Sascha Hauer
2013-06-19  2:38         ` Zhu Richard-R65037
2013-06-19  2:38           ` Zhu Richard-R65037

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618023236.GA28384@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=r65037@freescale.com \
    --cc=richard.zhuhongxing@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.