* [Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice
@ 2013-06-18 20:24 Michael Tokarev
2013-06-19 8:59 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2013-06-18 20:24 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev
$(block-obj-y) already includes block/, so there's
no need to add it explicitly to $(common-obj-y).
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.objs b/Makefile.objs
index 5b288ba..24c74a8 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -41,7 +41,7 @@ libcacard-y += libcacard/vcardt.o
# single QEMU executable should support all CPUs and machines.
ifeq ($(CONFIG_SOFTMMU),y)
-common-obj-y = $(block-obj-y) blockdev.o blockdev-nbd.o block/
+common-obj-y = $(block-obj-y) blockdev.o blockdev-nbd.o
common-obj-y += net/
common-obj-y += readline.o
common-obj-y += qdev-monitor.o device-hotplug.o
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice
2013-06-18 20:24 [Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice Michael Tokarev
@ 2013-06-19 8:59 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-06-19 8:59 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel
On Wed, Jun 19, 2013 at 12:24:13AM +0400, Michael Tokarev wrote:
> $(block-obj-y) already includes block/, so there's
> no need to add it explicitly to $(common-obj-y).
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-19 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-18 20:24 [Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice Michael Tokarev
2013-06-19 8:59 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.