* [Qemu-devel] [PATCH] eepro100: fix compile warning
@ 2013-06-19 3:12 Wanlong Gao
2013-06-19 9:10 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Wanlong Gao @ 2013-06-19 3:12 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Wanlong Gao
hw/net/eepro100.c:108:0: error: "BIT" redefined [-Werror]
In file included from /work/git/qemu/include/qemu/bitmap.h:16:0,
from /work/git/qemu/include/sysemu/sysemu.h:12,
from hw/net/eepro100.c:48:
/work/git/qemu/include/qemu/bitops.h:21:0: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make: *** [hw/net/eepro100.o] Error 1
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
hw/net/eepro100.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index dc99ea6..478c688 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -105,7 +105,6 @@
#define PCI_IO_SIZE 64
#define PCI_FLASH_SIZE (128 * KiB)
-#define BIT(n) (1 << (n))
#define BITS(n, m) (((0xffffffffU << (31 - n)) >> (31 - n + m)) << m)
/* The SCB accepts the following controls for the Tx and Rx units: */
--
1.8.3.rc2.10.g0c2b1cf
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] eepro100: fix compile warning
2013-06-19 3:12 [Qemu-devel] [PATCH] eepro100: fix compile warning Wanlong Gao
@ 2013-06-19 9:10 ` Stefan Hajnoczi
2013-06-19 9:18 ` Wanlong Gao
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-06-19 9:10 UTC (permalink / raw)
To: Wanlong Gao; +Cc: qemu-devel
On Wed, Jun 19, 2013 at 11:12:41AM +0800, Wanlong Gao wrote:
> hw/net/eepro100.c:108:0: error: "BIT" redefined [-Werror]
> In file included from /work/git/qemu/include/qemu/bitmap.h:16:0,
> from /work/git/qemu/include/sysemu/sysemu.h:12,
> from hw/net/eepro100.c:48:
This #include does not exist in qemu.git/master. Therefore this patch
breaks the build.
NACK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] eepro100: fix compile warning
2013-06-19 9:10 ` Stefan Hajnoczi
@ 2013-06-19 9:18 ` Wanlong Gao
0 siblings, 0 replies; 3+ messages in thread
From: Wanlong Gao @ 2013-06-19 9:18 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel
On 06/19/2013 05:10 PM, Stefan Hajnoczi wrote:
> On Wed, Jun 19, 2013 at 11:12:41AM +0800, Wanlong Gao wrote:
>> hw/net/eepro100.c:108:0: error: "BIT" redefined [-Werror]
>> In file included from /work/git/qemu/include/qemu/bitmap.h:16:0,
>> from /work/git/qemu/include/sysemu/sysemu.h:12,
>> from hw/net/eepro100.c:48:
>
> This #include does not exist in qemu.git/master. Therefore this patch
> breaks the build.
>
> NACK
Oops, sorry it's my fault.
Thanks,
Wanlong Gao
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-19 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-19 3:12 [Qemu-devel] [PATCH] eepro100: fix compile warning Wanlong Gao
2013-06-19 9:10 ` Stefan Hajnoczi
2013-06-19 9:18 ` Wanlong Gao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.