From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] serial: sh-sci: HSCIF support
Date: Wed, 19 Jun 2013 12:33:24 +0000 [thread overview]
Message-ID: <20130619123324.GG32292@verge.net.au> (raw)
In-Reply-To: <CAO3366zWrYFYNaXNWpUvc8KpxjwYVoHz2O5fV33QFSTN2-H7aQ@mail.gmail.com>
On Wed, Jun 19, 2013 at 10:46:51AM +0200, Ulrich Hecht wrote:
> On Tue, Jun 18, 2013 at 3:19 AM, Simon Horman <horms@verge.net.au> wrote:
> >> This hunk causes build warnings in linux-next now:
> >>
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c: In function 'sci_set_termios':
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1942:37: warning: 'srr' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >> serial_port_out(port, HSSRR, srr | HSCIF_SRE);
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1892:15: note: 'srr' was declared here
> >> unsigned int srr;
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1938:47: warning: 'cks' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >> serial_port_out(port, SCSMR, (smr_val & ~3) | cks);
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1890:40: note: 'cks' was declared here
> >> unsigned int baud, smr_val, max_baud, cks;
> >
> > Ulrich, could you please look into this?
>
> Hmmm... I get this warning with gcc 4.5, 4.6, and 4.8. Apparently gcc
> 4.7 is the only one that does not warn about this. Guess what I'm
> using... :(
>
> This is of course trivially fixed, but I have completely lost track of
> the transmogrifications this patch has been subjected to. What's the
> procedure?
Hi Ulrich,
perhaps the best way forward would be for you to post an incremental patch
on top of either the sh-sci branch or renesas-next-20130618 tag of
my renesas tree on kernel.org.
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial: sh-sci: HSCIF support
Date: Wed, 19 Jun 2013 21:33:24 +0900 [thread overview]
Message-ID: <20130619123324.GG32292@verge.net.au> (raw)
In-Reply-To: <CAO3366zWrYFYNaXNWpUvc8KpxjwYVoHz2O5fV33QFSTN2-H7aQ@mail.gmail.com>
On Wed, Jun 19, 2013 at 10:46:51AM +0200, Ulrich Hecht wrote:
> On Tue, Jun 18, 2013 at 3:19 AM, Simon Horman <horms@verge.net.au> wrote:
> >> This hunk causes build warnings in linux-next now:
> >>
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c: In function 'sci_set_termios':
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1942:37: warning: 'srr' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >> serial_port_out(port, HSSRR, srr | HSCIF_SRE);
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1892:15: note: 'srr' was declared here
> >> unsigned int srr;
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1938:47: warning: 'cks' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >> serial_port_out(port, SCSMR, (smr_val & ~3) | cks);
> >> ^
> >> /git/arm-soc/drivers/tty/serial/sh-sci.c:1890:40: note: 'cks' was declared here
> >> unsigned int baud, smr_val, max_baud, cks;
> >
> > Ulrich, could you please look into this?
>
> Hmmm... I get this warning with gcc 4.5, 4.6, and 4.8. Apparently gcc
> 4.7 is the only one that does not warn about this. Guess what I'm
> using... :(
>
> This is of course trivially fixed, but I have completely lost track of
> the transmogrifications this patch has been subjected to. What's the
> procedure?
Hi Ulrich,
perhaps the best way forward would be for you to post an incremental patch
on top of either the sh-sci branch or renesas-next-20130618 tag of
my renesas tree on kernel.org.
next prev parent reply other threads:[~2013-06-19 12:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 3:38 [GIT PULL 0/2 v2] Renesas sh-sci updates for v3.11 Simon Horman
2013-06-17 3:38 ` Simon Horman
2013-06-17 3:38 ` [PATCH 1/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-17 3:38 ` Simon Horman
2013-06-17 12:54 ` Arnd Bergmann
2013-06-17 12:54 ` Arnd Bergmann
2013-06-18 1:19 ` Simon Horman
2013-06-18 1:19 ` Simon Horman
2013-06-19 8:46 ` Ulrich Hecht
2013-06-19 8:46 ` Ulrich Hecht
2013-06-19 12:33 ` Simon Horman [this message]
2013-06-19 12:33 ` Simon Horman
2013-06-19 15:08 ` Arnd Bergmann
2013-06-19 15:08 ` Arnd Bergmann
2013-06-20 12:08 ` Simon Horman
2013-06-20 12:08 ` Simon Horman
2013-06-17 3:38 ` [PATCH 2/2] ARM: shmobile: r8a7790: don't use external clock for SCIFs Simon Horman
2013-06-17 3:38 ` Simon Horman
2013-06-17 8:59 ` [GIT PULL 0/2 v2] Renesas sh-sci updates for v3.11 Simon Horman
2013-06-17 8:59 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-06-17 2:42 [PATCH 0/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-17 2:42 ` [PATCH 1/2] " Simon Horman
2013-06-17 2:42 ` Simon Horman
2013-06-17 2:42 ` Simon Horman
2013-06-17 3:00 ` Greg Kroah-Hartman
2013-06-17 2:59 ` Greg Kroah-Hartman
2013-06-17 3:00 ` Greg Kroah-Hartman
2013-06-13 7:00 [GIT PULL 0/2] Renesas sh-sci updates for v3.11 Simon Horman
2013-06-13 7:00 ` [PATCH 1/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-13 7:00 ` Simon Horman
2013-06-15 1:03 ` Olof Johansson
2013-06-15 1:03 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619123324.GG32292@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.