Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

[Guenter Roeck <linux@roeck-us.net>]

On Wed, Jun 19, 2013 at 11:03:46AM -0700, Kevin Strasser wrote:
> On Wed, Jun 19, 2013 at 11:12:09AM +0200, Thomas Gleixner wrote:
> > On Tue, 18 Jun 2013, Kevin Strasser wrote:
> > 
> > This patch set looks reasonable now, except a formal issue.
> >  
> > > Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> > > Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
> > 
> > This is wrong, as it says:
> > 
> >  Kevin authored the code, sent it to Michael and Michael sent it to
> >  LKML.
> > 
> > 
> > The original code was authored by Michael. This version was authored
> > by Kevin based on Michaels code.
> > 
> > So either you keep Michael as the author, then you want 
> > 
> >  From: Michael Brunner <michael.brunner@kontron.com>
> > 
> >  <patch description/>
> > 
> >  Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
> >  Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> > 
> > or you decide that it's a major rewrite by you, then you want:
> > 
> >  This patch is based on the original version authored by
> >  Michael Brunner <michael.brunner@kontron.com>.
> > 
> >  Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> > 
> >  Or 
> > 
> >  Originally-From: Michael Brunner <michael.brunner@kontron.com>.
> >  Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> 
> Ok, I think this will make sense for all the patches except gpio,
> which is a major rewrite by Guenter.
> 
> So maybe this would be appropriate:
> 
>  From: Guenter Roeck <linux@roeck-us.net>
> 
>  <patch description>
> 
>  Originally-From: Michael Brunner <michael.brunner@kontron.com>
>  Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>  Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
>  ...

Ok with me. Always happy to take the blame :)

Thanks,
Guenter

> 
> Thanks,
> Kevin
> 
> > 
> > Other than that.
> > 
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
>