From: Linus Walleij <linus.walleij@linaro.org>
To: Michael Brunner <mibru@gmx.de>
Cc: Kevin Strasser <kevin.strasser@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Brunner <michael.brunner@kontron.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>, Ben Dooks <ben-linux@fluff.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
Darren Hart <dvhart@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/4] gpio: Kontron PLD gpio driver
Date: Sat, 13 Apr 2013 00:05:03 +0200 [thread overview]
Message-ID: <CACRpkdZJ++E28Z_25SdVOHrvjGwz+HVYsT3pax309gvAtk-_YA@mail.gmail.com> (raw)
In-Reply-To: <20130412130936.3f428cc9@hyperion>
On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner <mibru@gmx.de> wrote:
>> (...)
>> > +struct kempld_gpio_data {
>> > + struct gpio_chip chip;
>> > + int irq;
>> > + struct kempld_device_data *pld;
>> > + uint16_t mask;
>>
>> Just u16?
>
> The specification allows 16 GPIOs for this device, therefore this seems
> to be the right size. Would it be better to use another type instead?
Ah, I was just asking you to use "u16" instead of "uint16_t".
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-04-12 22:05 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:15 [PATCH 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-04-08 17:15 ` [PATCH 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-04-08 17:15 ` Kevin Strasser
2013-04-10 17:02 ` Guenter Roeck
2013-04-10 17:02 ` Guenter Roeck
2013-04-16 9:53 ` Wolfram Sang
2013-04-16 9:53 ` Wolfram Sang
2013-04-08 17:15 ` [PATCH 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-04-08 17:15 ` Kevin Strasser
2013-04-09 8:46 ` Linus Walleij
2013-04-09 16:41 ` Guenter Roeck
2013-04-09 16:41 ` Guenter Roeck
2013-04-10 20:06 ` Linus Walleij
2013-04-10 20:45 ` Linus Walleij
2013-04-12 11:09 ` Michael Brunner
2013-04-12 11:09 ` Michael Brunner
2013-04-12 22:05 ` Linus Walleij [this message]
2013-04-08 17:15 ` [PATCH 4/4] watchdog: Kontron PLD watchdog timer Kevin Strasser
2013-04-08 17:15 ` Kevin Strasser
2013-04-10 16:47 ` Guenter Roeck
2013-04-10 16:57 ` Kevin Strasser
2013-04-10 16:57 ` Kevin Strasser
2013-05-26 14:38 ` Wim Van Sebroeck
2013-04-13 20:38 ` [PATCH 1/4] mfd: Kontron PLD mfd driver Thomas Gleixner
2013-04-18 4:19 ` Guenter Roeck
2013-04-18 4:40 ` Joe Perches
2013-04-18 4:40 ` Joe Perches
2013-04-18 13:35 ` Guenter Roeck
2013-04-18 13:35 ` Guenter Roeck
2013-04-18 16:42 ` Joe Perches
2013-04-18 18:40 ` Guenter Roeck
2013-06-18 21:04 ` [PATCH v2 0/4] Kontron PLD drivers Kevin Strasser
2013-06-18 21:04 ` Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-06-19 8:40 ` Linus Walleij
2013-06-19 9:11 ` Samuel Ortiz
2013-06-19 9:48 ` Mark Brown
2013-06-19 9:12 ` Thomas Gleixner
2013-06-19 18:03 ` Kevin Strasser
2013-06-19 20:35 ` Guenter Roeck
2013-06-18 21:04 ` [PATCH v2 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-06-19 8:36 ` Linus Walleij
2013-06-27 22:14 ` Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 4/4] watchdog: Kontron PLD watchdog timer driver Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 0/4] Kontron PLD drivers Kevin Strasser
2013-06-24 4:00 ` Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-07-01 6:40 ` Wolfram Sang
2013-07-01 6:40 ` Wolfram Sang
2013-06-24 4:00 ` [PATCH v3 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-07-21 14:31 ` Linus Walleij
2013-06-24 4:00 ` [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver Kevin Strasser
2013-06-27 18:23 ` Kevin Strasser
2013-06-27 21:47 ` Samuel Ortiz
2013-06-27 21:47 ` Samuel Ortiz
2013-06-27 22:05 ` Kevin Strasser
2013-06-27 22:05 ` Kevin Strasser
2013-06-24 12:06 ` [PATCH v3 0/4] Kontron PLD drivers Samuel Ortiz
2013-06-24 12:06 ` Samuel Ortiz
2013-06-24 16:09 ` Wolfram Sang
2013-06-24 16:09 ` Wolfram Sang
2013-06-27 20:34 ` Wim Van Sebroeck
2013-06-27 20:34 ` Wim Van Sebroeck
2013-06-27 21:48 ` Samuel Ortiz
2013-06-27 21:48 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZJ++E28Z_25SdVOHrvjGwz+HVYsT3pax309gvAtk-_YA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=ben-linux@fluff.org \
--cc=dvhart@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.strasser@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mibru@gmx.de \
--cc=michael.brunner@kontron.com \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.