* [PATCH] ARM: mxs: don't select HAVE_PWM
@ 2013-06-21 20:30 Arnd Bergmann
2013-06-24 7:01 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2013-06-21 20:30 UTC (permalink / raw)
To: linux-arm-kernel
The HAVE_PWM symbol is only for legacy platforms that provide
the PWM API without using the generic framework. MXS actually
uses that framework, and selecting the symbol anyway might
cause build errors like
drivers/built-in.o: In function `pwm_beeper_resume':
:(.text+0x1f4fc0): undefined reference to `pwm_config'
:(.text+0x1f4fc8): undefined reference to `pwm_enable'
drivers/built-in.o: In function `pwm_beeper_suspend':
:(.text+0x1f4ffc): undefined reference to `pwm_disable'
when CONFIG_PWM is disabled.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
index 59c30ef..616fe02 100644
--- a/arch/arm/mach-mxs/Kconfig
+++ b/arch/arm/mach-mxs/Kconfig
@@ -3,7 +3,6 @@ config SOC_IMX23
select ARM_AMBA
select ARM_CPU_SUSPEND if PM
select CPU_ARM926T
- select HAVE_PWM
select PINCTRL_IMX23
config SOC_IMX28
@@ -12,7 +11,6 @@ config SOC_IMX28
select ARM_CPU_SUSPEND if PM
select CPU_ARM926T
select HAVE_CAN_FLEXCAN if CAN
- select HAVE_PWM
select PINCTRL_IMX28
config ARCH_MXS
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: mxs: don't select HAVE_PWM
2013-06-21 20:30 [PATCH] ARM: mxs: don't select HAVE_PWM Arnd Bergmann
@ 2013-06-24 7:01 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-06-24 7:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 21, 2013 at 10:30:54PM +0200, Arnd Bergmann wrote:
> The HAVE_PWM symbol is only for legacy platforms that provide
> the PWM API without using the generic framework. MXS actually
> uses that framework, and selecting the symbol anyway might
> cause build errors like
>
> drivers/built-in.o: In function `pwm_beeper_resume':
> :(.text+0x1f4fc0): undefined reference to `pwm_config'
> :(.text+0x1f4fc8): undefined reference to `pwm_enable'
> drivers/built-in.o: In function `pwm_beeper_suspend':
> :(.text+0x1f4ffc): undefined reference to `pwm_disable'
>
> when CONFIG_PWM is disabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
> diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
> index 59c30ef..616fe02 100644
> --- a/arch/arm/mach-mxs/Kconfig
> +++ b/arch/arm/mach-mxs/Kconfig
> @@ -3,7 +3,6 @@ config SOC_IMX23
> select ARM_AMBA
> select ARM_CPU_SUSPEND if PM
> select CPU_ARM926T
> - select HAVE_PWM
> select PINCTRL_IMX23
>
> config SOC_IMX28
> @@ -12,7 +11,6 @@ config SOC_IMX28
> select ARM_CPU_SUSPEND if PM
> select CPU_ARM926T
> select HAVE_CAN_FLEXCAN if CAN
> - select HAVE_PWM
> select PINCTRL_IMX28
>
> config ARCH_MXS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-24 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 20:30 [PATCH] ARM: mxs: don't select HAVE_PWM Arnd Bergmann
2013-06-24 7:01 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.