From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Make the rps new_delay comparison more readable
Date: Tue, 25 Jun 2013 12:06:32 -0700 [thread overview]
Message-ID: <20130625120632.6532444a@jbarnes-desktop> (raw)
In-Reply-To: <1372177266-2665-6-git-send-email-ville.syrjala@linux.intel.com>
On Tue, 25 Jun 2013 19:21:05 +0300
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Eliminate the weird inverted logic from the rps new_delay comparison.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 611da3a..62f8b2d 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -707,8 +707,8 @@ static void gen6_pm_rps_work(struct work_struct *work)
> /* sysfs frequency interfaces may have snuck in while servicing the
> * interrupt
> */
> - if (!(new_delay > dev_priv->rps.max_delay ||
> - new_delay < dev_priv->rps.min_delay)) {
> + if (new_delay >= dev_priv->rps.min_delay &&
> + new_delay <= dev_priv->rps.max_delay) {
> if (IS_VALLEYVIEW(dev_priv->dev))
> valleyview_set_rps(dev_priv->dev, new_delay);
> else
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-06-25 19:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:21 [PATCH 0/6] drm/i915: VLV rps stuff ville.syrjala
2013-06-25 16:21 ` [PATCH 1/6] drm/i915: Clean up VLV rps code a bit ville.syrjala
2013-06-25 18:59 ` Jesse Barnes
2013-06-25 16:21 ` [PATCH 2/6] drm/i915: Don't wait for Punit after each freq change on VLV ville.syrjala
2013-06-25 19:02 ` Jesse Barnes
2013-06-25 16:21 ` [PATCH 3/6] drm/i915: Optimize the VLV Punit wait a bit ville.syrjala
2013-06-25 19:03 ` Jesse Barnes
2013-06-26 10:17 ` Daniel Vetter
2013-06-26 14:43 ` [PATCH] drm/i915: Use wait_for() to wait for Punit to change GPU freq on VLV ville.syrjala
2013-06-26 16:26 ` Jesse Barnes
2013-07-02 13:41 ` Daniel Vetter
2013-07-02 14:01 ` Daniel Vetter
2013-06-25 16:21 ` [PATCH 4/6] drm/i915: Use msecs_to_jiffies_timeout when waiting for Punit freq change ville.syrjala
2013-06-25 19:03 ` Jesse Barnes
2013-06-25 16:21 ` [PATCH 5/6] drm/i915: Make the rps new_delay comparison more readable ville.syrjala
2013-06-25 19:06 ` Jesse Barnes [this message]
2013-06-25 16:21 ` [PATCH 6/6] drm/i915: GEN6_RP_INTERRUPT_LIMITS doesn't seem to exist on VLV ville.syrjala
2013-06-25 19:06 ` Jesse Barnes
2013-06-26 10:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625120632.6532444a@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.