All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix README, FSTYP options
@ 2013-06-25 19:34 Dwight Engen
  2013-06-26  0:50 ` Dave Chinner
  0 siblings, 1 reply; 5+ messages in thread
From: Dwight Engen @ 2013-06-25 19:34 UTC (permalink / raw)
  To: xfs

commit cbcc88fb changed test selection to use shell globs, so fixup the
examples given in the README file.

add options for FSTYPs supported by _scratch_mkfs().

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
---
 README | 5 +++--
 check  | 4 +++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/README b/README
index d4d4f31..af4e4a5 100644
--- a/README
+++ b/README
@@ -81,9 +81,10 @@ Running tests:
 
     - cd xfstests
     - By default the tests suite will run xfs tests:
-    - ./check 001 002 003 ... or you can explicitly run a filesystem: 
+    - ./check '*/001' '*/002' '*/003'
+    - ./check '*/06?'
+    - You can explicitly specify a filesystem (btrfs, ext4, nfs, udf, xfs): 
       ./check -xfs [test(s)]
-    - You can run a range of tests: ./check 067-078
     - Groups of tests maybe ran by: ./check -g [group(s)]
       See the 'group' file for details on groups
     - for udf tests: ./check -udf [test(s)]
diff --git a/check b/check
index ff8fbcf..a677727 100755
--- a/check
+++ b/check
@@ -159,9 +159,11 @@ while [ $# -gt 0 ]; do
 	case "$1" in
 	-\? | -h | --help) usage ;;
 
+	-btrfs)	FSTYP=btrfs ;;
+	-ext4)	FSTYP=ext4 ;;
+	-nfs)	FSTYP=nfs ;;
 	-udf)	FSTYP=udf ;;
 	-xfs)	FSTYP=xfs ;;
-	-nfs)	FSTYP=nfs ;;
 
 	-g)	group=$2 ; shift ;
 		group_list=$(get_group_list $group)
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: fix README, FSTYP options
  2013-06-25 19:34 [PATCH] xfstests: fix README, FSTYP options Dwight Engen
@ 2013-06-26  0:50 ` Dave Chinner
  2013-06-26 16:29   ` Dwight Engen
  2013-06-27 15:57   ` [PATCH v2] " Dwight Engen
  0 siblings, 2 replies; 5+ messages in thread
From: Dave Chinner @ 2013-06-26  0:50 UTC (permalink / raw)
  To: Dwight Engen; +Cc: xfs

On Tue, Jun 25, 2013 at 03:34:23PM -0400, Dwight Engen wrote:
> commit cbcc88fb changed test selection to use shell globs, so fixup the
> examples given in the README file.
> 
> add options for FSTYPs supported by _scratch_mkfs().

To tell the truth, I'd prefer to get rid of the -xfs/-udf/... etc
options rather than propoagate them further. We autodetect the FSTYP
just fine on Linux via blkid probing of $TEST_DEV. Hence in reality,
the only CLI option we need is for NFS...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: fix README, FSTYP options
  2013-06-26  0:50 ` Dave Chinner
@ 2013-06-26 16:29   ` Dwight Engen
  2013-06-27 15:57   ` [PATCH v2] " Dwight Engen
  1 sibling, 0 replies; 5+ messages in thread
From: Dwight Engen @ 2013-06-26 16:29 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs

On Wed, 26 Jun 2013 10:50:29 +1000
Dave Chinner <david@fromorbit.com> wrote:

> On Tue, Jun 25, 2013 at 03:34:23PM -0400, Dwight Engen wrote:
> > commit cbcc88fb changed test selection to use shell globs, so fixup
> > the examples given in the README file.
> > 
> > add options for FSTYPs supported by _scratch_mkfs().
> 
> To tell the truth, I'd prefer to get rid of the -xfs/-udf/... etc
> options rather than propoagate them further. We autodetect the FSTYP
> just fine on Linux via blkid probing of $TEST_DEV. Hence in reality,
> the only CLI option we need is for NFS...

Yep, I realized there was autodetection (nice!) later. I'll resubmit
with only NFS in the list.

> Cheers,
> 
> Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v2] xfstests: fix README, FSTYP options
  2013-06-26  0:50 ` Dave Chinner
  2013-06-26 16:29   ` Dwight Engen
@ 2013-06-27 15:57   ` Dwight Engen
  2013-07-09 16:11     ` Ben Myers
  1 sibling, 1 reply; 5+ messages in thread
From: Dwight Engen @ 2013-06-27 15:57 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs

commit cbcc88fb changed test selection to use shell globs, so fixup the
examples given in the README file.

remove options for FSTYP other than NFS since the FSTYP will be automatically
detected (on Linux) from $TEST_DEV.

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
---
 README | 8 +++++---
 check  | 4 ----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/README b/README
index d4d4f31..da75dcf 100644
--- a/README
+++ b/README
@@ -81,9 +81,11 @@ Running tests:
 
     - cd xfstests
     - By default the tests suite will run xfs tests:
-    - ./check 001 002 003 ... or you can explicitly run a filesystem: 
-      ./check -xfs [test(s)]
-    - You can run a range of tests: ./check 067-078
+    - ./check '*/001' '*/002' '*/003'
+    - ./check '*/06?'
+    - You can explicitly specify NFS, otherwise the filesystem type will be
+      autodetected from $TEST_DEV:
+      ./check -nfs [test(s)]
     - Groups of tests maybe ran by: ./check -g [group(s)]
       See the 'group' file for details on groups
     - for udf tests: ./check -udf [test(s)]
diff --git a/check b/check
index ff8fbcf..4085eae 100755
--- a/check
+++ b/check
@@ -73,8 +73,6 @@ usage()
     echo "Usage: $0 [options] [testlist]"'
 
 check options
-    -xfs                test XFS (default)
-    -udf                test UDF
     -nfs                test NFS
     -l			line mode diff
     -udiff		show unified diff (default)
@@ -159,8 +157,6 @@ while [ $# -gt 0 ]; do
 	case "$1" in
 	-\? | -h | --help) usage ;;
 
-	-udf)	FSTYP=udf ;;
-	-xfs)	FSTYP=xfs ;;
 	-nfs)	FSTYP=nfs ;;
 
 	-g)	group=$2 ; shift ;
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] xfstests: fix README, FSTYP options
  2013-06-27 15:57   ` [PATCH v2] " Dwight Engen
@ 2013-07-09 16:11     ` Ben Myers
  0 siblings, 0 replies; 5+ messages in thread
From: Ben Myers @ 2013-07-09 16:11 UTC (permalink / raw)
  To: Dwight Engen; +Cc: xfs

On Thu, Jun 27, 2013 at 11:57:36AM -0400, Dwight Engen wrote:
> commit cbcc88fb changed test selection to use shell globs, so fixup the
> examples given in the README file.
> 
> remove options for FSTYP other than NFS since the FSTYP will be automatically
> detected (on Linux) from $TEST_DEV.
> 
> Signed-off-by: Dwight Engen <dwight.engen@oracle.com>

Reviewed-by: Ben Myers <bpm@sgi.com>

Looks good.  Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-09 16:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-25 19:34 [PATCH] xfstests: fix README, FSTYP options Dwight Engen
2013-06-26  0:50 ` Dave Chinner
2013-06-26 16:29   ` Dwight Engen
2013-06-27 15:57   ` [PATCH v2] " Dwight Engen
2013-07-09 16:11     ` Ben Myers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.