All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	paulus@samba.org, acme@redhat.com, sukadev@linux.vnet.ibm.com,
	xiaoguangrong@linux.vnet.ibm.com
Subject: Re: [PATCH v2 2/2] perf tools: Make Power7 events available for perf
Date: Fri, 28 Jun 2013 00:23:09 +1000	[thread overview]
Message-ID: <20130627142309.GB13867@concordia> (raw)
In-Reply-To: <1372170933-4538-3-git-send-email-runzhen@linux.vnet.ibm.com>

On Tue, Jun 25, 2013 at 10:35:33PM +0800, Runzhen Wang wrote:
> Power7 supports over 530 different perf events but only a small
> subset of these can be specified by name, for the remaining
> events, we must specify them by their raw code:

Hi Runzhen,

This is looking good. Sorry one last request below ...


> diff --git a/arch/powerpc/perf/power7-events-list.h b/arch/powerpc/perf/power7-events-list.h
> new file mode 100644
> index 0000000..a67e8a9
> --- /dev/null
> +++ b/arch/powerpc/perf/power7-events-list.h
> @@ -0,0 +1,548 @@
..
> +
> +EVENT(PM_IC_DEMAND_L2_BR_ALL,                 0x4898)
> +EVENT(PM_GCT_UTIL_7_TO_10_SLOTS,              0x20a0)
> +EVENT(PM_PMC2_SAVED,                          0x10022)
> +EVENT(PM_CMPLU_STALL_DFU,                     0x2003c)
> +EVENT(PM_VSU0_16FLOP,                         0xa0a4)


Can you add a leading zero to all the events that don't have a PMC, so
that they all line up vertically. It makes it a lot easier to scan the
list visually.

eg:

EVENT(PM_IC_DEMAND_L2_BR_ALL,                 0x04898)
EVENT(PM_GCT_UTIL_7_TO_10_SLOTS,              0x020a0)
EVENT(PM_PMC2_SAVED,                          0x10022)
EVENT(PM_CMPLU_STALL_DFU,                     0x2003c)
EVENT(PM_VSU0_16FLOP,                         0x0a0a4)


cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, xiaoguangrong@linux.vnet.ibm.com,
	acme@redhat.com, paulus@samba.org, sukadev@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] perf tools: Make Power7 events available for perf
Date: Fri, 28 Jun 2013 00:23:09 +1000	[thread overview]
Message-ID: <20130627142309.GB13867@concordia> (raw)
In-Reply-To: <1372170933-4538-3-git-send-email-runzhen@linux.vnet.ibm.com>

On Tue, Jun 25, 2013 at 10:35:33PM +0800, Runzhen Wang wrote:
> Power7 supports over 530 different perf events but only a small
> subset of these can be specified by name, for the remaining
> events, we must specify them by their raw code:

Hi Runzhen,

This is looking good. Sorry one last request below ...


> diff --git a/arch/powerpc/perf/power7-events-list.h b/arch/powerpc/perf/power7-events-list.h
> new file mode 100644
> index 0000000..a67e8a9
> --- /dev/null
> +++ b/arch/powerpc/perf/power7-events-list.h
> @@ -0,0 +1,548 @@
..
> +
> +EVENT(PM_IC_DEMAND_L2_BR_ALL,                 0x4898)
> +EVENT(PM_GCT_UTIL_7_TO_10_SLOTS,              0x20a0)
> +EVENT(PM_PMC2_SAVED,                          0x10022)
> +EVENT(PM_CMPLU_STALL_DFU,                     0x2003c)
> +EVENT(PM_VSU0_16FLOP,                         0xa0a4)


Can you add a leading zero to all the events that don't have a PMC, so
that they all line up vertically. It makes it a lot easier to scan the
list visually.

eg:

EVENT(PM_IC_DEMAND_L2_BR_ALL,                 0x04898)
EVENT(PM_GCT_UTIL_7_TO_10_SLOTS,              0x020a0)
EVENT(PM_PMC2_SAVED,                          0x10022)
EVENT(PM_CMPLU_STALL_DFU,                     0x2003c)
EVENT(PM_VSU0_16FLOP,                         0x0a0a4)


cheers

  parent reply	other threads:[~2013-06-27 14:23 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 14:35 [PATCH v2 0/2] perf tools: Power7 events name available for perf Runzhen Wang
2013-06-25 14:35 ` Runzhen Wang
2013-06-25 14:35 ` [PATCH v3 1/2] perf tools: fix a typo of a Power7 event name Runzhen Wang
2013-06-25 14:35   ` Runzhen Wang
2013-06-27 14:26   ` Michael Ellerman
2013-06-27 14:26     ` Michael Ellerman
2013-06-25 14:35 ` [PATCH v2 2/2] perf tools: Make Power7 events available for perf Runzhen Wang
2013-06-25 14:35   ` Runzhen Wang
2013-06-25 16:46   ` Vince Weaver
2013-06-25 16:46     ` Vince Weaver
2013-07-04 12:52     ` Michael Ellerman
2013-07-04 12:52       ` Michael Ellerman
2013-07-04 12:57       ` Peter Zijlstra
2013-07-04 12:57         ` Peter Zijlstra
2013-07-05 10:23         ` Ingo Molnar
2013-07-05 10:23           ` Ingo Molnar
2013-07-09  1:29         ` Michael Ellerman
2013-07-09  1:29           ` Michael Ellerman
2013-07-09  2:24           ` Vince Weaver
2013-07-09  2:24             ` Vince Weaver
2013-07-09  3:34             ` Michael Ellerman
2013-07-09  3:34               ` Michael Ellerman
2013-07-09 15:20               ` Vince Weaver
2013-07-09 15:20                 ` Vince Weaver
2013-07-10  2:37                 ` Michael Ellerman
2013-07-10  2:37                   ` Michael Ellerman
2013-07-09  8:14             ` Peter Zijlstra
2013-07-09  8:14               ` Peter Zijlstra
2013-07-09 15:05               ` Vince Weaver
2013-07-09 15:05                 ` Vince Weaver
2013-07-11 10:58                 ` Will Deacon
2013-07-11 10:58                   ` Will Deacon
2013-07-11 17:53                   ` Vince Weaver
2013-07-11 17:53                     ` Vince Weaver
2013-07-10  3:09               ` Michael Ellerman
2013-07-10  3:09                 ` Michael Ellerman
2013-07-10  8:34                 ` Ingo Molnar
2013-07-10  8:34                   ` Ingo Molnar
2013-07-11  4:42                   ` Vince Weaver
2013-07-11  4:42                     ` Vince Weaver
2013-07-11  6:58                     ` Michael Ellerman
2013-07-11  6:58                       ` Michael Ellerman
2013-06-27 14:23   ` Michael Ellerman [this message]
2013-06-27 14:23     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627142309.GB13867@concordia \
    --to=michael@ellerman.id.au \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=runzhen@linux.vnet.ibm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.