From: Guenter Roeck <linux@roeck-us.net>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Shawn Guo <shawn.guo@linaro.org>,
Jean Delvare <khali@linux-fr.org>,
jimwall@q.com, brian@crystalfontz.com,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature
Date: Thu, 27 Jun 2013 07:27:58 -0700 [thread overview]
Message-ID: <20130627142758.GA5812@roeck-us.net> (raw)
In-Reply-To: <20130627091732.GP5803@lukather>
On Thu, Jun 27, 2013 at 11:17:32AM +0200, Maxime Ripard wrote:
> On Wed, Jun 26, 2013 at 07:39:27AM -0700, Guenter Roeck wrote:
> > On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote:
> > > The low resolution ADC of the mxs is able to read an internal temperature
> > > sensor, expose that using hwmon.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> >
> > Wouldn't it make more sense to use iio-hwmon and improve it if necessary ?
>
> Actually, I wonder if we should not just put the hwmon driver
> capabilities directly into the mxs-lradc driver, just like it's already
> been done in this driver for the touchscreen support.
>
> The probing of this hwmon driver doesn't really belong to the DT, it's
> not really realistic to probe it from the machine definition, and it
> really is the IP that is wired that way.
>
Merging iio-hwmon functionality into an adc driver seems just as bad
(or even worse) as copying it into a new driver.
If the lradc driver knows that the ADC channels are temperature sensors, it
should register them with the iio subsystem as IIO_TEMP type. Then you should
be able to use iio_hwmon as is.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature
Date: Thu, 27 Jun 2013 07:27:58 -0700 [thread overview]
Message-ID: <20130627142758.GA5812@roeck-us.net> (raw)
In-Reply-To: <20130627091732.GP5803@lukather>
On Thu, Jun 27, 2013 at 11:17:32AM +0200, Maxime Ripard wrote:
> On Wed, Jun 26, 2013 at 07:39:27AM -0700, Guenter Roeck wrote:
> > On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote:
> > > The low resolution ADC of the mxs is able to read an internal temperature
> > > sensor, expose that using hwmon.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> >
> > Wouldn't it make more sense to use iio-hwmon and improve it if necessary ?
>
> Actually, I wonder if we should not just put the hwmon driver
> capabilities directly into the mxs-lradc driver, just like it's already
> been done in this driver for the touchscreen support.
>
> The probing of this hwmon driver doesn't really belong to the DT, it's
> not really realistic to probe it from the machine definition, and it
> really is the IP that is wired that way.
>
Merging iio-hwmon functionality into an adc driver seems just as bad
(or even worse) as copying it into a new driver.
If the lradc driver knows that the ADC channels are temperature sensors, it
should register them with the iio subsystem as IIO_TEMP type. Then you should
be able to use iio_hwmon as is.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Shawn Guo <shawn.guo@linaro.org>,
Jean Delvare <khali@linux-fr.org>,
jimwall@q.com, brian@crystalfontz.com,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature
Date: Thu, 27 Jun 2013 14:27:58 +0000 [thread overview]
Message-ID: <20130627142758.GA5812@roeck-us.net> (raw)
In-Reply-To: <20130627091732.GP5803@lukather>
On Thu, Jun 27, 2013 at 11:17:32AM +0200, Maxime Ripard wrote:
> On Wed, Jun 26, 2013 at 07:39:27AM -0700, Guenter Roeck wrote:
> > On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote:
> > > The low resolution ADC of the mxs is able to read an internal temperature
> > > sensor, expose that using hwmon.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> >
> > Wouldn't it make more sense to use iio-hwmon and improve it if necessary ?
>
> Actually, I wonder if we should not just put the hwmon driver
> capabilities directly into the mxs-lradc driver, just like it's already
> been done in this driver for the touchscreen support.
>
> The probing of this hwmon driver doesn't really belong to the DT, it's
> not really realistic to probe it from the machine definition, and it
> really is the IP that is wired that way.
>
Merging iio-hwmon functionality into an adc driver seems just as bad
(or even worse) as copying it into a new driver.
If the lradc driver knows that the ADC channels are temperature sensors, it
should register them with the iio subsystem as IIO_TEMP type. Then you should
be able to use iio_hwmon as is.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-06-27 14:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:51 [PATCH 0/4] Add an hwmon driver for the mxs soc internal sensor Alexandre Belloni
2013-06-26 8:51 ` [lm-sensors] " Alexandre Belloni
2013-06-26 8:51 ` Alexandre Belloni
2013-06-26 8:51 ` [PATCH 1/4] arm: mxs: Add #io-channel-cells property to lradc Alexandre Belloni
2013-06-26 8:51 ` [lm-sensors] " Alexandre Belloni
2013-06-26 8:51 ` Alexandre Belloni
2013-06-26 8:51 ` [PATCH 2/4] arm: mxs: add lradc to cfa10036 Alexandre Belloni
2013-06-26 8:51 ` [lm-sensors] " Alexandre Belloni
2013-06-26 8:51 ` Alexandre Belloni
2013-06-26 8:51 ` [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature Alexandre Belloni
2013-06-26 8:51 ` [lm-sensors] " Alexandre Belloni
2013-06-26 8:51 ` Alexandre Belloni
2013-06-26 14:39 ` Guenter Roeck
2013-06-26 14:39 ` [lm-sensors] " Guenter Roeck
2013-06-26 14:39 ` Guenter Roeck
2013-06-27 9:17 ` Maxime Ripard
2013-06-27 9:17 ` [lm-sensors] " Maxime Ripard
2013-06-27 9:17 ` Maxime Ripard
2013-06-27 9:17 ` Maxime Ripard
2013-06-27 14:27 ` Guenter Roeck [this message]
2013-06-27 14:27 ` [lm-sensors] " Guenter Roeck
2013-06-27 14:27 ` Guenter Roeck
2013-06-27 19:26 ` Alexandre Belloni
2013-06-27 19:26 ` [lm-sensors] " Alexandre Belloni
2013-06-27 19:26 ` Alexandre Belloni
2013-06-27 19:26 ` Alexandre Belloni
2013-06-28 14:18 ` Lars-Peter Clausen
2013-06-28 14:18 ` [lm-sensors] " Lars-Peter Clausen
2013-06-28 14:18 ` Lars-Peter Clausen
2013-06-28 14:50 ` Alexandre Belloni
2013-06-28 14:50 ` [lm-sensors] " Alexandre Belloni
2013-06-28 14:50 ` Alexandre Belloni
2013-06-28 15:24 ` Lars-Peter Clausen
2013-06-28 15:24 ` [lm-sensors] " Lars-Peter Clausen
2013-06-28 15:24 ` Lars-Peter Clausen
2013-06-28 15:24 ` Lars-Peter Clausen
2013-06-28 16:35 ` Guenter Roeck
2013-06-28 16:35 ` [lm-sensors] " Guenter Roeck
2013-06-28 16:35 ` Guenter Roeck
2013-06-26 8:51 ` [PATCH 4/4] arm: mxs: Add mxs internal temp sensor to cfa-10036 Alexandre Belloni
2013-06-26 8:51 ` [lm-sensors] " Alexandre Belloni
2013-06-26 8:51 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627142758.GA5812@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=jimwall@q.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lm-sensors@lm-sensors.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.