* [PATCH 3.9-stable] iwlegacy: fix rate control regression
@ 2013-06-27 23:43 Jonghwan Choi
2013-06-28 14:46 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Jonghwan Choi @ 2013-06-27 23:43 UTC (permalink / raw)
To: 'Jonghwan Choi', linux-kernel
Cc: stable, 'Stanislaw Gruszka', 'John W. Linville', cpgs
This patch looks like it should be in the 3.9-stable tree, should we apply
it?
------------------
From: "Stanislaw Gruszka <sgruszka@redhat.com>"
commit a8cf0194b7187fb65dfff28a1c5153d442e3836a upstream
Since driver does not use control.rates[0].count, we have never set that
variable. But currently, after rate control API rewrite, this is required
by mac80211. Otherwise legacy rates control does not work and we transmit
always at 1Mbit/s on pre 11n networks.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/net/wireless/iwlegacy/3945-rs.c | 1 +
drivers/net/wireless/iwlegacy/4965-rs.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlegacy/3945-rs.c
b/drivers/net/wireless/iwlegacy/3945-rs.c
index d4fd29a..dde7ff0 100644
--- a/drivers/net/wireless/iwlegacy/3945-rs.c
+++ b/drivers/net/wireless/iwlegacy/3945-rs.c
@@ -816,6 +816,7 @@ out:
rs_sta->last_txrate_idx = idx;
info->control.rates[0].idx = rs_sta->last_txrate_idx;
}
+ info->control.rates[0].count = 1;
D_RATE("leave: %d\n", idx);
}
diff --git a/drivers/net/wireless/iwlegacy/4965-rs.c
b/drivers/net/wireless/iwlegacy/4965-rs.c
index 6c7493c..38fb9e1 100644
--- a/drivers/net/wireless/iwlegacy/4965-rs.c
+++ b/drivers/net/wireless/iwlegacy/4965-rs.c
@@ -2268,7 +2268,7 @@ il4965_rs_get_rate(void *il_r, struct ieee80211_sta
*sta, void *il_sta,
info->control.rates[0].flags = 0;
}
info->control.rates[0].idx = rate_idx;
-
+ info->control.rates[0].count = 1;
}
static void *
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3.9-stable] iwlegacy: fix rate control regression
2013-06-27 23:43 [PATCH 3.9-stable] iwlegacy: fix rate control regression Jonghwan Choi
@ 2013-06-28 14:46 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2013-06-28 14:46 UTC (permalink / raw)
To: Jonghwan Choi; +Cc: linux-kernel, stable, 'John W. Linville', cpgs
On Fri, Jun 28, 2013 at 08:43:46AM +0900, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.9-stable tree, should we apply
> it?
No, this regression is caused by
commit 0d528d85c519b755b6f4e1bafa3a39984370e1c1
Author: Felix Fietkau <nbd@openwrt.org>
Date: Mon Apr 22 16:14:41 2013 +0200
mac80211: improve the rate control API
which first appear on 3.10-rc2. Sorry for not specifying that information
in the ChangeLog.
Stanislaw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-28 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-27 23:43 [PATCH 3.9-stable] iwlegacy: fix rate control regression Jonghwan Choi
2013-06-28 14:46 ` Stanislaw Gruszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.