All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ben Guthro <benjamin.guthro@citrix.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
	"Rafael J . Wysocki" <rjw@sisk.pl>,
	linux-acpi@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v5 4/5] x86/tboot: Fail extended mode reduced hardware sleep
Date: Fri, 28 Jun 2013 12:05:13 -0400	[thread overview]
Message-ID: <20130628160513.GC13468@phenom.dumpdata.com> (raw)
In-Reply-To: <1372427184-6197-5-git-send-email-benjamin.guthro@citrix.com>

On Fri, Jun 28, 2013 at 09:46:23AM -0400, Ben Guthro wrote:
> As tboot currently does not support the reduced hardware sleep
> interface, fail this extended call.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
> Cc: tboot-devel@lists.sourceforge.net
> Cc: Gang Wei <gang.wei@intel.com>
> ---
>  arch/x86/kernel/tboot.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
> index d578c9c..57383b2 100644
> --- a/arch/x86/kernel/tboot.c
> +++ b/arch/x86/kernel/tboot.c
> @@ -285,6 +285,9 @@ static int tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control,
>  	if (!tboot_enabled())
>  		return 0;
>  
> +	if (extended)
> +		return -1;

I would add WARN_ON just so that the user is aware of.
Perhaps

	if (WARN(extended,"tboot is not able to suspend on ACPI extended platforms. Contact
tboot-something mailing list please."))
		return -1

Otherwise
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> +
>  	tboot_copy_fadt(&acpi_gbl_FADT);
>  	tboot->acpi_sinfo.pm1a_cnt_val = pm1a_control;
>  	tboot->acpi_sinfo.pm1b_cnt_val = pm1b_control;
> -- 
> 1.7.9.5
> 

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ben Guthro <benjamin.guthro@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	"Rafael J . Wysocki" <rjw@sisk.pl>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	xen-devel@lists.xen.org, tboot-devel@lists.sourceforge.net,
	Gang Wei <gang.wei@intel.com>
Subject: Re: [PATCH v5 4/5] x86/tboot: Fail extended mode reduced hardware sleep
Date: Fri, 28 Jun 2013 12:05:13 -0400	[thread overview]
Message-ID: <20130628160513.GC13468@phenom.dumpdata.com> (raw)
In-Reply-To: <1372427184-6197-5-git-send-email-benjamin.guthro@citrix.com>

On Fri, Jun 28, 2013 at 09:46:23AM -0400, Ben Guthro wrote:
> As tboot currently does not support the reduced hardware sleep
> interface, fail this extended call.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
> Cc: tboot-devel@lists.sourceforge.net
> Cc: Gang Wei <gang.wei@intel.com>
> ---
>  arch/x86/kernel/tboot.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
> index d578c9c..57383b2 100644
> --- a/arch/x86/kernel/tboot.c
> +++ b/arch/x86/kernel/tboot.c
> @@ -285,6 +285,9 @@ static int tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control,
>  	if (!tboot_enabled())
>  		return 0;
>  
> +	if (extended)
> +		return -1;

I would add WARN_ON just so that the user is aware of.
Perhaps

	if (WARN(extended,"tboot is not able to suspend on ACPI extended platforms. Contact
tboot-something mailing list please."))
		return -1

Otherwise
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> +
>  	tboot_copy_fadt(&acpi_gbl_FADT);
>  	tboot->acpi_sinfo.pm1a_cnt_val = pm1a_control;
>  	tboot->acpi_sinfo.pm1b_cnt_val = pm1b_control;
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2013-06-28 16:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 13:46 [PATCH v5 0/5] Xen/ACPI: support sleep state entering on hardware reduced systems Ben Guthro
2013-06-28 13:46 ` Ben Guthro
2013-06-28 13:46 ` [PATCH v5 1/5] acpi: Remove need to include linux/acpi.h in common acpica code Ben Guthro
2013-06-28 13:46   ` Ben Guthro
2013-06-28 16:07   ` Konrad Rzeszutek Wilk
2013-06-28 16:07   ` Konrad Rzeszutek Wilk
2013-06-28 13:46 ` Ben Guthro
2013-06-28 13:46 ` [PATCH v5 2/5] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path Ben Guthro
2013-06-28 13:46   ` Ben Guthro
2013-06-28 16:06   ` Konrad Rzeszutek Wilk
2013-06-28 16:06   ` Konrad Rzeszutek Wilk
2013-06-28 13:46 ` [PATCH v5 3/5] acpi: Adjust linux acpi OS functions to new extended parameter Ben Guthro
2013-06-28 13:46   ` Ben Guthro
2013-06-28 16:03   ` Konrad Rzeszutek Wilk
2013-06-28 16:03   ` Konrad Rzeszutek Wilk
2013-06-28 16:15     ` Ben Guthro
2013-06-28 16:15     ` Ben Guthro
2013-06-28 16:15       ` Ben Guthro
2013-06-28 13:46 ` [PATCH v5 4/5] x86/tboot: Fail extended mode reduced hardware sleep Ben Guthro
2013-06-28 13:46   ` Ben Guthro
2013-06-28 16:05   ` Konrad Rzeszutek Wilk [this message]
2013-06-28 16:05     ` Konrad Rzeszutek Wilk
2013-06-28 16:05   ` Konrad Rzeszutek Wilk
2013-06-28 13:46 ` Ben Guthro
2013-06-28 13:46 ` [PATCH v5 5/5] xen/acpi: notify xen when reduced hardware sleep is available Ben Guthro
2013-06-28 13:46   ` Ben Guthro
2013-06-28 16:05   ` Konrad Rzeszutek Wilk
2013-06-28 16:05   ` Konrad Rzeszutek Wilk
2013-06-28 13:46 ` Ben Guthro
2013-07-27 14:05 ` [PATCH v5 0/5] Xen/ACPI: support sleep state entering on hardware reduced systems Rafael J. Wysocki
2013-07-27 14:05 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628160513.GC13468@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=benjamin.guthro@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tboot-devel@lists.sourceforge.net \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.