* [PATCH net] ipv6: only apply anti-spoofing checks to not-pointopoint tunnels
@ 2013-06-27 20:46 Hannes Frederic Sowa
2013-07-01 20:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Frederic Sowa @ 2013-06-27 20:46 UTC (permalink / raw)
To: netdev; +Cc: rm, davem, yoshfuji
Because of commit 218774dc341f219bfcf940304a081b121a0e8099 ("ipv6: add
anti-spoofing checks for 6to4 and 6rd") the sit driver dropped packets
for 2002::/16 destinations and sources even when configured to work as a
tunnel with fixed endpoint. We may only apply the 6rd/6to4 anti-spoofing
checks if the device is not in pointopoint mode.
This was an oversight from me in the above commit, sorry. Thanks to
Roman Mamedov for reporting this!
Reported-by: Roman Mamedov <rm@romanrm.ru>
Cc: David Miller <davem@davemloft.net>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
David, could you please (after review) put this in the stable queue for
a potential v3.9.9 release? It is only applicable for v3.9. Thanks!
net/ipv6/sit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 3353634..60df36d 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -589,7 +589,7 @@ static int ipip6_rcv(struct sk_buff *skb)
tunnel->dev->stats.rx_errors++;
goto out;
}
- } else {
+ } else if (!(tunnel->dev->flags&IFF_POINTOPOINT)) {
if (is_spoofed_6rd(tunnel, iph->saddr,
&ipv6_hdr(skb)->saddr) ||
is_spoofed_6rd(tunnel, iph->daddr,
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ipv6: only apply anti-spoofing checks to not-pointopoint tunnels
2013-06-27 20:46 [PATCH net] ipv6: only apply anti-spoofing checks to not-pointopoint tunnels Hannes Frederic Sowa
@ 2013-07-01 20:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-01 20:26 UTC (permalink / raw)
To: hannes; +Cc: netdev, rm, yoshfuji
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Thu, 27 Jun 2013 22:46:04 +0200
> Because of commit 218774dc341f219bfcf940304a081b121a0e8099 ("ipv6: add
> anti-spoofing checks for 6to4 and 6rd") the sit driver dropped packets
> for 2002::/16 destinations and sources even when configured to work as a
> tunnel with fixed endpoint. We may only apply the 6rd/6to4 anti-spoofing
> checks if the device is not in pointopoint mode.
>
> This was an oversight from me in the above commit, sorry. Thanks to
> Roman Mamedov for reporting this!
>
> Reported-by: Roman Mamedov <rm@romanrm.ru>
> Cc: David Miller <davem@davemloft.net>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-01 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-27 20:46 [PATCH net] ipv6: only apply anti-spoofing checks to not-pointopoint tunnels Hannes Frederic Sowa
2013-07-01 20:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.