* [U-Boot] [PATCH 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting @ 2013-06-28 16:41 Lukasz Majewski 2013-06-28 16:41 ` [U-Boot] [PATCH 2/2] dfu:ext4:fix Fix DFU upload functionality Lukasz Majewski 2013-07-03 19:33 ` [U-Boot] [U-Boot, 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Tom Rini 0 siblings, 2 replies; 14+ messages in thread From: Lukasz Majewski @ 2013-06-28 16:41 UTC (permalink / raw) To: u-boot In the following commit: "dfu: Support larger than memory transfers." SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839 The ext4{read|write} command formatting has been changed. It removed a write mandatory [sizebytes] parameter. It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory parameter for DFU write. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou <panto@antoniou-consulting.com> Cc: Marek Vasut <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> --- drivers/dfu/dfu_mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index e2f3978..e7ee077 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @@ -98,6 +98,8 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, op == DFU_OP_READ ? "load" : "write", dfu->data.mmc.dev, dfu->data.mmc.part, (unsigned int) buf, dfu->name); + if (op == DFU_OP_WRITE) + sprintf(cmd_buf + strlen(cmd_buf), " %ld", *len); break; default: printf("%s: Layout (%s) not (yet) supported!\n", __func__, -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-06-28 16:41 [U-Boot] [PATCH 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Lukasz Majewski @ 2013-06-28 16:41 ` Lukasz Majewski 2013-07-03 19:33 ` [U-Boot] [U-Boot, " Tom Rini 2013-07-03 19:33 ` [U-Boot] [U-Boot, 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Tom Rini 1 sibling, 1 reply; 14+ messages in thread From: Lukasz Majewski @ 2013-06-28 16:41 UTC (permalink / raw) To: u-boot For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*]. For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou <panto@antoniou-consulting.com> Cc: Marek Vasut <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> --- drivers/dfu/dfu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index e429d74..0521752 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -248,7 +248,11 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) __func__, dfu->name, buf, size, blk_seq_num, dfu->i_buf); if (!dfu->inited) { - ret = dfu->read_medium(dfu, 0, buf, &dfu->r_left); + dfu->i_buf_start = dfu_get_buf(); + if (dfu->i_buf_start == NULL) + return -ENOMEM; + + ret = dfu->read_medium(dfu, 0, dfu->i_buf_start, &dfu->r_left); if (ret != 0) { debug("%s: failed to get r_left\n", __func__); return ret; @@ -259,9 +263,6 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) dfu->i_blk_seq_num = 0; dfu->crc = 0; dfu->offset = 0; - dfu->i_buf_start = dfu_get_buf(); - if (dfu->i_buf_start == NULL) - return -ENOMEM; dfu->i_buf_end = dfu_get_buf() + dfu_buf_size; dfu->i_buf = dfu->i_buf_start; dfu->b_left = 0; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-06-28 16:41 ` [U-Boot] [PATCH 2/2] dfu:ext4:fix Fix DFU upload functionality Lukasz Majewski @ 2013-07-03 19:33 ` Tom Rini 2013-07-03 21:49 ` Marek Vasut 0 siblings, 1 reply; 14+ messages in thread From: Tom Rini @ 2013-07-03 19:33 UTC (permalink / raw) To: u-boot On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > For the first eMMC read of data for upload, use the "large" dfu_buf (now > configurable) instead of usb request buffer allocated at composite layer > (which is 4KiB) [*]. > > For eMMC the whole file is read, which usually is larger than the buffer [*] > provided with usb request. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Cc: Tom Rini <trini@ti.com> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130703/179f6fd6/attachment.pgp> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-03 19:33 ` [U-Boot] [U-Boot, " Tom Rini @ 2013-07-03 21:49 ` Marek Vasut 2013-07-05 12:48 ` Tom Rini 0 siblings, 1 reply; 14+ messages in thread From: Marek Vasut @ 2013-07-03 21:49 UTC (permalink / raw) To: u-boot Dear Tom Rini, > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > For the first eMMC read of data for upload, use the "large" dfu_buf (now > > configurable) instead of usb request buffer allocated at composite layer > > (which is 4KiB) [*]. > > > > For eMMC the whole file is read, which usually is larger than the buffer > > [*] provided with usb request. > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > Cc: Tom Rini <trini@ti.com> > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Heiko Schocher <hs@denx.de> > > Applied to u-boot/master, thanks! Tom, why are you picking USB changes now? This is creating quite some mess ... Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-03 21:49 ` Marek Vasut @ 2013-07-05 12:48 ` Tom Rini 2013-07-05 13:55 ` Marek Vasut 0 siblings, 1 reply; 14+ messages in thread From: Tom Rini @ 2013-07-05 12:48 UTC (permalink / raw) To: u-boot On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > Dear Tom Rini, > > > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > > For the first eMMC read of data for upload, use the "large" dfu_buf (now > > > configurable) instead of usb request buffer allocated at composite layer > > > (which is 4KiB) [*]. > > > > > > For eMMC the whole file is read, which usually is larger than the buffer > > > [*] provided with usb request. > > > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > Cc: Tom Rini <trini@ti.com> > > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Heiko Schocher <hs@denx.de> > > > > Applied to u-boot/master, thanks! > > Tom, why are you picking USB changes now? This is creating quite some mess ... Just trying to clear up the queue of fixes. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130705/79e8e474/attachment.pgp> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-05 12:48 ` Tom Rini @ 2013-07-05 13:55 ` Marek Vasut 2013-07-05 14:09 ` Tom Rini 0 siblings, 1 reply; 14+ messages in thread From: Marek Vasut @ 2013-07-05 13:55 UTC (permalink / raw) To: u-boot Dear Tom Rini, > On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > Dear Tom Rini, > > > > > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > > > For the first eMMC read of data for upload, use the "large" dfu_buf > > > > (now configurable) instead of usb request buffer allocated at > > > > composite layer (which is 4KiB) [*]. > > > > > > > > For eMMC the whole file is read, which usually is larger than the > > > > buffer [*] provided with usb request. > > > > > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > > Cc: Tom Rini <trini@ti.com> > > > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Heiko Schocher <hs@denx.de> > > > > > > Applied to u-boot/master, thanks! > > > > Tom, why are you picking USB changes now? This is creating quite some > > mess ... > > Just trying to clear up the queue of fixes. Ok, if you manage to merge it with the USB PR ... Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-05 13:55 ` Marek Vasut @ 2013-07-05 14:09 ` Tom Rini 2013-07-05 14:32 ` Marek Vasut 0 siblings, 1 reply; 14+ messages in thread From: Tom Rini @ 2013-07-05 14:09 UTC (permalink / raw) To: u-boot -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/05/2013 09:55 AM, Marek Vasut wrote: > Dear Tom Rini, > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: >>> Dear Tom Rini, >>> >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski >>>> wrote: >>>>> For the first eMMC read of data for upload, use the "large" >>>>> dfu_buf (now configurable) instead of usb request buffer >>>>> allocated at composite layer (which is 4KiB) [*]. >>>>> >>>>> For eMMC the whole file is read, which usually is larger >>>>> than the buffer [*] provided with usb request. >>>>> >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> >>>> >>>> Applied to u-boot/master, thanks! >>> >>> Tom, why are you picking USB changes now? This is creating >>> quite some mess ... >> >> Just trying to clear up the queue of fixes. > > Ok, if you manage to merge it with the USB PR ... Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :) - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR1tOoAAoJENk4IS6UOR1WUToP/1+NJg5S9fFWaFWFfya0eRhi N3qdiA9bTs2hye/EwPB75HQ7tllWmr5/pHwFXLvkrCbV8pL/P2SnSch/lmN4PX7l qC6EEz5xlgpy0vhPQ8S+rLgoa2qavurBFAR2G3D+s2s4NkjSTmUrs/VHnzXOexKI 6DG4gu8FrNBvE0SMCfuXHJcRD7rEvXYsDH0sz+21DlhFr/WIk1ErREP3rXHk0ffp b0rOWvdYTQcceYDgXS70JSXpwmRl/QWga8UpdseNtujhz18RX3C8W8XG6dSoTZGv CYZQzAldU9k5y/S1c7t1W87Himc6bZfcuTYlXpvAB2isN02S3jQmzmdFZ95xc0Lv AZUV05VRAsVKXkwihpmxUCBwTafzcczFjm48bdJ5n5Qvpy5VnwsiFucHyB4/9ikv 1e3eOueaxLaMNHCHfiP/J8tr8/4H8M+dq4HKQvjZdmCsBqEHiKUUDQIKTFaryOg2 sohWAH6v76qK2CjQ2I2rHju1lMeLeOHpR33ZUb0FBVLRVzdZl9QD3rTRuW840pPt OCdscioGWatJ0YkND4giCey15O38IaKQ0Q6McqoZe/GIhvt2tqTWJrKdM1d76lXZ 9TaYLKxY20GAvfxPAopUaNdnwFiu3uefwZpMsJGbqg+aJyOuncCqXRDKprru9bbj chpFHxwvm/wGhkLDleeO =XazZ -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-05 14:09 ` Tom Rini @ 2013-07-05 14:32 ` Marek Vasut 2013-07-05 15:25 ` Lukasz Majewski 0 siblings, 1 reply; 14+ messages in thread From: Marek Vasut @ 2013-07-05 14:32 UTC (permalink / raw) To: u-boot Dear Tom Rini, > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > Dear Tom Rini, > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > >>> Dear Tom Rini, > >>> > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > >>>> > >>>> wrote: > >>>>> For the first eMMC read of data for upload, use the "large" > >>>>> dfu_buf (now configurable) instead of usb request buffer > >>>>> allocated at composite layer (which is 4KiB) [*]. > >>>>> > >>>>> For eMMC the whole file is read, which usually is larger > >>>>> than the buffer [*] provided with usb request. > >>>>> > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > >>>> > >>>> Applied to u-boot/master, thanks! > >>> > >>> Tom, why are you picking USB changes now? This is creating > >>> quite some mess ... > >> > >> Just trying to clear up the queue of fixes. > > > > Ok, if you manage to merge it with the USB PR ... > > Yup, fit right on top. I'll stop being an overarching custodian and > let you grab the copyright fix :) I see discussion , not patch. Link? Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-05 14:32 ` Marek Vasut @ 2013-07-05 15:25 ` Lukasz Majewski 2013-07-07 6:43 ` Sumit Gemini 0 siblings, 1 reply; 14+ messages in thread From: Lukasz Majewski @ 2013-07-05 15:25 UTC (permalink / raw) To: u-boot On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: Hi, > Dear Tom Rini, > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > Dear Tom Rini, > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > >>> Dear Tom Rini, > > >>> > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > >>>> > > >>>> wrote: > > >>>>> For the first eMMC read of data for upload, use the "large" > > >>>>> dfu_buf (now configurable) instead of usb request buffer > > >>>>> allocated at composite layer (which is 4KiB) [*]. > > >>>>> > > >>>>> For eMMC the whole file is read, which usually is larger > > >>>>> than the buffer [*] provided with usb request. > > >>>>> > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > >>>> > > >>>> Applied to u-boot/master, thanks! > > >>> > > >>> Tom, why are you picking USB changes now? This is creating > > >>> quite some mess ... > > >> > > >> Just trying to clear up the queue of fixes. > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > Yup, fit right on top. I'll stop being an overarching custodian and > > let you grab the copyright fix :) > > I see discussion , not patch. Link? > Here you are: http://patchwork.ozlabs.org/patch/257068/ :-) > Best regards, > Marek Vasut > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-05 15:25 ` Lukasz Majewski @ 2013-07-07 6:43 ` Sumit Gemini 2013-07-08 6:22 ` Lukasz Majewski 0 siblings, 1 reply; 14+ messages in thread From: Sumit Gemini @ 2013-07-07 6:43 UTC (permalink / raw) To: u-boot HI All, May i know how DFU upload functionality resolved as still i am facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done. Please give me pointer to solution of this problem Regards ~Sumit Gemini On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski <l.majewski@samsung.com>wrote: > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: > > Hi, > > > Dear Tom Rini, > > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > > Dear Tom Rini, > > > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > > >>> Dear Tom Rini, > > > >>> > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > > >>>> > > > >>>> wrote: > > > >>>>> For the first eMMC read of data for upload, use the "large" > > > >>>>> dfu_buf (now configurable) instead of usb request buffer > > > >>>>> allocated at composite layer (which is 4KiB) [*]. > > > >>>>> > > > >>>>> For eMMC the whole file is read, which usually is larger > > > >>>>> than the buffer [*] provided with usb request. > > > >>>>> > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > > > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > > >>>> > > > >>>> Applied to u-boot/master, thanks! > > > >>> > > > >>> Tom, why are you picking USB changes now? This is creating > > > >>> quite some mess ... > > > >> > > > >> Just trying to clear up the queue of fixes. > > > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > > > Yup, fit right on top. I'll stop being an overarching custodian and > > > let you grab the copyright fix :) > > > > I see discussion , not patch. Link? > > > > Here you are: > http://patchwork.ozlabs.org/patch/257068/ > > :-) > > > Best regards, > > Marek Vasut > > _______________________________________________ > > U-Boot mailing list > > U-Boot at lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-07 6:43 ` Sumit Gemini @ 2013-07-08 6:22 ` Lukasz Majewski 2013-07-08 8:59 ` Sumit Gemini 0 siblings, 1 reply; 14+ messages in thread From: Lukasz Majewski @ 2013-07-08 6:22 UTC (permalink / raw) To: u-boot On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote: Hi Sumit, > HI All, > May i know how DFU upload functionality resolved as still i am > facing problem, when i tried to upload binaries from dfu devices it > copied only 4kb images and shoes upload done. From what medium do you copy? Is that NAND or eMMC device. Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs. > > Please give me pointer to solution of this problem > > Regards > ~Sumit Gemini > > > On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski > <l.majewski@samsung.com>wrote: > > > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: > > > > Hi, > > > > > Dear Tom Rini, > > > > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > > > Dear Tom Rini, > > > > > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > > > >>> Dear Tom Rini, > > > > >>> > > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > > > >>>> > > > > >>>> wrote: > > > > >>>>> For the first eMMC read of data for upload, use the > > > > >>>>> "large" dfu_buf (now configurable) instead of usb request > > > > >>>>> buffer allocated at composite layer (which is 4KiB) [*]. > > > > >>>>> > > > > >>>>> For eMMC the whole file is read, which usually is larger > > > > >>>>> than the buffer [*] provided with usb request. > > > > >>>>> > > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > > >>>>> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > > > >>>> > > > > >>>> Applied to u-boot/master, thanks! > > > > >>> > > > > >>> Tom, why are you picking USB changes now? This is creating > > > > >>> quite some mess ... > > > > >> > > > > >> Just trying to clear up the queue of fixes. > > > > > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > > > > > Yup, fit right on top. I'll stop being an overarching > > > > custodian and let you grab the copyright fix :) > > > > > > I see discussion , not patch. Link? > > > > > > > Here you are: > > http://patchwork.ozlabs.org/patch/257068/ > > > > :-) > > > > > Best regards, > > > Marek Vasut > > > _______________________________________________ > > > U-Boot mailing list > > > U-Boot at lists.denx.de > > > http://lists.denx.de/mailman/listinfo/u-boot > > > > > > -- > > Best regards, > > > > Lukasz Majewski > > > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > > _______________________________________________ > > U-Boot mailing list > > U-Boot at lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-08 6:22 ` Lukasz Majewski @ 2013-07-08 8:59 ` Sumit Gemini 2013-07-08 14:16 ` Tom Rini 0 siblings, 1 reply; 14+ messages in thread From: Sumit Gemini @ 2013-07-08 8:59 UTC (permalink / raw) To: u-boot HI Lukasz, I am using spi nor flash, and may i know the fixes which you fixed, and all changes. because i am facing problem only in upload. Please help me in this issue. Thanks ~Sumit On Mon, Jul 8, 2013 at 11:52 AM, Lukasz Majewski <l.majewski@samsung.com>wrote: > On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote: > > Hi Sumit, > > > HI All, > > May i know how DFU upload functionality resolved as still i am > > facing problem, when i tried to upload binaries from dfu devices it > > copied only 4kb images and shoes upload done. > > From what medium do you copy? Is that NAND or eMMC device. > > Have you applied all fixes related to DFU (which were posted recently)? > One interesting change it the "configurable" buffer, which might be > defined from envs. > > > > > Please give me pointer to solution of this problem > > > > Regards > > ~Sumit Gemini > > > > > > On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski > > <l.majewski@samsung.com>wrote: > > > > > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: > > > > > > Hi, > > > > > > > Dear Tom Rini, > > > > > > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > > > > Dear Tom Rini, > > > > > > > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > > > > >>> Dear Tom Rini, > > > > > >>> > > > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > > > > >>>> > > > > > >>>> wrote: > > > > > >>>>> For the first eMMC read of data for upload, use the > > > > > >>>>> "large" dfu_buf (now configurable) instead of usb request > > > > > >>>>> buffer allocated at composite layer (which is 4KiB) [*]. > > > > > >>>>> > > > > > >>>>> For eMMC the whole file is read, which usually is larger > > > > > >>>>> than the buffer [*] provided with usb request. > > > > > >>>>> > > > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > > > >>>>> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > > > > >>>> > > > > > >>>> Applied to u-boot/master, thanks! > > > > > >>> > > > > > >>> Tom, why are you picking USB changes now? This is creating > > > > > >>> quite some mess ... > > > > > >> > > > > > >> Just trying to clear up the queue of fixes. > > > > > > > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > > > > > > > Yup, fit right on top. I'll stop being an overarching > > > > > custodian and let you grab the copyright fix :) > > > > > > > > I see discussion , not patch. Link? > > > > > > > > > > Here you are: > > > http://patchwork.ozlabs.org/patch/257068/ > > > > > > :-) > > > > > > > Best regards, > > > > Marek Vasut > > > > _______________________________________________ > > > > U-Boot mailing list > > > > U-Boot at lists.denx.de > > > > http://lists.denx.de/mailman/listinfo/u-boot > > > > > > > > > -- > > > Best regards, > > > > > > Lukasz Majewski > > > > > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > > > _______________________________________________ > > > U-Boot mailing list > > > U-Boot at lists.denx.de > > > http://lists.denx.de/mailman/listinfo/u-boot > > > > > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 2/2] dfu:ext4:fix Fix DFU upload functionality 2013-07-08 8:59 ` Sumit Gemini @ 2013-07-08 14:16 ` Tom Rini 0 siblings, 0 replies; 14+ messages in thread From: Tom Rini @ 2013-07-08 14:16 UTC (permalink / raw) To: u-boot -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/08/2013 04:59 AM, Sumit Gemini wrote: > HI Lukasz, > > I am using spi nor flash, and may i know the fixes which you > fixed, and all changes. because i am facing problem only in > upload. This means you are not using mainline, as we do not have DFU for SPI. Please post it, or hassle your vendor (I suspect I know who it is) to get the patches posted. Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR2sm9AAoJENk4IS6UOR1WuRUP/iKBpBTUO+hAphWC+kqrjAgn 5z0zQbZNSL4S2eGCdI4ApmVs7uMxavPFf2hukwX4pJal631G8AkAPfgfiYRMYZ3U iv6mkhwSV0IMxE4zemcZkfABILo+O5+2RlJo7QUvSaNs5c3xNBkdIb20797ORinS MNi17zYeFph8NDYz/TTcIE0MWLwcH/skW8jabw6skgaeoEa+wUIJTayExe7thTcJ S1ZuAk6WQ5SKQ5hAdKTjNtPTv35ZK5IFYp1HIKpCiq2RHCUHzuvgdlz60fcbdQSI 9Av9c+9zWO90vEFK+0dT8LkdRylPrGdH/CnRNFep9DKnHUrBPdMGIYN94MRCpIiJ TWIPD2LvquwJAMeARw9Wak+fnTb/7K1xMN2A+LyRV+N6sRgB46b71lQkE/I5+6E3 QC0RD4pG70gXQSmJfolpwgjdk3NvFuzDGTasjW0e23I6znKivGvTJU56fs4lZ9Mi jvRk9qeWVL4JrFXVXcvciRUXgaNk3GNymvkJd+QUybh+ZW09NEaLMpBAye9xg80Q eQd4acdg92P8x7/3avKS8Z2xjWqLvwOPJD8ux2lmEMq6PnVH7bRxHCyW1ZNI4vQk wc9Gbt0TTFVax0v/lxqtXgpr7y4WqjvQPWh1cTErkELo00tdx95q4xeKvQHl4Oyi +h/+U2ot7gBB82SfYk+x =fB83 -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [U-Boot, 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting 2013-06-28 16:41 [U-Boot] [PATCH 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Lukasz Majewski 2013-06-28 16:41 ` [U-Boot] [PATCH 2/2] dfu:ext4:fix Fix DFU upload functionality Lukasz Majewski @ 2013-07-03 19:33 ` Tom Rini 1 sibling, 0 replies; 14+ messages in thread From: Tom Rini @ 2013-07-03 19:33 UTC (permalink / raw) To: u-boot On Fri, Jun 28, 2013 at 06:41:49PM +0200, ??ukasz Majewski wrote: > In the following commit: > "dfu: Support larger than memory transfers." > SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839 > > The ext4{read|write} command formatting has been changed. It removed > a write mandatory [sizebytes] parameter. > > It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory > parameter for DFU write. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Cc: Tom Rini <trini@ti.com> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130703/bcfe6cb8/attachment.pgp> ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-07-08 14:16 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-06-28 16:41 [U-Boot] [PATCH 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Lukasz Majewski 2013-06-28 16:41 ` [U-Boot] [PATCH 2/2] dfu:ext4:fix Fix DFU upload functionality Lukasz Majewski 2013-07-03 19:33 ` [U-Boot] [U-Boot, " Tom Rini 2013-07-03 21:49 ` Marek Vasut 2013-07-05 12:48 ` Tom Rini 2013-07-05 13:55 ` Marek Vasut 2013-07-05 14:09 ` Tom Rini 2013-07-05 14:32 ` Marek Vasut 2013-07-05 15:25 ` Lukasz Majewski 2013-07-07 6:43 ` Sumit Gemini 2013-07-08 6:22 ` Lukasz Majewski 2013-07-08 8:59 ` Sumit Gemini 2013-07-08 14:16 ` Tom Rini 2013-07-03 19:33 ` [U-Boot] [U-Boot, 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.