From: Mark Brown <broonie@kernel.org>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"kiran.padwal" <kiran.padwal@kpitcummins.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name
Date: Fri, 5 Jul 2013 14:37:52 +0100 [thread overview]
Message-ID: <20130705133752.GX27646@sirena.org.uk> (raw)
In-Reply-To: <1373031306.3233.131.camel@matrix>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Fri, Jul 05, 2013 at 07:05:06PM +0530, Ashish Chavan wrote:
> On Fri, 2013-07-05 at 12:44 +0100, Mark Brown wrote:
> > > static const struct i2c_device_id da9055_i2c_id[] = {
> > > - { "da9055", 0 },
> > > + { "da9055-codec", 0 },
> > > { }
> > > };
> > I can't believe that you've tested this.
> Yes, I have tested this today only. But with 3.6.0-rc4 kernel. That is
> the newest kernel for which I have board and other required support
> available.
Your testing seems like it's not very good then - you do undersand that
the problem that this is supposed to be fixing is that this is a multi
function device? Please look at how other MFDs in the kernel work.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>,
"kiran.padwal" <kiran.padwal@kpitcummins.com>, lrg <lrg@ti.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name
Date: Fri, 5 Jul 2013 14:37:52 +0100 [thread overview]
Message-ID: <20130705133752.GX27646@sirena.org.uk> (raw)
In-Reply-To: <1373031306.3233.131.camel@matrix>
[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]
On Fri, Jul 05, 2013 at 07:05:06PM +0530, Ashish Chavan wrote:
> On Fri, 2013-07-05 at 12:44 +0100, Mark Brown wrote:
> > > static const struct i2c_device_id da9055_i2c_id[] = {
> > > - { "da9055", 0 },
> > > + { "da9055-codec", 0 },
> > > { }
> > > };
> > I can't believe that you've tested this.
> Yes, I have tested this today only. But with 3.6.0-rc4 kernel. That is
> the newest kernel for which I have board and other required support
> available.
Your testing seems like it's not very good then - you do undersand that
the problem that this is supposed to be fixing is that this is a multi
function device? Please look at how other MFDs in the kernel work.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-07-05 13:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 11:47 [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name Ashish Chavan
2013-07-05 11:44 ` [alsa-devel] " Mark Brown
2013-07-05 11:44 ` Mark Brown
2013-07-05 13:35 ` Ashish Chavan
2013-07-05 13:37 ` Mark Brown [this message]
2013-07-05 13:37 ` Mark Brown
2013-07-08 7:54 ` Ashish Chavan
2013-07-08 11:26 ` [alsa-devel] " Mark Brown
2013-07-08 11:26 ` Mark Brown
2013-07-11 11:36 ` Ashish Chavan
2013-07-17 10:36 ` [alsa-devel] " Mark Brown
2013-07-17 10:36 ` Mark Brown
2013-07-22 8:43 ` Ashish Chavan
2013-07-22 10:02 ` [alsa-devel] " Mark Brown
2013-07-22 10:02 ` Mark Brown
2013-07-29 15:06 ` Ashish Chavan
2013-07-29 16:01 ` [alsa-devel] " Mark Brown
2013-08-05 7:55 ` Ashish Chavan
2013-08-05 14:42 ` [alsa-devel] " Mark Brown
2013-08-05 14:42 ` Mark Brown
2013-08-05 15:51 ` Ashish Chavan
2013-08-05 16:23 ` [alsa-devel] " Mark Brown
2013-08-29 12:08 ` Ashish Chavan
2013-09-02 9:49 ` Opensource [Adam Thomson]
2013-09-02 10:38 ` [alsa-devel] " Mark Brown
2013-09-02 15:38 ` Opensource [Adam Thomson]
2013-09-02 17:41 ` [alsa-devel] " Mark Brown
2013-09-02 17:41 ` Mark Brown
2013-09-04 16:13 ` Opensource [Adam Thomson]
2013-09-04 18:34 ` [alsa-devel] " Mark Brown
2013-09-04 18:34 ` Mark Brown
2013-09-06 14:17 ` Opensource [Adam Thomson]
2013-09-09 11:26 ` [alsa-devel] " Mark Brown
2013-09-09 11:26 ` Mark Brown
2013-09-10 13:05 ` Opensource [Adam Thomson]
2013-09-10 17:07 ` [alsa-devel] " Mark Brown
2013-09-10 17:07 ` Mark Brown
2013-09-12 17:11 ` Opensource [Adam Thomson]
2013-09-12 21:58 ` [alsa-devel] " Mark Brown
2013-09-13 15:05 ` Opensource [Adam Thomson]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705133752.GX27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kiran.padwal@kpitcummins.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.