* [PATCH] tools/virtio: move module license stub to module.h
@ 2013-07-07 14:29 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:29 UTC (permalink / raw)
To: kvm; +Cc: Rusty Russell, Wanlong Gao, Asias He, linux-kernel, virtualization
This fixes build for the vringh test:
[linux]$ make -C tools/virtio/
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
-U_FORTIFY_SOURCE -c -o vringh.o ../../drivers/vhost/vringh.c
../../drivers/vhost/vringh.c:1010:16: error: expected declaration
specifiers or ‘...’ before string constant
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tools/virtio/linux/module.h | 5 +++++
tools/virtio/linux/virtio.h | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
index 3039a7e..28ce95a 100644
--- a/tools/virtio/linux/module.h
+++ b/tools/virtio/linux/module.h
@@ -1 +1,6 @@
#include <linux/export.h>
+
+#define MODULE_LICENSE(__MODULE_LICENSE_value) \
+ static __attribute__((unused)) const char *__MODULE_LICENSE_name = \
+ __MODULE_LICENSE_value
+
diff --git a/tools/virtio/linux/virtio.h b/tools/virtio/linux/virtio.h
index cd80183..8447830 100644
--- a/tools/virtio/linux/virtio.h
+++ b/tools/virtio/linux/virtio.h
@@ -45,9 +45,6 @@ struct virtqueue {
void *priv;
};
-#define MODULE_LICENSE(__MODULE_LICENSE_value) \
- const char *__MODULE_LICENSE_name = __MODULE_LICENSE_value
-
/* Interfaces exported by virtio_ring. */
int virtqueue_add_sgs(struct virtqueue *vq,
struct scatterlist *sgs[],
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] tools/virtio: move module license stub to module.h
@ 2013-07-07 14:29 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:29 UTC (permalink / raw)
To: kvm; +Cc: linux-kernel, virtualization
This fixes build for the vringh test:
[linux]$ make -C tools/virtio/
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
-U_FORTIFY_SOURCE -c -o vringh.o ../../drivers/vhost/vringh.c
../../drivers/vhost/vringh.c:1010:16: error: expected declaration
specifiers or ‘...’ before string constant
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tools/virtio/linux/module.h | 5 +++++
tools/virtio/linux/virtio.h | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
index 3039a7e..28ce95a 100644
--- a/tools/virtio/linux/module.h
+++ b/tools/virtio/linux/module.h
@@ -1 +1,6 @@
#include <linux/export.h>
+
+#define MODULE_LICENSE(__MODULE_LICENSE_value) \
+ static __attribute__((unused)) const char *__MODULE_LICENSE_name = \
+ __MODULE_LICENSE_value
+
diff --git a/tools/virtio/linux/virtio.h b/tools/virtio/linux/virtio.h
index cd80183..8447830 100644
--- a/tools/virtio/linux/virtio.h
+++ b/tools/virtio/linux/virtio.h
@@ -45,9 +45,6 @@ struct virtqueue {
void *priv;
};
-#define MODULE_LICENSE(__MODULE_LICENSE_value) \
- const char *__MODULE_LICENSE_name = __MODULE_LICENSE_value
-
/* Interfaces exported by virtio_ring. */
int virtqueue_add_sgs(struct virtqueue *vq,
struct scatterlist *sgs[],
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/virtio: move module license stub to module.h
2013-07-07 14:29 ` Michael S. Tsirkin
@ 2013-07-08 2:02 ` Rusty Russell
-1 siblings, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2013-07-08 2:02 UTC (permalink / raw)
To: Michael S. Tsirkin, kvm
Cc: Wanlong Gao, Asias He, linux-kernel, virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> This fixes build for the vringh test:
> [linux]$ make -C tools/virtio/
> make: Entering directory `/home/mst/scm/linux/tools/virtio'
> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
> -U_FORTIFY_SOURCE -c -o vringh.o ../../drivers/vhost/vringh.c
> ../../drivers/vhost/vringh.c:1010:16: error: expected declaration
> specifiers or ‘...’ before string constant
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> tools/virtio/linux/module.h | 5 +++++
> tools/virtio/linux/virtio.h | 3 ---
> 2 files changed, 5 insertions(+), 3 deletions(-)
Applied, thanks.
Cheers,
Rusty.
> diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
> index 3039a7e..28ce95a 100644
> --- a/tools/virtio/linux/module.h
> +++ b/tools/virtio/linux/module.h
> @@ -1 +1,6 @@
> #include <linux/export.h>
> +
> +#define MODULE_LICENSE(__MODULE_LICENSE_value) \
> + static __attribute__((unused)) const char *__MODULE_LICENSE_name = \
> + __MODULE_LICENSE_value
> +
> diff --git a/tools/virtio/linux/virtio.h b/tools/virtio/linux/virtio.h
> index cd80183..8447830 100644
> --- a/tools/virtio/linux/virtio.h
> +++ b/tools/virtio/linux/virtio.h
> @@ -45,9 +45,6 @@ struct virtqueue {
> void *priv;
> };
>
> -#define MODULE_LICENSE(__MODULE_LICENSE_value) \
> - const char *__MODULE_LICENSE_name = __MODULE_LICENSE_value
> -
> /* Interfaces exported by virtio_ring. */
> int virtqueue_add_sgs(struct virtqueue *vq,
> struct scatterlist *sgs[],
> --
> MST
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/virtio: move module license stub to module.h
@ 2013-07-08 2:02 ` Rusty Russell
0 siblings, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2013-07-08 2:02 UTC (permalink / raw)
To: Michael S. Tsirkin, kvm; +Cc: linux-kernel, virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> This fixes build for the vringh test:
> [linux]$ make -C tools/virtio/
> make: Entering directory `/home/mst/scm/linux/tools/virtio'
> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
> -U_FORTIFY_SOURCE -c -o vringh.o ../../drivers/vhost/vringh.c
> ../../drivers/vhost/vringh.c:1010:16: error: expected declaration
> specifiers or ‘...’ before string constant
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> tools/virtio/linux/module.h | 5 +++++
> tools/virtio/linux/virtio.h | 3 ---
> 2 files changed, 5 insertions(+), 3 deletions(-)
Applied, thanks.
Cheers,
Rusty.
> diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
> index 3039a7e..28ce95a 100644
> --- a/tools/virtio/linux/module.h
> +++ b/tools/virtio/linux/module.h
> @@ -1 +1,6 @@
> #include <linux/export.h>
> +
> +#define MODULE_LICENSE(__MODULE_LICENSE_value) \
> + static __attribute__((unused)) const char *__MODULE_LICENSE_name = \
> + __MODULE_LICENSE_value
> +
> diff --git a/tools/virtio/linux/virtio.h b/tools/virtio/linux/virtio.h
> index cd80183..8447830 100644
> --- a/tools/virtio/linux/virtio.h
> +++ b/tools/virtio/linux/virtio.h
> @@ -45,9 +45,6 @@ struct virtqueue {
> void *priv;
> };
>
> -#define MODULE_LICENSE(__MODULE_LICENSE_value) \
> - const char *__MODULE_LICENSE_name = __MODULE_LICENSE_value
> -
> /* Interfaces exported by virtio_ring. */
> int virtqueue_add_sgs(struct virtqueue *vq,
> struct scatterlist *sgs[],
> --
> MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-08 2:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-07 14:29 [PATCH] tools/virtio: move module license stub to module.h Michael S. Tsirkin
2013-07-07 14:29 ` Michael S. Tsirkin
2013-07-08 2:02 ` Rusty Russell
2013-07-08 2:02 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.