Re: [LTP] [PATCH] runltp: try to create ext3 loop device if creating ext4 failed

Re: [LTP] [PATCH] runltp: try to create ext3 loop device if creating ext4 failed

[chrubis]

Hi!
> Try to create ext3 loop device if creating ext4 failed since
> some old system can't support ext4 file system or the root
> file system still use ext3 file system.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
>  runltp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/runltp b/runltp
> index 1309d0a..2c13b56 100755
> --- a/runltp
> +++ b/runltp
> @@ -1002,7 +1002,8 @@ create_block()
>                  return 1
>              else
>                  mkfs.ext4 $LOOP_DEV
> -                [ $? -ne 0 ] && (echo "creating a ext4 block device failed" && return 1)
> +                [ $? -ne 0 ] && (mkfs.ext3 $LOOP_DEV)
> +                [ $? -ne 0 ] && (echo "creating a ext4/3 block device failed" && return 1)
>                  #set the values in alltests which require block device.
>                  DEVICE=$LOOP_DEV
>                  DEVICE_FS_TYPE="ext4"
                         ^
Hmm, you should set the DEVICE_FS_TYPE accordingly too. I wonder if
leaving it set to ext4 will work, have you tested the change?

Otherwise I'm fine with the change.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list